From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK
Date: Fri, 10 Jul 2020 17:31:24 +1000 [thread overview]
Message-ID: <20200710073124.GB2005@dread.disaster.area> (raw)
In-Reply-To: <20200710054652.353008-1-hch@lst.de>
On Fri, Jul 10, 2020 at 07:46:52AM +0200, Christoph Hellwig wrote:
> These two definitions are unused now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_icache.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
> index ae92ca53de423f..3a4c8b382cd0fe 100644
> --- a/fs/xfs/xfs_icache.h
> +++ b/fs/xfs/xfs_icache.h
> @@ -17,9 +17,6 @@ struct xfs_eofblocks {
> __u64 eof_min_file_size;
> };
>
> -#define SYNC_WAIT 0x0001 /* wait for i/o to complete */
> -#define SYNC_TRYLOCK 0x0002 /* only try to lock inodes */
Oh, I didn't realise they'd been removed from the EOF block scanner.
I was too busy removing them from inode reclaim to notice this had
occurred.
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-07-10 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 5:46 [PATCH] xfs: remove SYNC_WAIT and SYNC_TRYLOCK Christoph Hellwig
2020-07-10 7:31 ` Dave Chinner [this message]
2020-07-11 18:13 ` Chaitanya Kulkarni
2020-07-13 16:20 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710073124.GB2005@dread.disaster.area \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.