From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D50D6C433E2 for ; Fri, 10 Jul 2020 08:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA508207BC for ; Fri, 10 Jul 2020 08:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728005AbgGJIvc (ORCPT ); Fri, 10 Jul 2020 04:51:32 -0400 Received: from mga11.intel.com ([192.55.52.93]:47336 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727981AbgGJIv0 (ORCPT ); Fri, 10 Jul 2020 04:51:26 -0400 IronPort-SDR: e4uxyLUHGTEZnMEV/m8M8lKo7ocxaM+f+jHqiRpR025GltuEx22FJM58hLMzb37XWU/JtLqk7T lO+b8Dr/AuHw== X-IronPort-AV: E=McAfee;i="6000,8403,9677"; a="146240806" X-IronPort-AV: E=Sophos;i="5.75,335,1589266800"; d="scan'208";a="146240806" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2020 01:51:25 -0700 IronPort-SDR: LfnhsBzxBWY8tqtpOAFIpp4omzBPhlDDYPvGoaq55B3GhQW54uSzRM82CGAHOdwQ2stvXjmjP5 rAJiHPvmo/RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,335,1589266800"; d="scan'208";a="389432771" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 10 Jul 2020 01:51:22 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1jtokd-0011Rj-Fp; Fri, 10 Jul 2020 11:51:23 +0300 Date: Fri, 10 Jul 2020 11:51:23 +0300 From: Andy Shevchenko To: Serge Semin Cc: Vinod Koul , Viresh Kumar , Dan Williams , Serge Semin , Alexey Malahov , Thomas Bogendoerfer , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 08/11] dmaengine: dw: Add dummy device_caps callback Message-ID: <20200710085123.GF3703480@smile.fi.intel.com> References: <20200709224550.15539-1-Sergey.Semin@baikalelectronics.ru> <20200709224550.15539-9-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200709224550.15539-9-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, Jul 10, 2020 at 01:45:47AM +0300, Serge Semin wrote: > Since some DW DMA controllers (like one installed on Baikal-T1 SoC) may > have non-uniform DMA capabilities per device channels, let's add > the DW DMA specific device_caps callback to expose that specifics up to > the DMA consumer. It's a dummy function for now. We'll fill it in with > capabilities overrides in the next commits. Just a reminder (mainly to Vinod) of my view to this. Unneeded churn, should be folded to patch 9. > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Arnd Bergmann > Cc: Rob Herring > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org > > --- > > Changelog v3: > - This is a new patch created as a result of the discussion with Vinud and > Andy in the framework of DW DMA burst and LLP capabilities. > --- > drivers/dma/dw/core.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c > index fb95920c429e..ceded21537e2 100644 > --- a/drivers/dma/dw/core.c > +++ b/drivers/dma/dw/core.c > @@ -1049,6 +1049,11 @@ static void dwc_free_chan_resources(struct dma_chan *chan) > dev_vdbg(chan2dev(chan), "%s: done\n", __func__); > } > > +static void dwc_caps(struct dma_chan *chan, struct dma_slave_caps *caps) > +{ > + > +} > + > int do_dma_probe(struct dw_dma_chip *chip) > { > struct dw_dma *dw = chip->dw; > @@ -1214,6 +1219,7 @@ int do_dma_probe(struct dw_dma_chip *chip) > dw->dma.device_prep_dma_memcpy = dwc_prep_dma_memcpy; > dw->dma.device_prep_slave_sg = dwc_prep_slave_sg; > > + dw->dma.device_caps = dwc_caps; > dw->dma.device_config = dwc_config; > dw->dma.device_pause = dwc_pause; > dw->dma.device_resume = dwc_resume; > -- > 2.26.2 > -- With Best Regards, Andy Shevchenko