From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA41C433EB for ; Fri, 10 Jul 2020 17:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E792076A for ; Fri, 10 Jul 2020 17:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728368AbgGJRkz (ORCPT ); Fri, 10 Jul 2020 13:40:55 -0400 Received: from muru.com ([72.249.23.125]:33310 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbgGJRkx (ORCPT ); Fri, 10 Jul 2020 13:40:53 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1239780E5; Fri, 10 Jul 2020 17:41:46 +0000 (UTC) Date: Fri, 10 Jul 2020 10:40:51 -0700 From: Tony Lindgren To: Suman Anna Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tero Kristo Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Message-ID: <20200710174051.GG5849@atomide.com> References: <20200709231954.1973-1-s-anna@ti.com> <20200710165814.GF5849@atomide.com> <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Suman Anna [200710 17:18]: > On 7/10/20 11:58 AM, Tony Lindgren wrote: > > I wonder the following commit in v5.8-rc3 might help with this though: > > > > 5ce8aee81be6 ("bus: ti-sysc: Flush posted write on enable and disable") > > > > I had already tested on v5.8-rc4 when I posted the patches, so this patch > doesn't help. OMAP5 DSP is fine, because Think it has to do with this > automated OK > So, I am looking at the TRM, and the three VDD_{IVA,MPU,CORE}_I2C_DISABLE > bits in VOLTCTRL are marked debug-purpose only, so I don't think we should > be setting those to begin with. Any reason why you want to set those? > Anyway, these bits were not an issue, I have specifically tried that > already. I'm pretty sure that's how the old TI PM branch was initializing them to disable voltctrl I2C use on init. But if these are not the issue I guess no need to mess with them. Could it be that we have wrong voltage tables for 4460 in the mainline kernel? See earlier commit 32236a84906f ("ARM: OMAP2+: Update 4430 voltage controller operating points"). Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8DCC433E2 for ; Fri, 10 Jul 2020 17:42:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D99F2076A for ; Fri, 10 Jul 2020 17:42:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oE9fxjnI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D99F2076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UKv51buRtBmkSmY/h1/PknDW+OPUvXPi4YSChTZqTcE=; b=oE9fxjnIyMVp30g4H6Pc2UiEx nocwT4k70UNVWr2FgMaaKFIpWMt8VjxWKIlisk8eo4e3DX8g6a6+B20tT44D8BuXQH8zLdq3izD6+ JVz1bjexPXvHRflGtzhjy70u1jlsHDGzOII1x1j59nWBjDC8g7Zw4FCZspgG/hubsIqWKZgh3liqT RgcAez+ii1/NxbKJg3ygOnaVsdAkYmSdwDuWyhMDoG5COPut2bspHL3Fqk+EAXww5kBZxQQwGKfv8 QgzK/1wy0WaHU0U28egsXEjjpCy0b4+dLyvXjrgQz9VWVEA2pgOzszcRBxyYYRIWpWg2X7Qoz4taK y+q5gwEzQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtx19-0006X2-DM; Fri, 10 Jul 2020 17:40:59 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtx13-0006WU-Om for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 17:40:54 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1239780E5; Fri, 10 Jul 2020 17:41:46 +0000 (UTC) Date: Fri, 10 Jul 2020 10:40:51 -0700 From: Tony Lindgren To: Suman Anna Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Message-ID: <20200710174051.GG5849@atomide.com> References: <20200709231954.1973-1-s-anna@ti.com> <20200710165814.GF5849@atomide.com> <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_134053_849494_293E012E X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Suman Anna [200710 17:18]: > On 7/10/20 11:58 AM, Tony Lindgren wrote: > > I wonder the following commit in v5.8-rc3 might help with this though: > > > > 5ce8aee81be6 ("bus: ti-sysc: Flush posted write on enable and disable") > > > > I had already tested on v5.8-rc4 when I posted the patches, so this patch > doesn't help. OMAP5 DSP is fine, because Think it has to do with this > automated OK > So, I am looking at the TRM, and the three VDD_{IVA,MPU,CORE}_I2C_DISABLE > bits in VOLTCTRL are marked debug-purpose only, so I don't think we should > be setting those to begin with. Any reason why you want to set those? > Anyway, these bits were not an issue, I have specifically tried that > already. I'm pretty sure that's how the old TI PM branch was initializing them to disable voltctrl I2C use on init. But if these are not the issue I guess no need to mess with them. Could it be that we have wrong voltage tables for 4460 in the mainline kernel? See earlier commit 32236a84906f ("ARM: OMAP2+: Update 4430 voltage controller operating points"). Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel