From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0742C433DF for ; Fri, 10 Jul 2020 21:33:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A7632068F for ; Fri, 10 Jul 2020 21:33:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qrMNm9RH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A7632068F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B77D16ED16; Fri, 10 Jul 2020 21:33:05 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3FD26ED16 for ; Fri, 10 Jul 2020 21:33:03 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 277D02C0; Fri, 10 Jul 2020 23:33:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1594416781; bh=nYu/IMXHQAQClSwdjS4i7QELBaXDG0mkXozj0mEuu/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qrMNm9RHNUJeuHf2AzHCL6yx/JMpMQ0Ex5yN3TWWO/XwgNh5/CXCd86fEg9X5l05s s8XxrKIPn/Ugdz6t8ECH3oUtPeGFL5ANiwZx4nXPHaMz7BKYPI+wGBmbwoy54qkBpU Q7LLTiU4dpMJliFCRlH0syRki/qu9frcMnnFP98s= Date: Sat, 11 Jul 2020 00:32:54 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v3 01/21] drm/panel: add connector type to boe,hv070wsa-100 panel Message-ID: <20200710213254.GH5964@pendragon.ideasonboard.com> References: <20200703192417.372164-1-sam@ravnborg.org> <20200703192417.372164-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200703192417.372164-2-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Peter Senna Tschudin , kbuild test robot , Jonas Karlman , Neil Armstrong , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Martyn Welch Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Fri, Jul 03, 2020 at 09:23:57PM +0200, Sam Ravnborg wrote: > The boe,hv070wsa-100 panel is a LVDS panel. > Fix connector type to reflect this. > > With this change users of this panel do not have to specify the > connector type. > > v3: > - Drop PIXDATA bus_flag, not relevant > > v2: > - Add .bus_format (Laurent) > - Add .bus_flags > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4f0ec5e5b0aa..7b5d212215e0 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1188,6 +1188,9 @@ static const struct panel_desc boe_hv070wsa = { > .width = 154, > .height = 90, > }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH, > + .connector_type = DRM_MODE_CONNECTOR_LVDS, While at it, should you set .bpc to 8 ? Reviewed-by: Laurent Pinchart > }; > > static const struct drm_display_mode boe_nv101wxmn51_modes[] = { -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel