From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9456C433E4 for ; Fri, 10 Jul 2020 22:21:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAF3520674 for ; Fri, 10 Jul 2020 22:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UNCVbzli" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAF3520674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D15F6ED22; Fri, 10 Jul 2020 22:21:36 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF5646ED22 for ; Fri, 10 Jul 2020 22:21:34 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 55ED62C0; Sat, 11 Jul 2020 00:21:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1594419693; bh=VtzgDiTmlkYx1Ir7B5uV/8qUHAQ4fk4xkZRHYjah/gE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UNCVbzlihPJgLPzPTpnEA1sPVnKTWU9J5xkSQmdqPyX0ZebVuwEKu9pSPCPuiFeVg zzPGdpE9A0X+gM5MLQh7kRifciDCS8B8y34bUI+KbhvFR/803IL158jyddCm2bKsat H7Rg3HcKQeSzwTtRxEiBtBk8uisfRTkXZwfk520s= Date: Sat, 11 Jul 2020 01:21:26 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v3 07/21] drm/bridge: tc358767: add detect bridge operation Message-ID: <20200710222126.GK5964@pendragon.ideasonboard.com> References: <20200703192417.372164-1-sam@ravnborg.org> <20200703192417.372164-8-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200703192417.372164-8-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Peter Senna Tschudin , kbuild test robot , Jonas Karlman , Neil Armstrong , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Martyn Welch Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Fri, Jul 03, 2020 at 09:24:03PM +0200, Sam Ravnborg wrote: > Prepare the bridge driver for chained operation by adding > support for the detect operation. > > Signed-off-by: Sam Ravnborg > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > --- > drivers/gpu/drm/bridge/tc358767.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > index 08d483664258..85973ae728db 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -1353,10 +1353,9 @@ static const struct drm_connector_helper_funcs tc_connector_helper_funcs = { > .get_modes = tc_connector_get_modes, > }; > > -static enum drm_connector_status tc_connector_detect(struct drm_connector *connector, > - bool force) > +static enum drm_connector_status tc_bridge_detect(struct drm_bridge *bridge) > { > - struct tc_data *tc = connector_to_tc(connector); > + struct tc_data *tc = bridge_to_tc(bridge); > bool conn; > u32 val; > int ret; > @@ -1380,6 +1379,14 @@ static enum drm_connector_status tc_connector_detect(struct drm_connector *conne > return connector_status_disconnected; > } > > +static enum drm_connector_status > +tc_connector_detect(struct drm_connector *connector, bool force) > +{ > + struct tc_data *tc = connector_to_tc(connector); > + > + return tc_bridge_detect(&tc->bridge); > +} > + > static const struct drm_connector_funcs tc_connector_funcs = { > .detect = tc_connector_detect, > .fill_modes = drm_helper_probe_single_connector_modes, > @@ -1444,6 +1451,7 @@ static const struct drm_bridge_funcs tc_bridge_funcs = { > .enable = tc_bridge_enable, > .disable = tc_bridge_disable, > .mode_fixup = tc_bridge_mode_fixup, > + .detect = tc_bridge_detect, > }; > > static bool tc_readable_reg(struct device *dev, unsigned int reg) > @@ -1677,6 +1685,8 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id) > return ret; > > tc->bridge.funcs = &tc_bridge_funcs; > + tc->bridge.ops = DRM_BRIDGE_OP_DETECT; I think you should set DRM_BRIDGE_OP_DETECT only when tc->hpd_pin is valid. I would also move the if (tc->hpd_pin < 0) case from tc_bridge_detect to +tc_connector_detect. > + > tc->bridge.of_node = dev->of_node; > drm_bridge_add(&tc->bridge); > -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel