From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C04C433E0 for ; Sat, 11 Jul 2020 06:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE44220725 for ; Sat, 11 Jul 2020 06:30:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594449041; bh=acSdpfnvbGb2jx7WzFGXvtApWSJ1zwvQTWvxV4ZbgjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1r1oCQeshu52illcXNy2SkrLSJauasxgx0uaWrspm7YYVBbgX7L85Hf37AYiZt4mX PydNlfkdYbMvoxbiz+rYHvqQ9rM5nNF5L5W4r06jezeQxdke7mUNEqYg05ZvXfhOeM IZ6vjA+S2ET4SiwgtKvQDrAnWdhy4N/j9baDr/ow= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbgGKGaj (ORCPT ); Sat, 11 Jul 2020 02:30:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:33598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgGKGaj (ORCPT ); Sat, 11 Jul 2020 02:30:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47393206F4; Sat, 11 Jul 2020 06:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594449038; bh=acSdpfnvbGb2jx7WzFGXvtApWSJ1zwvQTWvxV4ZbgjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=glLyWxGbTSKecu6XfJKxx2aYmv+Wd9NhB+w34QIKn2RDUm3GV2wOzMmAZWWDheO+6 F2dHJyKL97QejJB6zx6p6asf4EPtQ5JHIi2vkDYXwVfg51R2zuC1PInJsAN4KwfKN9 yyr3UG0dI3UG0C2wLVmYSGWdTbmTnGxjPiUbcMc8= Date: Sat, 11 Jul 2020 08:30:41 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Cristian Ciocaltea , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port Message-ID: <20200711063041.GC2784728@kroah.com> References: <89f6393934fc6d493f8b9e87c1a6e916642b6a18.1590749143.git.cristian.ciocaltea@gmail.com> <20200529113419.GA1631227@kroah.com> <20200710120549.GA11293@BV030612LT> <20200710133542.GA2172832@kroah.com> <20200710155806.GA10457@BV030612LT> <20200710163022.GT3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710163022.GT3703480@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 07:30:22PM +0300, Andy Shevchenko wrote: > On Fri, Jul 10, 2020 at 06:58:06PM +0300, Cristian Ciocaltea wrote: > > On Fri, Jul 10, 2020 at 03:35:42PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Jul 10, 2020 at 03:05:49PM +0300, Cristian Ciocaltea wrote: > > ... > > > > But I think we now have a core fix for this, no need to do this in any > > > individual driver, right? Can you test my tty-linus branch to see if > > > your change is still needed or not? > > > > I was not aware of the alternative approach, at that time Andy > > confirmed the expected behaviour is to have a proper initialization > > of the spinlock in the driver: > > https://lore.kernel.org/lkml/CAHp75Vcz0a87LSnb6Ubt5_bSF3wUcs21GbP119trXER5KBDxbQ@mail.gmail.com/ > > https://lore.kernel.org/lkml/CAHp75Vf8xJ2yX-11JsTDnRvZQOK+16aePcB1AUzq=5oO-mFCGQ@mail.gmail.com/ > > > > I have just checked the tty-linus tree and the only related change > > seems to be f743061a85f5 > > ("serial: core: Initialise spin lock before use in uart_configure_port()") > > > > I tested it on top of 5.8.0-rc4 and I confirm it fixes the splat, > > Thank you for the testing! > > > however I'm a bit confused now regarding the recommended approach since > > there is at least one more commit in the tty-linux tree that still > > handles a similar issue in the driver specific code: > > f38278e9b810 ("serial: sh-sci: Initialize spinlock for uart console") > > They now should be reverted. Please send patches for that :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F81C433E3 for ; Sat, 11 Jul 2020 06:32:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4C1D206F4 for ; Sat, 11 Jul 2020 06:32:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tzdCjFjs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="glLyWxGb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4C1D206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=07rvmPLKmHoxiuwXViTIbTxAh9quoRkO/SIBykLmnbA=; b=tzdCjFjsKQ3QpZmJeG2IUPsPy iAGVAXwZ2OzCdxqJ49SoS+3wEH73mm8ne+wNRj2ojXoNpWqrSSNtKSkixKue8dbGVS3uY5nCyRwn2 fWLN3Y2F6xYxhkHTQkcXyEmt2jDVIclilzVUNp0tSVsT0JKWaLz3O62Li4D3TrNSSAAcPsuiyXpSX bSIScvcZgTAnyBSpVWnr4qpmr4/DIlWKXRHnD4JoGnw0V3F56Dwa/HzqW513M0ULx+KIstTdFJJQv ehs/+PPGaOKaYfcrb5C0zHSK7GJIfCXdcsDTgpFAIOnZW5WMRLU+P8pS3QLR5LwaKO/HOF13pVr5y BN+oBusNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ju925-0008Q2-4e; Sat, 11 Jul 2020 06:30:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ju920-0008PS-TO; Sat, 11 Jul 2020 06:30:41 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47393206F4; Sat, 11 Jul 2020 06:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594449038; bh=acSdpfnvbGb2jx7WzFGXvtApWSJ1zwvQTWvxV4ZbgjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=glLyWxGbTSKecu6XfJKxx2aYmv+Wd9NhB+w34QIKn2RDUm3GV2wOzMmAZWWDheO+6 F2dHJyKL97QejJB6zx6p6asf4EPtQ5JHIi2vkDYXwVfg51R2zuC1PInJsAN4KwfKN9 yyr3UG0dI3UG0C2wLVmYSGWdTbmTnGxjPiUbcMc8= Date: Sat, 11 Jul 2020 08:30:41 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port Message-ID: <20200711063041.GC2784728@kroah.com> References: <89f6393934fc6d493f8b9e87c1a6e916642b6a18.1590749143.git.cristian.ciocaltea@gmail.com> <20200529113419.GA1631227@kroah.com> <20200710120549.GA11293@BV030612LT> <20200710133542.GA2172832@kroah.com> <20200710155806.GA10457@BV030612LT> <20200710163022.GT3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200710163022.GT3703480@smile.fi.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200711_023041_033831_F38B9FA8 X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Manivannan Sadhasivam , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Cristian Ciocaltea , linux-serial@vger.kernel.org, Jiri Slaby , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 07:30:22PM +0300, Andy Shevchenko wrote: > On Fri, Jul 10, 2020 at 06:58:06PM +0300, Cristian Ciocaltea wrote: > > On Fri, Jul 10, 2020 at 03:35:42PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Jul 10, 2020 at 03:05:49PM +0300, Cristian Ciocaltea wrote: > > ... > > > > But I think we now have a core fix for this, no need to do this in any > > > individual driver, right? Can you test my tty-linus branch to see if > > > your change is still needed or not? > > > > I was not aware of the alternative approach, at that time Andy > > confirmed the expected behaviour is to have a proper initialization > > of the spinlock in the driver: > > https://lore.kernel.org/lkml/CAHp75Vcz0a87LSnb6Ubt5_bSF3wUcs21GbP119trXER5KBDxbQ@mail.gmail.com/ > > https://lore.kernel.org/lkml/CAHp75Vf8xJ2yX-11JsTDnRvZQOK+16aePcB1AUzq=5oO-mFCGQ@mail.gmail.com/ > > > > I have just checked the tty-linus tree and the only related change > > seems to be f743061a85f5 > > ("serial: core: Initialise spin lock before use in uart_configure_port()") > > > > I tested it on top of 5.8.0-rc4 and I confirm it fixes the splat, > > Thank you for the testing! > > > however I'm a bit confused now regarding the recommended approach since > > there is at least one more commit in the tty-linux tree that still > > handles a similar issue in the driver specific code: > > f38278e9b810 ("serial: sh-sci: Initialize spinlock for uart console") > > They now should be reverted. Please send patches for that :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel