All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changbin Du <changbin.du@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: [PATCH v5 16/17] perf ftrace: add option -D/--delay to delay tracing
Date: Sat, 11 Jul 2020 20:40:34 +0800	[thread overview]
Message-ID: <20200711124035.6513-17-changbin.du@gmail.com> (raw)
In-Reply-To: <20200711124035.6513-1-changbin.du@gmail.com>

This adds an option '-D/--delay' to allow us to start tracing some
times later after workload is launched.

Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
 tools/perf/Documentation/perf-ftrace.txt |  4 ++++
 tools/perf/builtin-ftrace.c              | 19 ++++++++++++++++---
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
index 97d89478ff5f..62f56058de54 100644
--- a/tools/perf/Documentation/perf-ftrace.txt
+++ b/tools/perf/Documentation/perf-ftrace.txt
@@ -42,6 +42,10 @@ OPTIONS
 --tid=::
 	Trace on existing thread id (comma separated list).
 
+-D::
+--delay::
+	Time (ms) to wait before starting tracing after program start.
+
 -a::
 --all-cpus::
 	Force system-wide collection.  Scripts run without a <command>
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 86fc5d466e97..a70951938308 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -47,6 +47,7 @@ struct perf_ftrace {
 	int			graph_noirqs;
 	int			graph_verbose;
 	int			graph_thresh;
+	unsigned int		initial_delay;
 };
 
 struct filter_entry {
@@ -591,13 +592,23 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 	/* display column headers */
 	read_tracing_file_to_stdout("trace");
 
-	if (write_tracing_file("tracing_on", "1") < 0) {
-		pr_err("can't enable tracing\n");
-		goto out_close_fd;
+	if (!ftrace->initial_delay) {
+		if (write_tracing_file("tracing_on", "1") < 0) {
+			pr_err("can't enable tracing\n");
+			goto out_close_fd;
+		}
 	}
 
 	perf_evlist__start_workload(ftrace->evlist);
 
+	if (ftrace->initial_delay) {
+		usleep(ftrace->initial_delay * 1000);
+		if (write_tracing_file("tracing_on", "1") < 0) {
+			pr_err("can't enable tracing\n");
+			goto out_close_fd;
+		}
+	}
+
 	while (!done) {
 		if (poll(&pollfd, 1, -1) < 0)
 			break;
@@ -808,6 +819,8 @@ int cmd_ftrace(int argc, const char **argv)
 		     "size of per cpu buffer", parse_buffer_size),
 	OPT_BOOLEAN(0, "inherit", &ftrace.inherit,
 		    "trace children processes"),
+	OPT_UINTEGER('D', "delay", &ftrace.initial_delay,
+		     "ms to wait before starting tracing after program start"),
 	OPT_END()
 	};
 
-- 
2.25.1


  parent reply	other threads:[~2020-07-11 12:43 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-11 12:40 [PATCH v5 00/17] perf: ftrace enhancement Changbin Du
2020-07-11 12:40 ` [PATCH v5 01/17] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-07-11 12:40 ` [PATCH v5 02/17] perf ftrace: add option '-F/--funcs' to list available functions Changbin Du
2020-07-13  1:49   ` Namhyung Kim
2020-07-16 15:21     ` Arnaldo Carvalho de Melo
2020-07-17 13:58     ` Changbin Du
2020-07-17 15:05   ` Steven Rostedt
2020-07-17 16:21     ` Arnaldo Carvalho de Melo
2020-07-17 16:27       ` Steven Rostedt
2020-07-17 16:37         ` Arnaldo Carvalho de Melo
2020-07-18  7:06     ` Changbin Du
2020-07-17 17:39   ` Ian Rogers
2020-07-11 12:40 ` [PATCH v5 03/17] perf ftrace: add option -t/--tid to filter by thread id Changbin Du
2020-07-16 15:36   ` Arnaldo Carvalho de Melo
2020-07-17 13:26     ` Changbin Du
2020-07-17 16:44       ` Arnaldo Carvalho de Melo
2020-07-17 17:01       ` Steven Rostedt
2020-07-17 17:40         ` Arnaldo Carvalho de Melo
2020-07-17 17:53           ` Steven Rostedt
2020-07-17 19:34             ` Arnaldo Carvalho de Melo
2020-07-17 19:44               ` Steven Rostedt
2020-07-21 13:44                 ` Namhyung Kim
2020-07-18  5:47         ` Changbin Du
2020-07-11 12:40 ` [PATCH v5 04/17] perf ftrace: factor out function write_tracing_file_int() Changbin Du
2020-07-11 12:40 ` [PATCH v5 05/17] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size Changbin Du
2020-07-11 12:40 ` [PATCH v5 06/17] perf ftrace: show trace column header Changbin Du
2020-07-11 12:40 ` [PATCH v5 07/17] perf ftrace: add option '--inherit' to trace children processes Changbin Du
2020-07-13  1:59   ` Namhyung Kim
2020-07-17 14:27     ` Changbin Du
2020-07-11 12:40 ` [PATCH v5 08/17] perf: util: add general function to parse sublevel options Changbin Du
2020-07-11 12:40 ` [PATCH v5 09/17] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-07-11 12:40 ` [PATCH v5 10/17] perf ftrace: add support for trace option sleep-time Changbin Du
2020-07-11 12:40 ` [PATCH v5 11/17] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-07-11 12:40 ` [PATCH v5 12/17] perf ftrace: add support for tracing option 'irq-info' Changbin Du
2020-07-11 12:40 ` [PATCH v5 13/17] perf ftrace: add option 'verbose' to show more info for graph tracer Changbin Du
2020-07-13  2:07   ` Namhyung Kim
2020-07-17 14:13     ` Changbin Du
2020-07-11 12:40 ` [PATCH v5 14/17] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-07-11 12:40 ` [PATCH v5 15/17] perf: ftrace: allow set graph depth by '--graph-opts' Changbin Du
2020-07-11 12:40 ` Changbin Du [this message]
2020-07-11 12:40 ` [PATCH v5 17/17] perf ftrace: add change log Changbin Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200711124035.6513-17-changbin.du@gmail.com \
    --to=changbin.du@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.