From: kernel test robot drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3012:13-20: Unneeded variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 3022 drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3068:13-24: Unneeded variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3091 drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3036:13-24: Unneeded variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3049 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder") Signed-off-by: kernel test robot --- tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc head: ca0d6f7786586ca7ba424d5967d780dd3c75748b commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder Please take the patch only if it's a positive warning. Thanks! p2p_fsm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) --- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c +++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c @@ -3009,8 +3009,6 @@ WLAN_STATUS p2pRunEventAAAComplete(IN P_ /*----------------------------------------------------------------------------*/ WLAN_STATUS p2pRunEventAAASuccess(IN P_ADAPTER_T prAdapter, IN P_STA_RECORD_T prStaRec) { - WLAN_STATUS rStatus = WLAN_STATUS_SUCCESS; - do { ASSERT_BREAK((prAdapter != NULL) && (prStaRec != NULL)); @@ -3019,7 +3017,7 @@ WLAN_STATUS p2pRunEventAAASuccess(IN P_A } while (FALSE); - return rStatus; + return WLAN_STATUS_SUCCESS; } /* p2pRunEventAAASuccess */ /*----------------------------------------------------------------------------*/ @@ -3033,7 +3031,6 @@ WLAN_STATUS p2pRunEventAAASuccess(IN P_A /*----------------------------------------------------------------------------*/ WLAN_STATUS p2pRxPublicActionFrame(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T prSwRfb) { - WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS; P_P2P_PUBLIC_ACTION_FRAME_T prPublicActionFrame = (P_P2P_PUBLIC_ACTION_FRAME_T) NULL; P_P2P_FSM_INFO_T prP2pFsmInfo = (P_P2P_FSM_INFO_T) NULL; @@ -3046,7 +3043,7 @@ WLAN_STATUS p2pRxPublicActionFrame(IN P_ DBGLOG(P2P, TRACE, "RX Public Action Frame Token:%d.\n", prPublicActionFrame->ucDialogToken); if (prPublicActionFrame->ucCategory != CATEGORY_PUBLIC_ACTION) - return rWlanStatus; + return WLAN_STATUS_SUCCESS; switch (prPublicActionFrame->ucAction) { case ACTION_PUBLIC_WIFI_DIRECT: @@ -3060,12 +3057,11 @@ WLAN_STATUS p2pRxPublicActionFrame(IN P_ break; } - return rWlanStatus; + return WLAN_STATUS_SUCCESS; } /* p2pRxPublicActionFrame */ WLAN_STATUS p2pRxActionFrame(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T prSwRfb) { - WLAN_STATUS rWlanStatus = WLAN_STATUS_SUCCESS; P_P2P_ACTION_FRAME_T prP2pActionFrame = (P_P2P_ACTION_FRAME_T) NULL; UINT_8 aucOui[3] = VENDOR_OUI_WFA_SPECIFIC; @@ -3088,7 +3084,7 @@ WLAN_STATUS p2pRxActionFrame(IN P_ADAPTE } while (FALSE); - return rWlanStatus; + return WLAN_STATUS_SUCCESS; } /* p2pRxActionFrame */ VOID