From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572C5C433DF for ; Mon, 13 Jul 2020 01:20:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 252CC2065F for ; Mon, 13 Jul 2020 01:20:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FVQDfHSh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+7QlzHg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 252CC2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2QFAlrajsqOVSJEKKwiCHulIQ6qC2JvY/YqXSJ8TLho=; b=FVQDfHShJqy20eo8GdJwjyen4 veZB0CQvgLN1nWmDIQfaOtXGsqZlZMKoLsw+uTzS/RhLmmpRi+eWSCRbR+6P87Qiki0TJfPUTVpTf 2qCKSnGGZ6xhM1GQZWrJZRB6I8a/+s6HAQU+mPo0sKEBuDaDo5wzyybQz8bSnQlL6oV7rKbGQ7PUp NpBGJK+L27tEcgpRfp7ZLek0cCS3NNjjvYIWWvdrI6s4h/k5XC7hd5LNyvlI5e285+couSngK4Q99 wm6pkAQkdkIr1G5m7KsrP3NulpVkhL3PIxbreuJbiW8v8glIRbV7Q/gEWGV2yUai2rTXwO+stXzGd geXzEzZSg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jun86-0006XZ-Mm; Mon, 13 Jul 2020 01:19:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jun84-0006Wx-Gj for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 01:19:37 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B59A2067D; Mon, 13 Jul 2020 01:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594603175; bh=kk+FtMoyFiwJDF5FGB+nHna0jnm9qiSxINdPwHTYtb4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+7QlzHgE1/GgkAF2kzY9yJipSIAwtQWtk6Ryt6nWY9nBhfh6FjrwVYwTawpG/GdC 1tLxZUatKSWWtzPxnYobONx3nHNN+2jPxc/C5ZGaMNsUfS87PShoBaB5CVI+Z2RfuT yDzLTe4xt+5/hYM/iB1lKkZ3pRyYSAUttl8spttw= Date: Mon, 13 Jul 2020 09:19:30 +0800 From: Shawn Guo To: Soeren Moch Subject: Re: [PATCH v2 1/2] ARM: dts: imx6q-tbs2910: Pass phy-reset-duration Message-ID: <20200713011929.GR21277@dragon> References: <20200625111846.9507-1-festevam@gmail.com> <8a75a153-4337-0890-3828-06ee6f1275a5@web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a75a153-4337-0890-3828-06ee6f1275a5@web.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200712_211936_619606_1B0D0DB8 X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 25, 2020 at 06:29:22PM +0200, Soeren Moch wrote: > Hi Fabio, > > On 25.06.20 13:18, Fabio Estevam wrote: > > According to the AR8035 datasheet: > > > > "When using crystal, the clock is generated internally after power is > > stable. For a reliable power on reset, suggest to keep asserting the reset > > low long enough (10ms) to ensure the clock is stable and clock-to-reset 1ms > > requirement is satisfied." > > > > Pass the 'phy-reset-duration' property to meet such requirement. > > > > Signed-off-by: Fabio Estevam > "phy-reset-duration" is listed as deprecated in > Documentation/devicetree/bindings/net/fsl-fec.txt . Good point. There must be some new way we should do this properly. Shawn > So maybe it is not the best option, but it should work. > > Reviewed-by: Soeren Moch > > Thanks, > Soeren > > --- > > Changes since v1: > > - None. > > > > arch/arm/boot/dts/imx6q-tbs2910.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts > > index bfff87ce2e1f..7b03b2787430 100644 > > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts > > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts > > @@ -100,6 +100,7 @@ > > pinctrl-0 = <&pinctrl_enet>; > > phy-mode = "rgmii-id"; > > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > > + phy-reset-duration = <10>; > > status = "okay"; > > }; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel