From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7F4C433E3 for ; Mon, 13 Jul 2020 06:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7559E2075D for ; Mon, 13 Jul 2020 06:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594622938; bh=WWEEuVhlr2nW3XjCI9KWOEj+kLW17f+JdDGC2Rl8byI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=on8LM1AHk1rzXmjQ7S66vwPvjZCIMEDrxposqh2+6YTvFGmDsh24TlBEyQJZRT+J3 X5Q8TTORVsQTfRBbaWZIdv0Hx/akY/G9MQcWXKKY1tMR7KHptH8uwtuW0884qOe0eM v5/+xUh69RU9hbNS2c4hfIKvyiW0bSmltk4NRhmo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729260AbgGMGs5 (ORCPT ); Mon, 13 Jul 2020 02:48:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:35408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbgGMGs4 (ORCPT ); Mon, 13 Jul 2020 02:48:56 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE58F20720; Mon, 13 Jul 2020 06:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594622936; bh=WWEEuVhlr2nW3XjCI9KWOEj+kLW17f+JdDGC2Rl8byI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Btl/Tp+izk7mtTssyKlrQDvxZIBkan5DgFkSatsaRXKuQGxSbrbsqfIqtCgfNW20F zZjx3bwL8cB7VNTxMWuQgKnbEkJo7lU/ch2HJji90PU1nDYSnRMc8YT6OUSaLtNzAu kBG1U39LzQonJRP9b1CqWA4eDPNUINYz3SdyaFPM= Date: Mon, 13 Jul 2020 14:48:52 +0800 From: Shawn Guo To: Richard Zhu Cc: linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx6qdl: only enable pcie in the pcie dts file Message-ID: <20200713064851.GH12113@dragon> References: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 04:44:41PM +0800, Richard Zhu wrote: > Since iMX6Q/DL PCIe has the PM limitation (ERR005723 "PCIe PCIe does > not support L2 Power Down"). > System suspend/resume would be broken by PCIe, if PCIe is enabled. > Only enable PCIe in the xxx-pcie.dts files to avoid the brokens when > other xxx.dtb files are used on sabresd and sabreauto boards. > > Signed-off-by: Richard Zhu > --- > arch/arm/boot/dts/Makefile | 4 ++++ > arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6dl-sabresd-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6q-sabreauto-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6q-sabresd-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 ---- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 - > 7 files changed, 52 insertions(+), 5 deletions(-) > create mode 100644 arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts > create mode 100644 arch/arm/boot/dts/imx6dl-sabresd-pcie.dts > create mode 100644 arch/arm/boot/dts/imx6q-sabreauto-pcie.dts > create mode 100644 arch/arm/boot/dts/imx6q-sabresd-pcie.dts No. There are hundreds of boards based on i.MX6Q/DL. We are not going to maintain a -pcie.dts for every single one of them. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CACC433F1 for ; Mon, 13 Jul 2020 06:50:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57F3920663 for ; Mon, 13 Jul 2020 06:50:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gb5dYAzQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Btl/Tp+i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57F3920663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5yl6UL2EjKLCe1Rksec3RPbbgAwkUhB9guec/wHr5k0=; b=gb5dYAzQf4FeMd6Ywr0oa2rVQ RfTY8qDGU3VMJ9rMuJtJft60TLgT0G+CbhlJfBGVt3hTWI8fr3EFH/KMlmH/gCkNJ/XmrPNtAbRER TN6eAcs9sPFlH9VjL4TFOQDnJkrYrkJmvGUD802N/kxCQ/y7E7E4GgfgLoA9oICxgzEHTDdB5VZiD hMBgvKXG2wHKLA4wbYcE6DUgseLeGWMABE1Xh8hxMIgD2jSq0ViGpjNXCW6b1we9Tg9P/1Pd5mGu9 V0eCJFSnRRFb4bRU/3ZQDiW/cdzOE1gdjl0FQJh4iKW6vZWS2bhb+pzBRDrRtR/MroWJ9uClRvR7V lvDjBzklw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jusGq-0007IW-4Q; Mon, 13 Jul 2020 06:49:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jusGn-0007Hs-PT for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 06:48:58 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE58F20720; Mon, 13 Jul 2020 06:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594622936; bh=WWEEuVhlr2nW3XjCI9KWOEj+kLW17f+JdDGC2Rl8byI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Btl/Tp+izk7mtTssyKlrQDvxZIBkan5DgFkSatsaRXKuQGxSbrbsqfIqtCgfNW20F zZjx3bwL8cB7VNTxMWuQgKnbEkJo7lU/ch2HJji90PU1nDYSnRMc8YT6OUSaLtNzAu kBG1U39LzQonJRP9b1CqWA4eDPNUINYz3SdyaFPM= Date: Mon, 13 Jul 2020 14:48:52 +0800 From: Shawn Guo To: Richard Zhu Subject: Re: [PATCH] ARM: dts: imx6qdl: only enable pcie in the pcie dts file Message-ID: <20200713064851.GH12113@dragon> References: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_024857_888537_DD88E37A X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 06, 2020 at 04:44:41PM +0800, Richard Zhu wrote: > Since iMX6Q/DL PCIe has the PM limitation (ERR005723 "PCIe PCIe does > not support L2 Power Down"). > System suspend/resume would be broken by PCIe, if PCIe is enabled. > Only enable PCIe in the xxx-pcie.dts files to avoid the brokens when > other xxx.dtb files are used on sabresd and sabreauto boards. > > Signed-off-by: Richard Zhu > --- > arch/arm/boot/dts/Makefile | 4 ++++ > arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6dl-sabresd-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6q-sabreauto-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6q-sabresd-pcie.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 ---- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 - > 7 files changed, 52 insertions(+), 5 deletions(-) > create mode 100644 arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts > create mode 100644 arch/arm/boot/dts/imx6dl-sabresd-pcie.dts > create mode 100644 arch/arm/boot/dts/imx6q-sabreauto-pcie.dts > create mode 100644 arch/arm/boot/dts/imx6q-sabresd-pcie.dts No. There are hundreds of boards based on i.MX6Q/DL. We are not going to maintain a -pcie.dts for every single one of them. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel