From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Gerd Rausch <gerd.rausch@oracle.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Sasha Levin <alexander.levin@microsoft.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 2.6.26-4.14] IB/ipoib: Arm "send_cq" to process completions in due time
Date: Mon, 13 Jul 2020 16:53:44 +0200 [thread overview]
Message-ID: <20200713145344.GB3767483@kroah.com> (raw)
In-Reply-To: <20200617050341.GG2383158@unreal>
On Wed, Jun 17, 2020 at 08:03:41AM +0300, Leon Romanovsky wrote:
> On Tue, Jun 16, 2020 at 09:35:38AM -0700, Gerd Rausch wrote:
> > Hi,
> >
> > On 16/06/2020 05.08, Greg Kroah-Hartman wrote:
> > >> I considered backporting commit 8966e28d2e40c ("IB/ipoib: Use NAPI in UD/TX flows")
> > >> with all the dependencies it may have a considerably higher risk
> > >> than just arming the TX CQ.
> > >
> > > 90% of the time when we apply a patch that does NOT match the upstream
> > > tree, it has a bug in it and needs to have another fix or something
> > > else.
> > >
> > > So please, if at all possible, stick to the upstream tree, so
> > > backporting the current patches are the best thing to do.
> > >
> >
> > Jason,
> >
> > With Mellanox writing and fixing the vast majority of the code found
> > in IB/IPoIB, do you or one of your colleagues want to look into this?
> >
> > It would be considerably less error-prone if the authors of that code
> > did that more risky work of backporting.
> >
> > AFAIK, Mellanox also has the regression tests to ensure that everything
> > still works after this re-write as it did before.
>
> Please approach your Mellanox FAE representatives, they will know how to
> handle it internally.
Ah, so you all don't care about any IB fixes for 4.14 and older kernels
anymore? If so, great, please let us know so we will not do any
backporting anymore, that will save us time!
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-13 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 19:41 [PATCH 2.6.26-4.14] IB/ipoib: Arm "send_cq" to process completions in due time Gerd Rausch
2020-06-12 19:55 ` Jason Gunthorpe
2020-06-12 20:44 ` Gerd Rausch
2020-06-16 12:08 ` Greg Kroah-Hartman
2020-06-16 16:35 ` Gerd Rausch
2020-06-17 5:03 ` Leon Romanovsky
2020-07-13 14:53 ` Greg Kroah-Hartman [this message]
2020-07-14 7:02 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713145344.GB3767483@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.levin@microsoft.com \
--cc=dledford@redhat.com \
--cc=gerd.rausch@oracle.com \
--cc=hal.rosenstock@gmail.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.