All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: fam@euphon.net, berrange@redhat.com, robert.foley@linaro.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	richard.henderson@linaro.org, qemu-devel@nongnu.org,
	robhenry@microsoft.com, f4bug@amsat.org,
	aaron@os.amperecomputing.com, cota@braap.org,
	kuhn.chenqun@huawei.com, peter.puhov@linaro.org,
	aurelien@aurel32.net
Subject: Re: [PATCH v2 09/11] hw/virtio/pci: include vdev name in registered PCI sections
Date: Tue, 14 Jul 2020 05:07:26 -0400	[thread overview]
Message-ID: <20200714050630-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200713200415.26214-10-alex.bennee@linaro.org>

On Mon, Jul 13, 2020 at 09:04:13PM +0100, Alex Bennée wrote:
> When viewing/debugging memory regions it is sometimes hard to figure
> out which PCI device something belongs to. Make the names unique by
> including the vdev name in the name string.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

I wonder here: why don't we see the owner name when debugging? Maybe that's a better
way to address that.

> ---
> v2
>   - swap ()'s for an extra -
> ---
>  hw/virtio/virtio-pci.c | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 8554cf2a03..215e680c71 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1406,7 +1406,8 @@ static void virtio_pci_device_write(void *opaque, hwaddr addr,
>      }
>  }
>  
> -static void virtio_pci_modern_regions_init(VirtIOPCIProxy *proxy)
> +static void virtio_pci_modern_regions_init(VirtIOPCIProxy *proxy,
> +                                           const char *vdev_name)
>  {
>      static const MemoryRegionOps common_ops = {
>          .read = virtio_pci_common_read,
> @@ -1453,36 +1454,41 @@ static void virtio_pci_modern_regions_init(VirtIOPCIProxy *proxy)
>          },
>          .endianness = DEVICE_LITTLE_ENDIAN,
>      };
> +    g_autoptr(GString) name = g_string_new(NULL);
>  
> -
> +    g_string_printf(name, "virtio-pci-common-%s", vdev_name);
>      memory_region_init_io(&proxy->common.mr, OBJECT(proxy),
>                            &common_ops,
>                            proxy,
> -                          "virtio-pci-common",
> +                          name->str,
>                            proxy->common.size);
>  
> +    g_string_printf(name, "virtio-pci-isr-%s", vdev_name);
>      memory_region_init_io(&proxy->isr.mr, OBJECT(proxy),
>                            &isr_ops,
>                            proxy,
> -                          "virtio-pci-isr",
> +                          name->str,
>                            proxy->isr.size);
>  
> +    g_string_printf(name, "virtio-pci-device-%s", vdev_name);
>      memory_region_init_io(&proxy->device.mr, OBJECT(proxy),
>                            &device_ops,
>                            virtio_bus_get_device(&proxy->bus),
> -                          "virtio-pci-device",
> +                          name->str,
>                            proxy->device.size);
>  
> +    g_string_printf(name, "virtio-pci-notify-%s", vdev_name);
>      memory_region_init_io(&proxy->notify.mr, OBJECT(proxy),
>                            &notify_ops,
>                            virtio_bus_get_device(&proxy->bus),
> -                          "virtio-pci-notify",
> +                          name->str,
>                            proxy->notify.size);
>  
> +    g_string_printf(name, "virtio-pci-notify-pio-%s", vdev_name);
>      memory_region_init_io(&proxy->notify_pio.mr, OBJECT(proxy),
>                            &notify_pio_ops,
>                            virtio_bus_get_device(&proxy->bus),
> -                          "virtio-pci-notify-pio",
> +                          name->str,
>                            proxy->notify_pio.size);
>  }
>  
> @@ -1623,7 +1629,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)
>  
>          struct virtio_pci_cfg_cap *cfg_mask;
>  
> -        virtio_pci_modern_regions_init(proxy);
> +        virtio_pci_modern_regions_init(proxy, vdev->name);
>  
>          virtio_pci_modern_mem_region_map(proxy, &proxy->common, &cap);
>          virtio_pci_modern_mem_region_map(proxy, &proxy->isr, &cap);
> -- 
> 2.20.1



  reply	other threads:[~2020-07-14  9:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 20:04 [PATCH v2 00/11] misc fixes for rc0 (docker, plugins, softfloat) Alex Bennée
2020-07-13 20:04 ` [PATCH v2 01/11] configure: remove all dependencies on a (re)configure Alex Bennée
2020-07-13 20:15   ` Philippe Mathieu-Daudé
2020-07-13 20:04 ` [PATCH v2 02/11] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image Alex Bennée
2020-07-13 20:04 ` [PATCH v2 03/11] docker.py: fix fetching of FROM layers Alex Bennée
2020-07-13 20:04 ` [PATCH v2 04/11] fpu/softfloat: fix up float16 nan recognition Alex Bennée
2020-07-13 20:04 ` [PATCH v2 05/11] tests/plugins: don't unconditionally add -Wpsabi Alex Bennée
2020-07-14  5:31   ` Thomas Huth
2020-07-13 20:04 ` [PATCH v2 06/11] cputlb: ensure we save the IOTLB data in case of reset Alex Bennée
2020-07-13 21:58   ` Richard Henderson
2020-07-18 20:51   ` Emilio G. Cota
2020-07-13 20:04 ` [PATCH v2 07/11] plugins: expand the bb plugin to be thread safe and track per-cpu Alex Bennée
2020-07-13 20:04 ` [PATCH v2 08/11] docs/devel: fix grammar in multi-thread-tcg Alex Bennée
2020-07-13 22:01   ` Richard Henderson
2020-07-14  5:41   ` Thomas Huth
2020-07-14 10:20   ` Philippe Mathieu-Daudé
2020-07-13 20:04 ` [PATCH v2 09/11] hw/virtio/pci: include vdev name in registered PCI sections Alex Bennée
2020-07-14  9:07   ` Michael S. Tsirkin [this message]
2020-07-14  9:49     ` Philippe Mathieu-Daudé
2020-07-13 20:04 ` [PATCH v2 10/11] plugins: add API to return a name for a IO device Alex Bennée
2020-07-13 22:04   ` Richard Henderson
2020-07-13 20:04 ` [PATCH v2 11/11] plugins: new hwprofile plugin Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714050630-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=aaron@os.amperecomputing.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=kuhn.chenqun@huawei.com \
    --cc=peter.puhov@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=robert.foley@linaro.org \
    --cc=robhenry@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.