All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Garrit Franke <garritfranke@gmail.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: remove unused kobject action
Date: Tue, 14 Jul 2020 08:35:17 +0200	[thread overview]
Message-ID: <20200714063517.GB662760@kroah.com> (raw)
In-Reply-To: <20200713191509.342466-1-garritfranke@gmail.com>

On Mon, Jul 13, 2020 at 09:15:10PM +0200, Garrit Franke wrote:
> I noticed that the KOBJ_MAX action is never used. Does it serve any
> purpose, or can it be removed?

Don't ask questions in a changelog comment that you don't also answer :)

> As far as I know, Kobjects shouldn't be
> used for drivers and more higher level abstraction layers, so I figured
> it isn't used by user-provided code either.

Userspace sees these uevents, right?

> 
> Regards
> Garrit Franke

This isn't needed in a changelog text.

Try running and testing this a bit more before sending it for inclusion
please.

> 
> Signed-off-by: Garrit Franke <garritfranke@gmail.com>
> ---
>  include/linux/kobject.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> index 6cba088bee24..fd99c5d2d8b7 100644
> --- a/include/linux/kobject.h
> +++ b/include/linux/kobject.h
> @@ -58,8 +58,7 @@ enum kobject_action {
>  	KOBJ_ONLINE,
>  	KOBJ_OFFLINE,
>  	KOBJ_BIND,
> -	KOBJ_UNBIND,
> -	KOBJ_MAX
> +	KOBJ_UNBIND

No need to drop that trailing ','

thanks,

greg k-h

  reply	other threads:[~2020-07-14  6:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 19:15 [PATCH] kobject: remove unused kobject action Garrit Franke
2020-07-14  6:35 ` Greg KH [this message]
2020-07-15 15:11   ` [PATCH v2] kobject: remove unused KOBJ_MAX action Garrit Franke
2020-07-15 15:32     ` Greg KH
2020-07-16 20:31       ` [PATCH v3] " Garrit Franke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714063517.GB662760@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=garritfranke@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.