From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DF0C433E0 for ; Tue, 14 Jul 2020 07:38:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 459D12084D for ; Tue, 14 Jul 2020 07:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594712335; bh=D9X12rzUdjdFj13IA0SQy7lT+r0nIG2ebG23ZycYooo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZitfTcpALRQLDBM0A08Dwxw5vDBK4KyAL2q4qOxbRu0RDrk97HqApR4xhSTE19aWM ySzy3E0ppd66MrsdcsqM5sNF/lODZoCBycnk8MneztNjic21btKtsrMGuaTTOnus27 5MPvNLzPvitlptWxBw3Ks/NSyzuWt6U7ng2iOR5E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbgGNHiy (ORCPT ); Tue, 14 Jul 2020 03:38:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:38364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgGNHix (ORCPT ); Tue, 14 Jul 2020 03:38:53 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06F482084C; Tue, 14 Jul 2020 07:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594712333; bh=D9X12rzUdjdFj13IA0SQy7lT+r0nIG2ebG23ZycYooo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AjbVNXfqwfJCMrv83a4TBW2KQlgSPYZoRCZ2dyPGQ1L0rB7E0Ao5fqRdVamRJCVaQ XW+aGrhAPXs0BGRK58cXBAhBQvMQs8dcotHaCXyDWKOoN7mgnc1S/yVL8puPbnyTe0 lg6Q2vZI1zLrG9u+Oyyj9aRQpRso4NfJVV1eFU80= Received: by pali.im (Postfix) id 340C8842; Tue, 14 Jul 2020 09:38:50 +0200 (CEST) Date: Tue, 14 Jul 2020 09:38:50 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Thomas Petazzoni , Andrew Murray , Bjorn Helgaas , Marek =?utf-8?B?QmVow7pu?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200714073850.rvuknigpj3jt7kp4@pali> References: <20200702083036.12230-1-pali@kernel.org> <20200709113509.GB19638@e121166-lin.cambridge.arm.com> <20200709122208.rmfeuu6zgbwh3fr5@pali> <20200709144701.GA21760@e121166-lin.cambridge.arm.com> <20200709150959.wq6zfkcy4m6hvvpl@pali> <20200710091800.GA3419@e121166-lin.cambridge.arm.com> <20200713082747.e3q3ml3wpbszn4j7@pali> <20200713112325.GA25865@e121166-lin.cambridge.arm.com> <20200713145003.foarsdixquicvivy@pali> <20200713164140.GA29307@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200713164140.GA29307@e121166-lin.cambridge.arm.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 13 July 2020 17:41:40 Lorenzo Pieralisi wrote: > On Mon, Jul 13, 2020 at 04:50:03PM +0200, Pali Rohár wrote: > > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > > I will go over the thread again but I suspect I can merge the patch even > > > though I still believe there is work to be done to understand the issue > > > we are facing. > > > > Just to note that pci-mvebu.c also checks if pcie link is up before > > trying to access the real PCIe interface registers, similarly as in my > > patch. > > I understand - that does not change my opinion though, the link check > is just a workaround, it'd be best if we pinpoint the real issue which > is likely to a HW one. Lorenzo, if you have an idea how to debug this issue or if you would like to see some test results, let me know. I can do some tests, but I currently really do not know more then what I wrote in previous emails. In my opinion, problem is in HW which Marvell has not documented nor proved that it exists. Other option is that problem is in Compex card which can be triggered only by Marvell aardvark HW. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FDC4C433E0 for ; Tue, 14 Jul 2020 07:40:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69F022082F for ; Tue, 14 Jul 2020 07:40:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ewyfiihJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AjbVNXfq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69F022082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2mJ0G5qyjX4eqqsCkPSRAfOs4/u0ifztWn5v5e+X2kk=; b=ewyfiihJBR6x1CoAZFa8YekmH fCoTekoEvcRAgwzdVEJVN1OvZRyUm6n34GU0szrAt/KJxSj0f6O4UGv7KlT5xJ7AbGGQCZ0aASroE EZRNuJuIsyh34n3uQtbi3OuSgHNuNW1y+T+Ej1mlL0uysBJ6o0kVH/FGIHiK7lfQaRdt+YkcY7oK0 SYgDi+WXOmPcOkTfbcT+GpH2Unwq63DoR7NrIrStBoHeQg179b+sjszu2sjl6dkJ9+LeRdMrKcgTz TGSyo4BTQJfkjinTzGOF2w7pAV7Trq8IrjKwcG6zWMCqBwxpNfzoc2LMn4oFzZQep0xjx0vvWn23V st94BAvNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvFWj-00072G-Kb; Tue, 14 Jul 2020 07:38:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvFWg-00071Y-JW for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 07:38:55 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06F482084C; Tue, 14 Jul 2020 07:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594712333; bh=D9X12rzUdjdFj13IA0SQy7lT+r0nIG2ebG23ZycYooo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AjbVNXfqwfJCMrv83a4TBW2KQlgSPYZoRCZ2dyPGQ1L0rB7E0Ao5fqRdVamRJCVaQ XW+aGrhAPXs0BGRK58cXBAhBQvMQs8dcotHaCXyDWKOoN7mgnc1S/yVL8puPbnyTe0 lg6Q2vZI1zLrG9u+Oyyj9aRQpRso4NfJVV1eFU80= Received: by pali.im (Postfix) id 340C8842; Tue, 14 Jul 2020 09:38:50 +0200 (CEST) Date: Tue, 14 Jul 2020 09:38:50 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Subject: Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200714073850.rvuknigpj3jt7kp4@pali> References: <20200702083036.12230-1-pali@kernel.org> <20200709113509.GB19638@e121166-lin.cambridge.arm.com> <20200709122208.rmfeuu6zgbwh3fr5@pali> <20200709144701.GA21760@e121166-lin.cambridge.arm.com> <20200709150959.wq6zfkcy4m6hvvpl@pali> <20200710091800.GA3419@e121166-lin.cambridge.arm.com> <20200713082747.e3q3ml3wpbszn4j7@pali> <20200713112325.GA25865@e121166-lin.cambridge.arm.com> <20200713145003.foarsdixquicvivy@pali> <20200713164140.GA29307@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200713164140.GA29307@e121166-lin.cambridge.arm.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_033854_738351_D75CC3E9 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , linux-pci@vger.kernel.org, Xogium , linux-kernel@vger.kernel.org, Marek =?utf-8?B?QmVow7pu?= , Remi Pommarel , Thomas Petazzoni , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andrew Murray Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uZGF5IDEzIEp1bHkgMjAyMCAxNzo0MTo0MCBMb3JlbnpvIFBpZXJhbGlzaSB3cm90ZToK PiBPbiBNb24sIEp1bCAxMywgMjAyMCBhdCAwNDo1MDowM1BNICswMjAwLCBQYWxpIFJvaMOhciB3 cm90ZToKPiA+IE9uIE1vbmRheSAxMyBKdWx5IDIwMjAgMTI6MjM6MjUgTG9yZW56byBQaWVyYWxp c2kgd3JvdGU6Cj4gPiA+IEkgd2lsbCBnbyBvdmVyIHRoZSB0aHJlYWQgYWdhaW4gYnV0IEkgc3Vz cGVjdCBJIGNhbiBtZXJnZSB0aGUgcGF0Y2ggZXZlbgo+ID4gPiB0aG91Z2ggSSBzdGlsbCBiZWxp ZXZlIHRoZXJlIGlzIHdvcmsgdG8gYmUgZG9uZSB0byB1bmRlcnN0YW5kIHRoZSBpc3N1ZQo+ID4g PiB3ZSBhcmUgZmFjaW5nLgo+ID4gCj4gPiBKdXN0IHRvIG5vdGUgdGhhdCBwY2ktbXZlYnUuYyBh bHNvIGNoZWNrcyBpZiBwY2llIGxpbmsgaXMgdXAgYmVmb3JlCj4gPiB0cnlpbmcgdG8gYWNjZXNz IHRoZSByZWFsIFBDSWUgaW50ZXJmYWNlIHJlZ2lzdGVycywgc2ltaWxhcmx5IGFzIGluIG15Cj4g PiBwYXRjaC4KPiAKPiBJIHVuZGVyc3RhbmQgLSB0aGF0IGRvZXMgbm90IGNoYW5nZSBteSBvcGlu aW9uIHRob3VnaCwgdGhlIGxpbmsgY2hlY2sKPiBpcyBqdXN0IGEgd29ya2Fyb3VuZCwgaXQnZCBi ZSBiZXN0IGlmIHdlIHBpbnBvaW50IHRoZSByZWFsIGlzc3VlIHdoaWNoCj4gaXMgbGlrZWx5IHRv IGEgSFcgb25lLgoKTG9yZW56bywgaWYgeW91IGhhdmUgYW4gaWRlYSBob3cgdG8gZGVidWcgdGhp cyBpc3N1ZSBvciBpZiB5b3Ugd291bGQKbGlrZSB0byBzZWUgc29tZSB0ZXN0IHJlc3VsdHMsIGxl dCBtZSBrbm93LiBJIGNhbiBkbyBzb21lIHRlc3RzLCBidXQgSQpjdXJyZW50bHkgcmVhbGx5IGRv IG5vdCBrbm93IG1vcmUgdGhlbiB3aGF0IEkgd3JvdGUgaW4gcHJldmlvdXMgZW1haWxzLgoKSW4g bXkgb3BpbmlvbiwgcHJvYmxlbSBpcyBpbiBIVyB3aGljaCBNYXJ2ZWxsIGhhcyBub3QgZG9jdW1l bnRlZCBub3IKcHJvdmVkIHRoYXQgaXQgZXhpc3RzLiBPdGhlciBvcHRpb24gaXMgdGhhdCBwcm9i bGVtIGlzIGluIENvbXBleCBjYXJkCndoaWNoIGNhbiBiZSB0cmlnZ2VyZWQgb25seSBieSBNYXJ2 ZWxsIGFhcmR2YXJrIEhXLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=