From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0712BC433E8 for ; Tue, 14 Jul 2020 09:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D46E6217A0 for ; Tue, 14 Jul 2020 09:57:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KnoAcjX4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbgGNJ52 (ORCPT ); Tue, 14 Jul 2020 05:57:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbgGNJ51 (ORCPT ); Tue, 14 Jul 2020 05:57:27 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FB20C061755; Tue, 14 Jul 2020 02:57:27 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id q15so4170788wmj.2; Tue, 14 Jul 2020 02:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=KnoAcjX4xbVjcEeEVJH8HgscVFZmdZqaHYPU5EtBNSakspRZVOZRaF/dmW850mwgBb EIEhQt2487O5Ch8XMPP3/ZU0Tssjmmc7st+F7gnirRjowDijU/yBcwEg3SOb9H1XsW6O ZHx7iwIiziKTbK9+5KHYm9bGfe6nUHtsA16tHYKBk0E3M0omDqd8kn8O5ydg6O3+BZtA PutrPQjiZTbEN81UwfdkSWanowJeW2hnqp7xV47pvtph9xIjnMWVQWpGmaH8ubZFQrdd I/n+BAZE77F8uVwo3QQ03YNLe+6OGonbu4pK0o7ZgyMLHkHiHLHLknU5JFB2PiFJ+gQS W0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=oPeWk+0OAMMkLCpvUUOwK/Z3qWXqdrfDO1I9uNJx5vA/Zz79MfRRzWniCsl9jF8a4s pxlAZCUOnSjzrObQ88+Y6OFnNc7bQUwlGNxWuFeGLyLDm0dp38F4AfXXq9ZsM1R5hXqO Tbdj5b2orrHkXB6eBT+zprTgwgEq9jHXbpA8R7OAa/ByWQy37Zr1ZPH8HDv2lwrOsH/w /pXnW/WdNquJQ9r5SrwkY35WrlFAFUdjcrk7LbEr+VE67rUhmFqCsNryrEIT1KK5Qv6f o7lmx2ZcYOASnmj8uFU3WY9MeYK2gN0ATsK7H+8KV34e2G96z97neRFtevG+YCNDVrd6 l/vQ== X-Gm-Message-State: AOAM531knnD8u/+e0mpoTqhMTW4GdDQUGc2GuXbtB5JCgSmFmbaJXzzU wWHm2zVZJYMeFv9Gzk8qaLc= X-Google-Smtp-Source: ABdhPJy//OrDpSJANwxwERqV3gHdFYgIJtILxA4cb/jXIXye2R9kTiX9uf+7YtLVsgsXyKpQFfoArw== X-Received: by 2002:a1c:4444:: with SMTP id r65mr3301652wma.129.1594720644598; Tue, 14 Jul 2020 02:57:24 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id r28sm27797330wrr.20.2020.07.14.02.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 02:57:23 -0700 (PDT) Date: Tue, 14 Jul 2020 06:57:17 -0300 From: Melissa Wen To: Rodrigo Siqueira Cc: Daniel Vetter , DRI Development , Intel Graphics Development , linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, Chris Wilson , Maarten Lankhorst , Christian =?utf-8?B?S8O2bmln?= , Daniel Vetter , Haneen Mohammed , Daniel Vetter , Trevor Woerner Subject: Re: [PATCH 04/25] drm/vkms: Annotate vblank timer Message-ID: <20200714095717.njwk2u4tkgro54jn@smtp.gmail.com> References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-5-daniel.vetter@ffwll.ch> <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 07/12, Rodrigo Siqueira wrote: > Hi, > > Everything looks fine to me, I just noticed that the amdgpu patches did > not apply smoothly, however it was trivial to fix the issues. > > Reviewed-by: Rodrigo Siqueira > > Melissa, > Since you are using vkms regularly, could you test this patch and review > it? Remember to add your Tested-by when you finish. > Hi, I've applied the patch series, ran some tests on vkms, and found no issues. I mean, things have remained stable. Tested-by: Melissa Wen > Thanks > > On 07/07, Daniel Vetter wrote: > > This is needed to signal the fences from page flips, annotate it > > accordingly. We need to annotate entire timer callback since if we get > > stuck anywhere in there, then the timer stops, and hence fences stop. > > Just annotating the top part that does the vblank handling isn't > > enough. > > > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > Cc: linux-rdma@vger.kernel.org > > Cc: amd-gfx@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson > > Cc: Maarten Lankhorst > > Cc: Christian König > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Haneen Mohammed > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/vkms/vkms_crtc.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > > index ac85e17428f8..a53a40848a72 100644 > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > @@ -1,5 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > > > +#include > > + > > #include > > #include > > #include > > @@ -14,7 +16,9 @@ static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) > > struct drm_crtc *crtc = &output->crtc; > > struct vkms_crtc_state *state; > > u64 ret_overrun; > > - bool ret; > > + bool ret, fence_cookie; > > + > > + fence_cookie = dma_fence_begin_signalling(); > > > > ret_overrun = hrtimer_forward_now(&output->vblank_hrtimer, > > output->period_ns); > > @@ -49,6 +53,8 @@ static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) > > DRM_DEBUG_DRIVER("Composer worker already queued\n"); > > } > > > > + dma_fence_end_signalling(fence_cookie); > > + > > return HRTIMER_RESTART; > > } > > > > -- > > 2.27.0 > > > > -- > Rodrigo Siqueira > https://siqueira.tech From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D67D9C433E7 for ; Tue, 14 Jul 2020 09:57:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A53CC217A0 for ; Tue, 14 Jul 2020 09:57:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KnoAcjX4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A53CC217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 055706E802; Tue, 14 Jul 2020 09:57:27 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDC5D6E7FE; Tue, 14 Jul 2020 09:57:25 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id g75so4171624wme.5; Tue, 14 Jul 2020 02:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=KnoAcjX4xbVjcEeEVJH8HgscVFZmdZqaHYPU5EtBNSakspRZVOZRaF/dmW850mwgBb EIEhQt2487O5Ch8XMPP3/ZU0Tssjmmc7st+F7gnirRjowDijU/yBcwEg3SOb9H1XsW6O ZHx7iwIiziKTbK9+5KHYm9bGfe6nUHtsA16tHYKBk0E3M0omDqd8kn8O5ydg6O3+BZtA PutrPQjiZTbEN81UwfdkSWanowJeW2hnqp7xV47pvtph9xIjnMWVQWpGmaH8ubZFQrdd I/n+BAZE77F8uVwo3QQ03YNLe+6OGonbu4pK0o7ZgyMLHkHiHLHLknU5JFB2PiFJ+gQS W0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=AfMJw5Ci/luUB3syeTvfm3kUhRMnGZBcVthPg9abHLobQi9dQyzE3kI2QX5wrG37hq PknLLeL3+GzUy8Jbp4Lag+O1EYBIZ3s+6cUI3asp2YgLQdeW4ba+PNhfeyh6LESonQ0Z 1u7bNabbnqfVIPawiHlYhPuaRhXaWi8IbDYUGmAbz0P6uGSkbPqE/fG60jlh/aoQico4 z8K9klEOuU1jX8/zbyS7r9Qq8t+H1SU4V7riJMFEWM7Bm+TyjYAm/y5NCX43BSrwTRSt Nyrsw/B0VaziPSag/9o1O7bS6Ydtn2Wtb7NF/dj/XWpYl5zwQkZ0PZc4vYjRL3ZsaKEO k4xw== X-Gm-Message-State: AOAM5332HReM6hpZMX/gpgryZhHmK80qMrpYLX5DPFHd1pA8v1Cm6t/v 6zfGo59KAi9HcwtXV0Id1iM= X-Google-Smtp-Source: ABdhPJy//OrDpSJANwxwERqV3gHdFYgIJtILxA4cb/jXIXye2R9kTiX9uf+7YtLVsgsXyKpQFfoArw== X-Received: by 2002:a1c:4444:: with SMTP id r65mr3301652wma.129.1594720644598; Tue, 14 Jul 2020 02:57:24 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id r28sm27797330wrr.20.2020.07.14.02.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 02:57:23 -0700 (PDT) Date: Tue, 14 Jul 2020 06:57:17 -0300 From: Melissa Wen To: Rodrigo Siqueira Subject: Re: [PATCH 04/25] drm/vkms: Annotate vblank timer Message-ID: <20200714095717.njwk2u4tkgro54jn@smtp.gmail.com> References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-5-daniel.vetter@ffwll.ch> <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , linux-rdma@vger.kernel.org, Daniel Vetter , Intel Graphics Development , DRI Development , Chris Wilson , linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, Daniel Vetter , Christian =?utf-8?B?S8O2bmln?= , linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07/12, Rodrigo Siqueira wrote: > Hi, > = > Everything looks fine to me, I just noticed that the amdgpu patches did > not apply smoothly, however it was trivial to fix the issues. > = > Reviewed-by: Rodrigo Siqueira > = > Melissa, > Since you are using vkms regularly, could you test this patch and review > it? Remember to add your Tested-by when you finish. > Hi, I've applied the patch series, ran some tests on vkms, and found no issues. I mean, things have remained stable. Tested-by: Melissa Wen > Thanks > = > On 07/07, Daniel Vetter wrote: > > This is needed to signal the fences from page flips, annotate it > > accordingly. We need to annotate entire timer callback since if we get > > stuck anywhere in there, then the timer stops, and hence fences stop. > > Just annotating the top part that does the vblank handling isn't > > enough. > > = > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > Cc: linux-rdma@vger.kernel.org > > Cc: amd-gfx@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson > > Cc: Maarten Lankhorst > > Cc: Christian K=F6nig > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Haneen Mohammed > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/vkms/vkms_crtc.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vk= ms_crtc.c > > index ac85e17428f8..a53a40848a72 100644 > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > @@ -1,5 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > = > > +#include > > + > > #include > > #include > > #include > > @@ -14,7 +16,9 @@ static enum hrtimer_restart vkms_vblank_simulate(stru= ct hrtimer *timer) > > struct drm_crtc *crtc =3D &output->crtc; > > struct vkms_crtc_state *state; > > u64 ret_overrun; > > - bool ret; > > + bool ret, fence_cookie; > > + > > + fence_cookie =3D dma_fence_begin_signalling(); > > = > > ret_overrun =3D hrtimer_forward_now(&output->vblank_hrtimer, > > output->period_ns); > > @@ -49,6 +53,8 @@ static enum hrtimer_restart vkms_vblank_simulate(stru= ct hrtimer *timer) > > DRM_DEBUG_DRIVER("Composer worker already queued\n"); > > } > > = > > + dma_fence_end_signalling(fence_cookie); > > + > > return HRTIMER_RESTART; > > } > > = > > -- = > > 2.27.0 > > = > = > -- = > Rodrigo Siqueira > https://siqueira.tech _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD6BC433EB for ; Tue, 14 Jul 2020 09:57:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EF25217A0 for ; Tue, 14 Jul 2020 09:57:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KnoAcjX4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EF25217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 811046E817; Tue, 14 Jul 2020 09:57:27 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDC5D6E7FE; Tue, 14 Jul 2020 09:57:25 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id g75so4171624wme.5; Tue, 14 Jul 2020 02:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=KnoAcjX4xbVjcEeEVJH8HgscVFZmdZqaHYPU5EtBNSakspRZVOZRaF/dmW850mwgBb EIEhQt2487O5Ch8XMPP3/ZU0Tssjmmc7st+F7gnirRjowDijU/yBcwEg3SOb9H1XsW6O ZHx7iwIiziKTbK9+5KHYm9bGfe6nUHtsA16tHYKBk0E3M0omDqd8kn8O5ydg6O3+BZtA PutrPQjiZTbEN81UwfdkSWanowJeW2hnqp7xV47pvtph9xIjnMWVQWpGmaH8ubZFQrdd I/n+BAZE77F8uVwo3QQ03YNLe+6OGonbu4pK0o7ZgyMLHkHiHLHLknU5JFB2PiFJ+gQS W0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=AfMJw5Ci/luUB3syeTvfm3kUhRMnGZBcVthPg9abHLobQi9dQyzE3kI2QX5wrG37hq PknLLeL3+GzUy8Jbp4Lag+O1EYBIZ3s+6cUI3asp2YgLQdeW4ba+PNhfeyh6LESonQ0Z 1u7bNabbnqfVIPawiHlYhPuaRhXaWi8IbDYUGmAbz0P6uGSkbPqE/fG60jlh/aoQico4 z8K9klEOuU1jX8/zbyS7r9Qq8t+H1SU4V7riJMFEWM7Bm+TyjYAm/y5NCX43BSrwTRSt Nyrsw/B0VaziPSag/9o1O7bS6Ydtn2Wtb7NF/dj/XWpYl5zwQkZ0PZc4vYjRL3ZsaKEO k4xw== X-Gm-Message-State: AOAM5332HReM6hpZMX/gpgryZhHmK80qMrpYLX5DPFHd1pA8v1Cm6t/v 6zfGo59KAi9HcwtXV0Id1iM= X-Google-Smtp-Source: ABdhPJy//OrDpSJANwxwERqV3gHdFYgIJtILxA4cb/jXIXye2R9kTiX9uf+7YtLVsgsXyKpQFfoArw== X-Received: by 2002:a1c:4444:: with SMTP id r65mr3301652wma.129.1594720644598; Tue, 14 Jul 2020 02:57:24 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id r28sm27797330wrr.20.2020.07.14.02.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 02:57:23 -0700 (PDT) Date: Tue, 14 Jul 2020 06:57:17 -0300 From: Melissa Wen To: Rodrigo Siqueira Message-ID: <20200714095717.njwk2u4tkgro54jn@smtp.gmail.com> References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-5-daniel.vetter@ffwll.ch> <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> Subject: Re: [Intel-gfx] [PATCH 04/25] drm/vkms: Annotate vblank timer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , linux-rdma@vger.kernel.org, Daniel Vetter , Intel Graphics Development , DRI Development , Chris Wilson , linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, Daniel Vetter , Trevor Woerner , Christian =?utf-8?B?S8O2bmln?= , linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 07/12, Rodrigo Siqueira wrote: > Hi, > = > Everything looks fine to me, I just noticed that the amdgpu patches did > not apply smoothly, however it was trivial to fix the issues. > = > Reviewed-by: Rodrigo Siqueira > = > Melissa, > Since you are using vkms regularly, could you test this patch and review > it? Remember to add your Tested-by when you finish. > Hi, I've applied the patch series, ran some tests on vkms, and found no issues. I mean, things have remained stable. Tested-by: Melissa Wen > Thanks > = > On 07/07, Daniel Vetter wrote: > > This is needed to signal the fences from page flips, annotate it > > accordingly. We need to annotate entire timer callback since if we get > > stuck anywhere in there, then the timer stops, and hence fences stop. > > Just annotating the top part that does the vblank handling isn't > > enough. > > = > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > Cc: linux-rdma@vger.kernel.org > > Cc: amd-gfx@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson > > Cc: Maarten Lankhorst > > Cc: Christian K=F6nig > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Haneen Mohammed > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/vkms/vkms_crtc.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vk= ms_crtc.c > > index ac85e17428f8..a53a40848a72 100644 > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > @@ -1,5 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > = > > +#include > > + > > #include > > #include > > #include > > @@ -14,7 +16,9 @@ static enum hrtimer_restart vkms_vblank_simulate(stru= ct hrtimer *timer) > > struct drm_crtc *crtc =3D &output->crtc; > > struct vkms_crtc_state *state; > > u64 ret_overrun; > > - bool ret; > > + bool ret, fence_cookie; > > + > > + fence_cookie =3D dma_fence_begin_signalling(); > > = > > ret_overrun =3D hrtimer_forward_now(&output->vblank_hrtimer, > > output->period_ns); > > @@ -49,6 +53,8 @@ static enum hrtimer_restart vkms_vblank_simulate(stru= ct hrtimer *timer) > > DRM_DEBUG_DRIVER("Composer worker already queued\n"); > > } > > = > > + dma_fence_end_signalling(fence_cookie); > > + > > return HRTIMER_RESTART; > > } > > = > > -- = > > 2.27.0 > > = > = > -- = > Rodrigo Siqueira > https://siqueira.tech _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10790C433E6 for ; Tue, 14 Jul 2020 09:57:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D29AF21897 for ; Tue, 14 Jul 2020 09:57:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KnoAcjX4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D29AF21897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A49336E7FE; Tue, 14 Jul 2020 09:57:26 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDC5D6E7FE; Tue, 14 Jul 2020 09:57:25 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id g75so4171624wme.5; Tue, 14 Jul 2020 02:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=KnoAcjX4xbVjcEeEVJH8HgscVFZmdZqaHYPU5EtBNSakspRZVOZRaF/dmW850mwgBb EIEhQt2487O5Ch8XMPP3/ZU0Tssjmmc7st+F7gnirRjowDijU/yBcwEg3SOb9H1XsW6O ZHx7iwIiziKTbK9+5KHYm9bGfe6nUHtsA16tHYKBk0E3M0omDqd8kn8O5ydg6O3+BZtA PutrPQjiZTbEN81UwfdkSWanowJeW2hnqp7xV47pvtph9xIjnMWVQWpGmaH8ubZFQrdd I/n+BAZE77F8uVwo3QQ03YNLe+6OGonbu4pK0o7ZgyMLHkHiHLHLknU5JFB2PiFJ+gQS W0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dHnFvOIsrXw6jrB6m+7BeIm/WgTb5Cqh7gsjXssaU1c=; b=AfMJw5Ci/luUB3syeTvfm3kUhRMnGZBcVthPg9abHLobQi9dQyzE3kI2QX5wrG37hq PknLLeL3+GzUy8Jbp4Lag+O1EYBIZ3s+6cUI3asp2YgLQdeW4ba+PNhfeyh6LESonQ0Z 1u7bNabbnqfVIPawiHlYhPuaRhXaWi8IbDYUGmAbz0P6uGSkbPqE/fG60jlh/aoQico4 z8K9klEOuU1jX8/zbyS7r9Qq8t+H1SU4V7riJMFEWM7Bm+TyjYAm/y5NCX43BSrwTRSt Nyrsw/B0VaziPSag/9o1O7bS6Ydtn2Wtb7NF/dj/XWpYl5zwQkZ0PZc4vYjRL3ZsaKEO k4xw== X-Gm-Message-State: AOAM5332HReM6hpZMX/gpgryZhHmK80qMrpYLX5DPFHd1pA8v1Cm6t/v 6zfGo59KAi9HcwtXV0Id1iM= X-Google-Smtp-Source: ABdhPJy//OrDpSJANwxwERqV3gHdFYgIJtILxA4cb/jXIXye2R9kTiX9uf+7YtLVsgsXyKpQFfoArw== X-Received: by 2002:a1c:4444:: with SMTP id r65mr3301652wma.129.1594720644598; Tue, 14 Jul 2020 02:57:24 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id r28sm27797330wrr.20.2020.07.14.02.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 02:57:23 -0700 (PDT) Date: Tue, 14 Jul 2020 06:57:17 -0300 From: Melissa Wen To: Rodrigo Siqueira Subject: Re: [PATCH 04/25] drm/vkms: Annotate vblank timer Message-ID: <20200714095717.njwk2u4tkgro54jn@smtp.gmail.com> References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-5-daniel.vetter@ffwll.ch> <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , linux-rdma@vger.kernel.org, Daniel Vetter , Intel Graphics Development , Maarten Lankhorst , DRI Development , Chris Wilson , linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, Daniel Vetter , Daniel Vetter , Trevor Woerner , Christian =?utf-8?B?S8O2bmln?= , linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 07/12, Rodrigo Siqueira wrote: > Hi, > = > Everything looks fine to me, I just noticed that the amdgpu patches did > not apply smoothly, however it was trivial to fix the issues. > = > Reviewed-by: Rodrigo Siqueira > = > Melissa, > Since you are using vkms regularly, could you test this patch and review > it? Remember to add your Tested-by when you finish. > Hi, I've applied the patch series, ran some tests on vkms, and found no issues. I mean, things have remained stable. Tested-by: Melissa Wen > Thanks > = > On 07/07, Daniel Vetter wrote: > > This is needed to signal the fences from page flips, annotate it > > accordingly. We need to annotate entire timer callback since if we get > > stuck anywhere in there, then the timer stops, and hence fences stop. > > Just annotating the top part that does the vblank handling isn't > > enough. > > = > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > Cc: linux-rdma@vger.kernel.org > > Cc: amd-gfx@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson > > Cc: Maarten Lankhorst > > Cc: Christian K=F6nig > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Haneen Mohammed > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/vkms/vkms_crtc.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vk= ms_crtc.c > > index ac85e17428f8..a53a40848a72 100644 > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > @@ -1,5 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > = > > +#include > > + > > #include > > #include > > #include > > @@ -14,7 +16,9 @@ static enum hrtimer_restart vkms_vblank_simulate(stru= ct hrtimer *timer) > > struct drm_crtc *crtc =3D &output->crtc; > > struct vkms_crtc_state *state; > > u64 ret_overrun; > > - bool ret; > > + bool ret, fence_cookie; > > + > > + fence_cookie =3D dma_fence_begin_signalling(); > > = > > ret_overrun =3D hrtimer_forward_now(&output->vblank_hrtimer, > > output->period_ns); > > @@ -49,6 +53,8 @@ static enum hrtimer_restart vkms_vblank_simulate(stru= ct hrtimer *timer) > > DRM_DEBUG_DRIVER("Composer worker already queued\n"); > > } > > = > > + dma_fence_end_signalling(fence_cookie); > > + > > return HRTIMER_RESTART; > > } > > = > > -- = > > 2.27.0 > > = > = > -- = > Rodrigo Siqueira > https://siqueira.tech _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx