From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9CAC433E5 for ; Wed, 15 Jul 2020 01:24:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7945E20674 for ; Wed, 15 Jul 2020 01:24:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="n+kU5hvp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728110AbgGOBYK (ORCPT ); Tue, 14 Jul 2020 21:24:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726458AbgGOBYJ (ORCPT ); Tue, 14 Jul 2020 21:24:09 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C120C061755 for ; Tue, 14 Jul 2020 18:24:09 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id w17so694302ply.11 for ; Tue, 14 Jul 2020 18:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rBR5AjI82R5bYhOng71+5jFKvQ0oN6P/Kk11F4Z3+zk=; b=n+kU5hvp8QX2eErdqh0W7QLokIV7OjxOGug3362dtYmAU15jXA2quaw1LOjlA2OxHr grTkzjMkDFKiGgnsiQ1p2YDXLg3DuC9x59mWeMy98rbQ5Kngg7FI+StxG6d9e+/dJMkM ujFENwTUf9nN1xF3xXq+X+clzZw1jOue0CTl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rBR5AjI82R5bYhOng71+5jFKvQ0oN6P/Kk11F4Z3+zk=; b=IjdSoJBIpIOiV7DJWIVdmvb0vkXJG6ynvivbaMSr15wx1hV9IVprt5nsCe3sGCvJ/7 uWXBPZLp4xGh/nU4UpnWs1KSC7ejrBruqPV/wmXbYY9I8Mj2COFn/cuMIJjWGPLRD2zZ 2ln3FUcI3zx6SDq4wAMqFBAJ0FdEzgP2ZY2GqAOaYmw7eWCYIVcREPlgbntR4UHulY2p C+zgxN5oryanqoX+2n8V7mXRExcyVBgs81jsnuw9y3E1uKguljAc9+qhLkljZkBRaMfe PN2jeGct/6Bi2zfYO0PNKUOj0+tMaSyHGPI3DgNJXRShAPdcsGCspJeOAib/9WTIN9gR B9kA== X-Gm-Message-State: AOAM531lDGDY5bgmg7IiCmibVcbhXP+R4BWSOY863lAm5Hjwb7JVn+al TjC/+DvvMhx7KLK9kNMl8GF6dg== X-Google-Smtp-Source: ABdhPJw6NKyQlM4kooKTBPKRrF+2YxBrMmlRUoDFIuOrU0Oa7HnOhiNFeW3EcDZ1pSOeMms4CpZIuw== X-Received: by 2002:a17:90b:243:: with SMTP id fz3mr7470339pjb.17.1594776248812; Tue, 14 Jul 2020 18:24:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j13sm263522pjz.8.2020.07.14.18.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 18:24:07 -0700 (PDT) Date: Tue, 14 Jul 2020 18:24:07 -0700 From: Kees Cook To: Joerg Roedel Cc: x86@kernel.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 14/75] x86/boot/compressed/64: Add page-fault handler Message-ID: <202007141824.C00ADEDC0E@keescook> References: <20200714120917.11253-1-joro@8bytes.org> <20200714120917.11253-15-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714120917.11253-15-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 02:08:16PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Install a page-fault handler to add an identity mapping to addresses > not yet mapped. Also do some checking whether the error code is sane. > > This makes non SEV-ES machines use the exception handling > infrastructure in the pre-decompressions boot code too, making it less > likely to break in the future. > > Signed-off-by: Joerg Roedel Reviewed-by: Kees Cook -- Kees Cook