From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D310BC433E0 for ; Wed, 15 Jul 2020 01:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADE1720674 for ; Wed, 15 Jul 2020 01:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LermMRMB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbgGOB0e (ORCPT ); Tue, 14 Jul 2020 21:26:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgGOB0d (ORCPT ); Tue, 14 Jul 2020 21:26:33 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DEE7C061794 for ; Tue, 14 Jul 2020 18:26:33 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id k4so711506pld.12 for ; Tue, 14 Jul 2020 18:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QcW6VJ7a6fNZ0PIZsgk18a6NvkkANLMdBx3aJx5n2P8=; b=LermMRMBuE4iPiQWchn6+Y5pFfVd5MDVGRmaF3jnjgwTdKR/jyEitX2LJuReMi4mm9 72HL0CcXQKM56+FAnZYuVZPmiR/qQ66O5ltrce83lFbfsyOoE/4E5/KWjnK6n0t8DbHo ObrL33Mhy4WP8s4TGuuj8FnCo23Gl7p8aCzuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QcW6VJ7a6fNZ0PIZsgk18a6NvkkANLMdBx3aJx5n2P8=; b=QmdPHH3y1j2QnWsxbdyG2W12/V+nI7xSTEkv74ZdM4up10OCYJHJyWTcGEgmX033Wo YxliSgldC1fi4Z+WjWjHFRta1n9Gbz+CTUnPN06SLq96fYnhZNoUR5e3uyxA8J5DT97N gB9Swk+nmdPVRgcNZagpFG7aG32PdhirWd5am6wdGliFTVI05dAzQtemmZP1HOkkL443 LGH8YncImzB5M5vllBR7zh4unu6EHtH/6EMkc2zdZRgTkwmf9EOm/IJ2wMoS3aLKij5p RN+BZ15GdgAKeL9ybYVd53okSpJMY64Uf3w2Fb06eLRrvrgxWBbVCg1MfUMA5nA07cXl gPQw== X-Gm-Message-State: AOAM530qfGbzwGFlbTmlvDb/Q9grka09IGYyFTpyxM0vBlFYzw7eNuHp iYAdVkCFKd7bPAe4rvSoVdJIkw== X-Google-Smtp-Source: ABdhPJynXpmsAypVInC5Gh/ht68hKi/BQl06Nmv62PrADjPwEOczh3gjFDiDHlExfm6gJO53XV+6qQ== X-Received: by 2002:a17:90a:2e85:: with SMTP id r5mr7576594pjd.232.1594776393220; Tue, 14 Jul 2020 18:26:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id cl17sm250287pjb.50.2020.07.14.18.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 18:26:32 -0700 (PDT) Date: Tue, 14 Jul 2020 18:26:31 -0700 From: Kees Cook To: Joerg Roedel Cc: x86@kernel.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 28/75] x86/idt: Split idt_data setup out of set_intr_gate() Message-ID: <202007141826.8BA5C1E@keescook> References: <20200714120917.11253-1-joro@8bytes.org> <20200714120917.11253-29-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714120917.11253-29-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 02:08:30PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > The code to setup idt_data is needed for early exception handling, but > set_intr_gate() can't be used that early because it has pv-ops in its > code path, which don't work that early. > > Split out the idt_data initialization part from set_intr_gate() so > that it can be used separatly. > > Signed-off-by: Joerg Roedel Reviewed-by: Kees Cook -- Kees Cook