From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58067C433E1 for ; Wed, 15 Jul 2020 01:29:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DE3020663 for ; Wed, 15 Jul 2020 01:29:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TNYBRU3r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbgGOB33 (ORCPT ); Tue, 14 Jul 2020 21:29:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgGOB33 (ORCPT ); Tue, 14 Jul 2020 21:29:29 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370C6C061755 for ; Tue, 14 Jul 2020 18:29:29 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id d4so911441pgk.4 for ; Tue, 14 Jul 2020 18:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E7jBTUN+q1MFSKfnbOqN34m9kwFSgfqPOQP4XPd3q20=; b=TNYBRU3rt8vQTV68BnfmZdJfy3duhGTQeyyt+yRIYHSFoG9BCK31dGBtdbo1N+7tbt hrI79dVb1fe0ntLBKMc4WL1x6kMHbfxRiEDmzwpmQialwoYqiYVbPw6KH1WAcausmpbJ J7PsSsy2KNGZvf69+Tloxy+LXK3NkkzxsHi28= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E7jBTUN+q1MFSKfnbOqN34m9kwFSgfqPOQP4XPd3q20=; b=sy6pposLvc958ZZ2TvjnBEziRwogpNgpB7uNFt8pCxt09J7iuiWkkOz7i/rX8o23D1 MfjBqX0e7rtPRBn/F8thYhP1dnHf1RSJINvSpW1Q0vbKGtqx57dhozZWM5Sp5fFiyitI QIsoBYiv1QmOCThdRa/x9dQ0HZSVuOLEnYragtv3ZG5ZyDwsxpvxhLIaKGDUmAlNebZh rRQAIwpiV7zSyKE283sGuTeL10QaNlDpYLSNxmWzYB4nNPqJ1MY8Jlf48Nxvhwikyd6u hrxhAd6et9XPDUsB/s3HnOqNOXwCezO7rhkRX9EVVfTdaCx/c/Wl8/HTHfLoZUiJImA9 z3Ng== X-Gm-Message-State: AOAM532edjKOXW5zUr+XO4RQBv15zGnEjNmy5rS3ptR6OKLj4wab3jXH m/zVIy64xJNZBAYE6lxi4N3aiQ== X-Google-Smtp-Source: ABdhPJzuAx2MU3/IFIN5Fo5Om9COSAdzzeAOeGxBQatzJZdo3a9WrMaQ/5hz7S1dWNOewUMx6ayNgg== X-Received: by 2002:a63:308:: with SMTP id 8mr6053673pgd.112.1594776568754; Tue, 14 Jul 2020 18:29:28 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d37sm311670pgd.18.2020.07.14.18.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 18:29:27 -0700 (PDT) Date: Tue, 14 Jul 2020 18:29:27 -0700 From: Kees Cook To: Joerg Roedel Cc: x86@kernel.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 29/75] x86/idt: Move two function from k/idt.c to i/a/desc.h Message-ID: <202007141827.5A5D64454@keescook> References: <20200714120917.11253-1-joro@8bytes.org> <20200714120917.11253-30-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714120917.11253-30-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 02:08:31PM +0200, Joerg Roedel wrote: > From: Joerg Roedel I'm not a huge fan of the Subject. :) Maybe: x86/idt: Make IDT init functions static inlines > > Move these two functions from kernel/idt.c to include/asm/desc.h: > > * init_idt_data() > * idt_init_desc() > > These functions are needed to setup IDT entries very early and need to > be called from head64.c. To be usable this early these functions need to > be compiled without instrumentation and the stack-protector feature. > These features need to be kept enabled for kernel/idt.c, so head64.c > must use its own versions. > > Signed-off-by: Joerg Roedel But regardless: Reviewed-by: Kees Cook -- Kees Cook