From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3AB6C433E0 for ; Tue, 14 Jul 2020 21:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A409820674 for ; Tue, 14 Jul 2020 21:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GtzkgbuG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728310AbgGNV1h (ORCPT ); Tue, 14 Jul 2020 17:27:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727822AbgGNV1g (ORCPT ); Tue, 14 Jul 2020 17:27:36 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B17C061755 for ; Tue, 14 Jul 2020 14:27:36 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f139so958082wmf.5 for ; Tue, 14 Jul 2020 14:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=KSfvDIX/TrKhNfavz9gqT4CkPok883ejJCseRAMUrzQ=; b=GtzkgbuGm+CflRAs9y9OQuFQxiZl5hlT9j1xzSijnMFIFq/1ETlmkPrZBx4rPXpZQW kQUMvTOCAS3v3gZFeaCvS7AG6Uz/NZz7h9lufDKAjEX6IwrfXF4czGjb56vFo6Brn0zU /YR4DgTdYmVAF8I6PT6XGCwBW5JyaGZ4Jbhqlp8sSzGRy+EUiO7zFBs6ud0wuK0YCVRa e7WtqO2ymi6k9GOuyREhUvA+khGnFBn8wSLNd8nALFXqS31mo3UzJR7k5xQF2qnIN5IH JL3M3M/Qaxkw6nCT79ts/jLodZ0qILcCfE+jFLaGr0w/xkZrF41g8RgjZBulPXFRKI50 H4lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=KSfvDIX/TrKhNfavz9gqT4CkPok883ejJCseRAMUrzQ=; b=ofE9E2JshEWo8pk7GfVY1O/JsWe8b5RuV4VYRDfL45t28RejRFVrJfjf+7XF5zBzQe +QPEGuu7AO1a9lbxm2J7T3jMEPOrcM7RBxO31yp7bAIWxkX1uBniAKrZozfuRXNhOiZ2 us8JIaslG71APjGb36ofR9tjWqEbCB8pdV3jy916soFeePtNBVI+UNtgBZX2aYPUTWAe urWYQcVNtPZW8CWSq8WDJ3I+i0jZbScpwgmvvA9mniy6WCx3lVjZe8gct3f7ODOCD0FH isol7+R381wpeGh4wk9oYcbH6YgsPr4K8e3wzQc9yXs5R1nbGGlWIuoR+WBfC9qEMb6t VtCw== X-Gm-Message-State: AOAM530eiXhmWw8F9kCF/eNaTXynhpx1k+9RlA1+g/CBkZ2rq7l8zAAe yXPYWiOIMKwOni5g7JKLrG3lBxizd97Pig== X-Google-Smtp-Source: ABdhPJy0GFscM5m948VgN4h5ukfqjG35G3bXmIQulvRQz8qUJoPyiRdnYmLyFLy/FTP372JkZSxeSQ== X-Received: by 2002:a1c:3504:: with SMTP id c4mr5580994wma.177.1594760540764; Tue, 14 Jul 2020 14:02:20 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id t141sm13313wmt.26.2020.07.14.14.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 14:02:20 -0700 (PDT) Date: Tue, 14 Jul 2020 22:02:18 +0100 From: Lee Jones To: Kim Phillips Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Jacob Shin Subject: Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Message-ID: <20200714210218.GH1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-14-lee.jones@linaro.org> <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jul 2020, Kim Phillips wrote: > On 7/14/20 9:50 AM, Lee Jones wrote: > > Can't see them being used anywhere and the compiler doesn't complain > > that they're missing, so ... > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=] > > 147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > Cc: Jacob Shin > > Signed-off-by: Lee Jones > > --- > > Same comment as for patch 9/13: these are used automatic module loading. How does that work? Could you point me to the code which handles that please? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B73C433E4 for ; Tue, 14 Jul 2020 21:28:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE3DF20658 for ; Tue, 14 Jul 2020 21:28:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VtvK1gFr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GtzkgbuG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE3DF20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SXU+nIxmXdxMjmKVNWv/yeNn/rJ741HvV9a0tFi7h8E=; b=VtvK1gFrjONXhhuX0J5lLgwIs /HJj00ARufG5vCNPHFnXC9eRlCre1cTOQ45B7rTgh7u6CNoAU4e3ot1AoqvqdKOvevKayA953Aqqi YFJwV/e2curIxDqr1ErGYBV5DHwGFUOy0k9Yi0f29DXtPXgSRRYfWq6ZEw8BKV0oJPM/TfAJ9gKH9 yPmCq6uAZ3CDdhqVlCuTYgM4lqjLg7paLsAJcUiSobdF9JBnWVEryS67BBZO+jMyESGuag1c56YYN MQDWQk3bSqFf6RcQ9IMobarVHfdxZfbLY4WYigzMw/VbR9yXGONGRSLRrNbuelyl66eT5du05iW7J kezNdQLdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvSSf-00078y-17; Tue, 14 Jul 2020 21:27:37 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvSSb-000787-Uw for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 21:27:35 +0000 Received: by mail-wm1-x343.google.com with SMTP id q15so927340wmj.2 for ; Tue, 14 Jul 2020 14:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=KSfvDIX/TrKhNfavz9gqT4CkPok883ejJCseRAMUrzQ=; b=GtzkgbuGm+CflRAs9y9OQuFQxiZl5hlT9j1xzSijnMFIFq/1ETlmkPrZBx4rPXpZQW kQUMvTOCAS3v3gZFeaCvS7AG6Uz/NZz7h9lufDKAjEX6IwrfXF4czGjb56vFo6Brn0zU /YR4DgTdYmVAF8I6PT6XGCwBW5JyaGZ4Jbhqlp8sSzGRy+EUiO7zFBs6ud0wuK0YCVRa e7WtqO2ymi6k9GOuyREhUvA+khGnFBn8wSLNd8nALFXqS31mo3UzJR7k5xQF2qnIN5IH JL3M3M/Qaxkw6nCT79ts/jLodZ0qILcCfE+jFLaGr0w/xkZrF41g8RgjZBulPXFRKI50 H4lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=KSfvDIX/TrKhNfavz9gqT4CkPok883ejJCseRAMUrzQ=; b=NXJWOP3h8FnRzNKBdfJ1jCcbYxl4M/Y31S8MdXpKx/JrEjZss4rB7lZvjqC/F4Pr2u XdTOsg44d1PDim1+oNs7ysbrtmMWsHCozs0OOnp+nctnTSe3GTUrF51gyJc8qXPmdLCw BNsoIGS8hWty0pClSdMibhjX+Y7iFKl6aqATbAJNSBcQ0e9HdJtY1i5rHwJNew7EWZEk hAkEL0iv7oSZKXVYu4KXJik24XnlrqLcrnRf4Z7gcnEFHIIW7HIzwzBUnFMxj0RMhlXo Vu1KkqwkZ/peG/q3JU0ebDIR23MCCw+cPLDqQZgFxRMbiMNq6tYDs+ryHGpG8ckwQXCG dDDw== X-Gm-Message-State: AOAM531A4vJRuU5ZS+gJcW0RzA5W0osgu2NTFVPyZ2vOfWLmPYfG6RHL Hj/AEfPB5vPZLNPazD0EkaacS9O9M8iNlw== X-Google-Smtp-Source: ABdhPJy0GFscM5m948VgN4h5ukfqjG35G3bXmIQulvRQz8qUJoPyiRdnYmLyFLy/FTP372JkZSxeSQ== X-Received: by 2002:a1c:3504:: with SMTP id c4mr5580994wma.177.1594760540764; Tue, 14 Jul 2020 14:02:20 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id t141sm13313wmt.26.2020.07.14.14.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 14:02:20 -0700 (PDT) Date: Tue, 14 Jul 2020 22:02:18 +0100 From: Lee Jones To: Kim Phillips Subject: Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Message-ID: <20200714210218.GH1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-14-lee.jones@linaro.org> <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_172734_694541_EEB22B29 X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, Jacob Shin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxNCBKdWwgMjAyMCwgS2ltIFBoaWxsaXBzIHdyb3RlOgoKPiBPbiA3LzE0LzIwIDk6 NTAgQU0sIExlZSBKb25lcyB3cm90ZToKPiA+IENhbid0IHNlZSB0aGVtIGJlaW5nIHVzZWQgYW55 d2hlcmUgYW5kIHRoZSBjb21waWxlciBkb2Vzbid0IGNvbXBsYWluCj4gPiB0aGF0IHRoZXkncmUg bWlzc2luZywgc28gLi4uCj4gPiAKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBi dWlsZCB3YXJuaW5nKHMpOgo+ID4gCj4gPiAgZHJpdmVycy9jcHVmcmVxL2FtZF9mcmVxX3NlbnNp dGl2aXR5LmM6MTQ3OjMyOiB3YXJuaW5nOiDigJhhbWRfZnJlcV9zZW5zaXRpdml0eV9pZHPigJkg ZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZhcmlhYmxlPV0KPiA+ICAxNDcg fCBzdGF0aWMgY29uc3Qgc3RydWN0IHg4Nl9jcHVfaWQgYW1kX2ZyZXFfc2Vuc2l0aXZpdHlfaWRz W10gPSB7Cj4gPiAgfCBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KPiA+IAo+ID4gQ2M6IEphY29i IFNoaW4gPGphY29iLnNoaW5AYW1kLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8 bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiAKPiBTYW1lIGNvbW1lbnQgYXMgZm9yIHBh dGNoIDkvMTM6IHRoZXNlIGFyZSB1c2VkIGF1dG9tYXRpYyBtb2R1bGUgbG9hZGluZy4KCkhvdyBk b2VzIHRoYXQgd29yaz8KCkNvdWxkIHlvdSBwb2ludCBtZSB0byB0aGUgY29kZSB3aGljaCBoYW5k bGVzIHRoYXQgcGxlYXNlPwoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5p Y2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ug c29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8 IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK