From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A4FC433E4 for ; Wed, 15 Jul 2020 02:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA34620663 for ; Wed, 15 Jul 2020 02:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DezqCrAt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbgGOCt4 (ORCPT ); Tue, 14 Jul 2020 22:49:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbgGOCt4 (ORCPT ); Tue, 14 Jul 2020 22:49:56 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D83A8C061755 for ; Tue, 14 Jul 2020 19:49:54 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id md7so1566266pjb.1 for ; Tue, 14 Jul 2020 19:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q5vvXYd0T7QlyjZ+KGgsyakgUV75e/J/r/3oQdNc2Z8=; b=DezqCrAtzHMnxCsO8uGVnxD15BIn0IEeUuNsFF6BNaXJcE67PXoACB2NqCJsZ4YMJ6 IQfBwy4l2Ikj7pABYwwxJNXwhc8u73xQ20q5oPN99lPuNCa5jOV/MvLUN3SFhtI6m7Ov AB1DPqy+ndx22mCtf3jVpdGuDQ0GcrT8Wu+t09vRbD7RHq4a39UJgYi1qFRcEsGI65Fs PHLZbUodNCESvXzrUiaRxbbYKAiQBHDxeP593atEm8e5e8pw/XPaP62KysVY6Ka+sHP6 fh7AMRWHGZ+U0JWQbNJbDhFDsfj7BFFFxwSqKCK8ea4L8f4nSFgcZ3Nw6C+U+py9bhNh TqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q5vvXYd0T7QlyjZ+KGgsyakgUV75e/J/r/3oQdNc2Z8=; b=o7n2HtyoE2hnQoqI1IDJg78paVjJNtpLBsB5G2mh5PL4VeWPvGpX9LkGhYiiUHGAGT xtoJTQZgT6l6Xrc5dRIEpXnps2TRXmFkBCRDWwd72mKyl9jtgsBJ73Cqt5IMGsNRHf6k YUcYScxK+zvYpPXvIU1iXoSc1UQn5i5S0J7khdALvip+5oUul3dbgnGQsrh3mKrmEIsr 0XO44bhdxvbtYV7dejV/CSOHqH+vVGEJpkw1PDeagHES37BLJbpIy3+KpViGcU9BGC45 AwXEdkTO95vUOxEkF6blHfFl0xO6FZA/fQbi6D+ZWC+EPhJCTHNDtb4HYqXAfHBLJ40V G37w== X-Gm-Message-State: AOAM530b+Y8Yl+YhYFzvcokwurPlqzZKwo2nhbEh/KzSLLQXmwcGApfV F7Of/WaDLPUSLIIO1NUlfGyHBg== X-Google-Smtp-Source: ABdhPJzBhKELTRjg9O0sSVH+78W39OnjWXN56hDD8UePtV9hJOoL5/dKy2apkTSELv77wUsEMtcZDg== X-Received: by 2002:a17:90a:80c3:: with SMTP id k3mr7713771pjw.102.1594781394340; Tue, 14 Jul 2020 19:49:54 -0700 (PDT) Received: from localhost ([122.172.34.142]) by smtp.gmail.com with ESMTPSA id k2sm404748pgm.11.2020.07.14.19.49.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2020 19:49:53 -0700 (PDT) Date: Wed, 15 Jul 2020 08:19:51 +0530 From: Viresh Kumar To: Lee Jones Cc: rjw@rjwysocki.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Dominik Brodowski , Ashok Raj , Jacob Shin Subject: Re: [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Message-ID: <20200715024951.zr36iuagany5ii56@vireshk-i7> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-3-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714145049.2496163-3-lee.jones@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-07-20, 15:50, Lee Jones wrote: > -/** > +/* > * cpufreq_remove_dev - remove a CPU device Because cpufreq_add_dev() is part of kernel doc, we better keep it. > * > * Removes the cpufreq interface for a CPU device. > @@ -2373,6 +2374,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor); > * cpufreq_get_policy - get the current cpufreq_policy > * @policy: struct cpufreq_policy into which the current cpufreq_policy > * is written > + * @cpu: CPU to find the policy for > * > * Reads the current cpufreq policy. > */ > @@ -2759,7 +2761,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > } > EXPORT_SYMBOL_GPL(cpufreq_register_driver); > > -/** > +/* > * cpufreq_unregister_driver - unregister the current CPUFreq driver And this should be there for sure. > * > * Unregister the current CPUFreq driver. Only call this if you have > -- > 2.25.1 -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FAFC433E0 for ; Wed, 15 Jul 2020 02:51:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CBA920663 for ; Wed, 15 Jul 2020 02:51:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OuUsnjsZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DezqCrAt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CBA920663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qLbiRvjNDW5iKvhqa6J8GSxPhSBRysZJDAPPhbNQL/o=; b=OuUsnjsZraRVIAINUp7ahxap4 Q3ojMjCHOF4igBlfNGtO8RUb9Qfa4Kf4NLpzzmrTsJhju8eAr9IV8QDuLj1tESI5fDZCXbehMW/Cn zKnAJoZNHG0ts9sS1T9XfXPneZfxsuDAHLUJCd/1uTm9dl7U8czaNSIICMzkbXrsUSGXhXN7Nyqkk j+3hLHNWuPeoPsCQ+v4DoGWN8zWIzM09loHkER+3BDw6jVAnlrd4ZfTnCtabFNkiSHrJZfKmnOoFY Rjv0WVR4TCVu168bZf0ls6tVuGg7O0RadeQeLIalGwGd2FHyWChnUaAOYSy4qE0dzajMapRCj512+ wd1e5qLqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvXUb-0002zK-VX; Wed, 15 Jul 2020 02:49:58 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvXUa-0002yc-9Q for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 02:49:57 +0000 Received: by mail-pl1-x641.google.com with SMTP id m16so1214963pls.5 for ; Tue, 14 Jul 2020 19:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q5vvXYd0T7QlyjZ+KGgsyakgUV75e/J/r/3oQdNc2Z8=; b=DezqCrAtzHMnxCsO8uGVnxD15BIn0IEeUuNsFF6BNaXJcE67PXoACB2NqCJsZ4YMJ6 IQfBwy4l2Ikj7pABYwwxJNXwhc8u73xQ20q5oPN99lPuNCa5jOV/MvLUN3SFhtI6m7Ov AB1DPqy+ndx22mCtf3jVpdGuDQ0GcrT8Wu+t09vRbD7RHq4a39UJgYi1qFRcEsGI65Fs PHLZbUodNCESvXzrUiaRxbbYKAiQBHDxeP593atEm8e5e8pw/XPaP62KysVY6Ka+sHP6 fh7AMRWHGZ+U0JWQbNJbDhFDsfj7BFFFxwSqKCK8ea4L8f4nSFgcZ3Nw6C+U+py9bhNh TqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q5vvXYd0T7QlyjZ+KGgsyakgUV75e/J/r/3oQdNc2Z8=; b=dvCNs+0MTjOx/44CAswxCaLj80fWAAss8kpJc5Jw3c5mecexYsdnnIys7imN2HYvY8 JkMshTw6WaSWVyDS+jjusK1wb+s3jZrJcRnZfoBm0arHR95tIiGlSfIyURvVxJ1TebTU 9b95MsAWVK9/ddy4kPPOHa3DbzTOUCTiu6FPzEi7nZCgNuCu6SQo5RyoVI3dWb1EELkx uuJ6/zeGQ0O7QHB6QZoLBOsVG9FenBiPIMQj5V6hZt/48sFIF7W/SuOxcrBY6LBLRN2H ZVjX9xtJXhgHp3Doh7rP4M9A1f/oK3jjmzLFBs4IQzLAVoIII5GDzSsEMEC/9htk+atc 5ppA== X-Gm-Message-State: AOAM53238q7imOdfUK2dKSfQA0uPct4WANkXClOBQJ3SL7Mqq4MSvOzN WN71KzHWBuex8QETTXbr4ypfvg== X-Google-Smtp-Source: ABdhPJzBhKELTRjg9O0sSVH+78W39OnjWXN56hDD8UePtV9hJOoL5/dKy2apkTSELv77wUsEMtcZDg== X-Received: by 2002:a17:90a:80c3:: with SMTP id k3mr7713771pjw.102.1594781394340; Tue, 14 Jul 2020 19:49:54 -0700 (PDT) Received: from localhost ([122.172.34.142]) by smtp.gmail.com with ESMTPSA id k2sm404748pgm.11.2020.07.14.19.49.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2020 19:49:53 -0700 (PDT) Date: Wed, 15 Jul 2020 08:19:51 +0530 From: Viresh Kumar To: Lee Jones Subject: Re: [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Message-ID: <20200715024951.zr36iuagany5ii56@vireshk-i7> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-3-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714145049.2496163-3-lee.jones@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_224956_349667_CB8F7F28 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashok Raj , linux-pm@vger.kernel.org, Jacob Shin , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dominik Brodowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14-07-20, 15:50, Lee Jones wrote: > -/** > +/* > * cpufreq_remove_dev - remove a CPU device Because cpufreq_add_dev() is part of kernel doc, we better keep it. > * > * Removes the cpufreq interface for a CPU device. > @@ -2373,6 +2374,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor); > * cpufreq_get_policy - get the current cpufreq_policy > * @policy: struct cpufreq_policy into which the current cpufreq_policy > * is written > + * @cpu: CPU to find the policy for > * > * Reads the current cpufreq policy. > */ > @@ -2759,7 +2761,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > } > EXPORT_SYMBOL_GPL(cpufreq_register_driver); > > -/** > +/* > * cpufreq_unregister_driver - unregister the current CPUFreq driver And this should be there for sure. > * > * Unregister the current CPUFreq driver. Only call this if you have > -- > 2.25.1 -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel