All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	robh+dt@kernel.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-media@vger.kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, dave.stevenson@raspberrypi.com,
	dongchun.zhu@mediatek.com, linux-renesas-soc@vger.kernel.org,
	roman.kovalivskyi@globallogic.com
Subject: Re: [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'
Date: Wed, 15 Jul 2020 09:26:08 +0200	[thread overview]
Message-ID: <20200715072608.hvog74szw7udx4sk@uno.localdomain> (raw)
In-Reply-To: <20200714234535.GN5854@pendragon.ideasonboard.com>

Hi Laurent,

On Wed, Jul 15, 2020 at 02:45:35AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Jul 14, 2020 at 04:28:55PM +0200, Jacopo Mondi wrote:
> > Document the 'remote-endpoint' property and add it to the list of required
> > endpoint properties in imx219 and ov8856 dt-schema binding files.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
> >  Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > index dfc4d29a4f04..0251e15fe0a7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > @@ -71,8 +71,13 @@ properties:
> >              description:
> >                Allowed data bus frequencies.
> >
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
> > +
> >          required:
> >            - link-frequencies
> > +          - remote-endpoint
> >
> >  required:
> >    - compatible
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 1956b2a32bf4..c1f363bb5aee 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -84,9 +84,14 @@ properties:
> >                Allowed data bus frequencies. 360000000, 180000000 Hz or both
> >                are supported by the driver.
> >
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
> > +
>
> Extraneous blank line ?
>

Yes indeed.

I'll fix and resend with your comments taken in (this and the one in
the previous patch).

Rob, Hans:
Should this go in through the media tree or through rob ?

Thanks
  j

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> >
> >          required:
> >            - link-frequencies
> > +          - remote-endpoint
> >
> >      required:
> >        - endpoint
>
> --
> Regards,
>
> Laurent Pinchart

  reply	other threads:[~2020-07-15  7:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 14:28 [PATCH v2 0/3] dt-bidings: media: ov5647 bindings + small fix Jacopo Mondi
2020-07-14 14:28 ` [PATCH v2 1/3] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
2020-07-14 23:44   ` Laurent Pinchart
2020-07-14 14:28 ` [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint' Jacopo Mondi
2020-07-14 23:45   ` Laurent Pinchart
2020-07-15  7:26     ` Jacopo Mondi [this message]
2020-07-15  8:10   ` Sergei Shtylyov
2020-07-15  8:37     ` Jacopo Mondi
2020-07-14 14:28 ` [PATCH v2 3/3] media: MAINTAINERS: ov5647: Add myself as maintainer Jacopo Mondi
2020-07-14 23:46   ` Laurent Pinchart
2020-07-15 10:26   ` Geert Uytterhoeven
2020-07-15 10:39     ` Jacopo Mondi
2020-07-15 11:07 ` [PATCH v2 0/3] dt-bidings: media: ov5647 bindings + small fix Dave Stevenson
2020-07-15 11:50   ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200715072608.hvog74szw7udx4sk@uno.localdomain \
    --to=jacopo@jmondi.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongchun.zhu@mediatek.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo+renesas@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=roman.kovalivskyi@globallogic.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.