From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734FFC433E2 for ; Wed, 15 Jul 2020 09:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5155020760 for ; Wed, 15 Jul 2020 09:23:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="iRcqbhoo"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="XvgIcEpx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730645AbgGOJXw (ORCPT ); Wed, 15 Jul 2020 05:23:52 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:49896 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729672AbgGOJXt (ORCPT ); Wed, 15 Jul 2020 05:23:49 -0400 Date: Wed, 15 Jul 2020 11:23:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1594805027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nVewUEkE+vEgqvpSZaR+rHv9rvICaRBJ6Hc/Y4Gfv04=; b=iRcqbhooQLbNQYs0t6EgUxItIJxhtP3b8s8woTQvVERuHgCybkfAetFUIzEPA2qoDta3XB hFGfqNFUsu3hRGjuhAphrutMLv6knCYWsKZM43Mb3AYZHtaVSpWCf9rN/cvu+IehElTs6w w7jkCecMreibSzUAgIGJ2NVV3RoeZlRT8WDBS9NXru7YSKwOWLV7KNvaQtm77bvWFv6rIw Tmf674X1SQV4U6ysvZST8Y6X5/9VyE6jietFR2lRK9R/Fnv4Xy0+oqlSKZzC+OAamfCMpL S6AUQbGmozxbFDdI/qPyin9SrTMah7JNfk2r2V4MAlBnzEXS+gnSSHhpJVaY6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1594805027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nVewUEkE+vEgqvpSZaR+rHv9rvICaRBJ6Hc/Y4Gfv04=; b=XvgIcEpx3pM+hW2dYCP5H7sBCeEboYeXT2fgmDCQ3cwOqyeGO6r/T+NNo/0VBxbVQMqjLC G1W0Dhzx1t3IK1CQ== From: "Ahmed S. Darwish" To: peterz@infradead.org Cc: Leo Yan , Will Deacon , Mark Rutland , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Catalin Marinas , Thomas Gleixner , Paul Cercueil , "Ben Dooks (Codethink)" , Adrian Hunter , Kan Liang , jogness@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] sched_clock: Expose struct clock_read_data Message-ID: <20200715092345.GA231464@debian-buster-darwi.lab.linutronix.de> References: <20200715020512.20991-1-leo.yan@linaro.org> <20200715020512.20991-2-leo.yan@linaro.org> <20200715055650.GB225020@debian-buster-darwi.lab.linutronix.de> <20200715081222.GB10769@hirez.programming.kicks-ass.net> <20200715081443.GB43129@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715081443.GB43129@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15, 2020 at 10:14:43AM +0200, peterz@infradead.org wrote: > On Wed, Jul 15, 2020 at 10:12:22AM +0200, Peter Zijlstra wrote: > > On Wed, Jul 15, 2020 at 07:56:50AM +0200, Ahmed S. Darwish wrote: > > > On Wed, Jul 15, 2020 at 10:05:07AM +0800, Leo Yan wrote: > > > > From: Peter Zijlstra > > > > > > > ... > > > > > > > > Provide struct clock_read_data and two (seqcount) helpers so that > > > > architectures (arm64 in specific) can expose the numbers to userspace. > > > > > > > ... > > > > > > > > +struct clock_read_data *sched_clock_read_begin(unsigned int *seq) > > > > +{ > > > > + *seq = raw_read_seqcount(&cd.seq); > > > > + return cd.read_data + (*seq & 1); > > > > +} > > > > + > > > ... > > > > > > Hmm, this seqcount_t is actually a latch seqcount. I know the original > > > code also used raw_read_seqcount(), but while at it, let's use the > > > proper read API for seqcount_t latchers: raw_read_seqcount_latch(). > > > > > > raw_read_seqcount_latch() has no read memory barrier though, and a > > > suspicious claim that READ_ONCE() pairs with an smp_wmb() (??). But if > > > its implementation is wrong, let's fix it there instead. > > > > It's supposed to be a dependent load, so READ_ONCE() is sufficient. > > Except, of course, the C standard has other ideas, so a compiler is > > allowed to wreck that, but they mostly don't :-) > > Also see: > > https://lkml.kernel.org/r/20200625085745.GD117543@hirez.programming.kicks-ass.net Oh, spot on. Can we then please replace the raw_read_seqcount(), in the original patch which started this discussion, with raw_read_seqcount_latch()? I see that you already did something similar for timekeeping.c: 7fc26327b756 ("seqlock: Introduce raw_read_seqcount_latch()"). Confession time: I have an internal patch series which introduces seqcount_latch_t. Having a standardized set of accessors for the seqcount latch read and write paths will make everything much more streamlined :-) Thanks, -- Ahmed S. Darwish Linutronix GmbH From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22817C433E6 for ; Wed, 15 Jul 2020 09:25:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E630F206D5 for ; Wed, 15 Jul 2020 09:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v8CfL2Zt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="iRcqbhoo"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="XvgIcEpx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E630F206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+J8jl7GYyxo6LT/6LtpNMdgJGKtWptdDIOBoYKA05qw=; b=v8CfL2Zt0xDVH4seFu7EVUta/ 1GVZMTpSGfqWCRinxxOMyOLOeULW06FLdI3fdAwO+MkXqjCgdo+8QSGEbFAWLduowu2Ijf+8RvmvM ztAA+Z7MuaNrnDtiLxPySnKhAUFchjaTyOJxzVci5LyeybZW28lUwmPCaWGlS2W/mQNJggeL/2XIa 4MTNTq/zBUFFpDGhKRbleKXlFLt2Cu9OBoyvZN+eat/2TpbvF530R/uw0iuTNcds2RMuvGKaPDx8Z xLNQt8FVN8ED9oTBTv8IJvdyj+AJbLmG8C8dzCZGuPuIXMGOB4xUAsx6fkTB9d3XvjtkaOLPdGJIL bEZPdtP6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvddo-0001YN-8J; Wed, 15 Jul 2020 09:23:52 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvddl-0001XS-Fo for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 09:23:50 +0000 Date: Wed, 15 Jul 2020 11:23:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1594805027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nVewUEkE+vEgqvpSZaR+rHv9rvICaRBJ6Hc/Y4Gfv04=; b=iRcqbhooQLbNQYs0t6EgUxItIJxhtP3b8s8woTQvVERuHgCybkfAetFUIzEPA2qoDta3XB hFGfqNFUsu3hRGjuhAphrutMLv6knCYWsKZM43Mb3AYZHtaVSpWCf9rN/cvu+IehElTs6w w7jkCecMreibSzUAgIGJ2NVV3RoeZlRT8WDBS9NXru7YSKwOWLV7KNvaQtm77bvWFv6rIw Tmf674X1SQV4U6ysvZST8Y6X5/9VyE6jietFR2lRK9R/Fnv4Xy0+oqlSKZzC+OAamfCMpL S6AUQbGmozxbFDdI/qPyin9SrTMah7JNfk2r2V4MAlBnzEXS+gnSSHhpJVaY6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1594805027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nVewUEkE+vEgqvpSZaR+rHv9rvICaRBJ6Hc/Y4Gfv04=; b=XvgIcEpx3pM+hW2dYCP5H7sBCeEboYeXT2fgmDCQ3cwOqyeGO6r/T+NNo/0VBxbVQMqjLC G1W0Dhzx1t3IK1CQ== From: "Ahmed S. Darwish" To: peterz@infradead.org Subject: Re: [PATCH v2 1/6] sched_clock: Expose struct clock_read_data Message-ID: <20200715092345.GA231464@debian-buster-darwi.lab.linutronix.de> References: <20200715020512.20991-1-leo.yan@linaro.org> <20200715020512.20991-2-leo.yan@linaro.org> <20200715055650.GB225020@debian-buster-darwi.lab.linutronix.de> <20200715081222.GB10769@hirez.programming.kicks-ass.net> <20200715081443.GB43129@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200715081443.GB43129@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_052349_656684_8E368C0D X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Paul Cercueil , Ingo Molnar , Leo Yan , Namhyung Kim , Thomas Gleixner , jogness@linutronix.de, Will Deacon , "Ben Dooks \(Codethink\)" , linux-arm-kernel@lists.infradead.org, Kan Liang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 15, 2020 at 10:14:43AM +0200, peterz@infradead.org wrote: > On Wed, Jul 15, 2020 at 10:12:22AM +0200, Peter Zijlstra wrote: > > On Wed, Jul 15, 2020 at 07:56:50AM +0200, Ahmed S. Darwish wrote: > > > On Wed, Jul 15, 2020 at 10:05:07AM +0800, Leo Yan wrote: > > > > From: Peter Zijlstra > > > > > > > ... > > > > > > > > Provide struct clock_read_data and two (seqcount) helpers so that > > > > architectures (arm64 in specific) can expose the numbers to userspace. > > > > > > > ... > > > > > > > > +struct clock_read_data *sched_clock_read_begin(unsigned int *seq) > > > > +{ > > > > + *seq = raw_read_seqcount(&cd.seq); > > > > + return cd.read_data + (*seq & 1); > > > > +} > > > > + > > > ... > > > > > > Hmm, this seqcount_t is actually a latch seqcount. I know the original > > > code also used raw_read_seqcount(), but while at it, let's use the > > > proper read API for seqcount_t latchers: raw_read_seqcount_latch(). > > > > > > raw_read_seqcount_latch() has no read memory barrier though, and a > > > suspicious claim that READ_ONCE() pairs with an smp_wmb() (??). But if > > > its implementation is wrong, let's fix it there instead. > > > > It's supposed to be a dependent load, so READ_ONCE() is sufficient. > > Except, of course, the C standard has other ideas, so a compiler is > > allowed to wreck that, but they mostly don't :-) > > Also see: > > https://lkml.kernel.org/r/20200625085745.GD117543@hirez.programming.kicks-ass.net Oh, spot on. Can we then please replace the raw_read_seqcount(), in the original patch which started this discussion, with raw_read_seqcount_latch()? I see that you already did something similar for timekeeping.c: 7fc26327b756 ("seqlock: Introduce raw_read_seqcount_latch()"). Confession time: I have an internal patch series which introduces seqcount_latch_t. Having a standardized set of accessors for the seqcount latch read and write paths will make everything much more streamlined :-) Thanks, -- Ahmed S. Darwish Linutronix GmbH _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel