From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9A3C433E2 for ; Wed, 15 Jul 2020 09:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B281206D5 for ; Wed, 15 Jul 2020 09:25:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="S/n86HB0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730679AbgGOJZc (ORCPT ); Wed, 15 Jul 2020 05:25:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729983AbgGOJZc (ORCPT ); Wed, 15 Jul 2020 05:25:32 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00F32C061755 for ; Wed, 15 Jul 2020 02:25:32 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id j18so4655732wmi.3 for ; Wed, 15 Jul 2020 02:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BxEQuTmqko+pgzijDd2lGbDRaEjjMMNtGU3cvLEaE6E=; b=S/n86HB008axGB6WKz9m+NdU+bqcERxKeXWGb+MQoYnuj23/rvTNA/HzyJOsXElTUa kMBNN09IM8T7a410mbjPH9IrXuuq340M4y9PK7byTyrJZwHUOHbvhm7AcYY/eX7etFel PKOEE2Wvi3JJ4qp+02qOQoiegkfD09R+TPpAE6T9dQRDlJ4ur15/kQcEXisqt5SV0+FP g1INpsSjpPPU24d3RlzcCgeZRT2zHFjOo7M9e3gyMNpFQxGUEWqVc+AfDmhQCsXvGSb6 M1/x90AKy+XbFF5iozX5hX48gucEuA3aZypkMMHdbHnDxOnOPyH4JuSphmOgqZyH6kXn JOVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BxEQuTmqko+pgzijDd2lGbDRaEjjMMNtGU3cvLEaE6E=; b=JUAzDPeXMy8aQxeghBctPn5cHEVIqd5m+CxVK4k5QCgFKiEmJ43zKpZNqbxUnpzzY4 ZzL+wzZb3piAtsKTOupT/lRIQtpgckCVawKDnKPJoyY0niSaYVfvSHKrXd/hxh26ofPT ApWNDavrP1jh3xIl3zyUv1FeBVqHEXDnzZZtldJaOxf3IX61QB3WfPBw1zYtzNQClZsN TrHWeLzEJiBEk2j2rdWLQvy7HYPd5SiHGoGgFRq2VY4dQB/FzBRGcSt/ZoAHxaQbqg78 6QCByj0lPAnRTX8chp7q2QLLWTgW7e2i8sZh26t/s4032cd74wjsxAxBMfrncXOyYsAK LjYA== X-Gm-Message-State: AOAM532TdVIGCjfJznEc97U5+z8SbAS5SWncpHCSZR9sUinSOtoyJ7Aq 0MPpskOkPI8t0mCGUV4QjeN5Ag5VVO4= X-Google-Smtp-Source: ABdhPJyommb1Qc2v2rVIuSC6qsOykeoBwgjcpJYFj8Qs7T2/nah5bDGTDtY6INNmZRnI240Jm9Mvyw== X-Received: by 2002:a1c:2805:: with SMTP id o5mr7861943wmo.25.1594805130724; Wed, 15 Jul 2020 02:25:30 -0700 (PDT) Received: from debian-brgl.home (lfbn-nic-1-68-20.w2-15.abo.wanadoo.fr. [2.15.159.20]) by smtp.gmail.com with ESMTPSA id v11sm12083419wmb.3.2020.07.15.02.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 02:25:30 -0700 (PDT) From: Bartosz Golaszewski To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , Greg Kroah-Hartman , Guenter Roeck , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v5 0/3] devres: provide and use devm_krealloc() Date: Wed, 15 Jul 2020 11:25:25 +0200 Message-Id: <20200715092528.8136-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Regular krealloc() obviously can't work with managed memory. This series implements devm_krealloc() and adds the first users with hope that this helper will be adopted by other drivers currently using non-managed krealloc(). Some additional changes to the code modified by main patches are included. v1 -> v2: - remove leftover call to hwmon_device_unregister() from pmbus_core.c - add a patch extending devm_kmalloc() to handle zero size case - use WARN_ON() instead of WARN_ONCE() in devm_krealloc() when passed a pointer to non-managed memory - correctly handle the case when devm_krealloc() is passed a pointer to memory in .rodata (potentially returned by devm_kstrdup_const()) - correctly handle ZERO_SIZE_PTR passed as the ptr argument in devm_krealloc() v2 -> v3: - drop already applied patches - collect Acks - add an additional user in iio v3 -> v4: - add the kerneldoc for devm_krealloc() - WARN() outside of spinlock - rename local variable v4 -> v5: - tweak the kerneldoc Bartosz Golaszewski (3): devres: provide devm_krealloc() hwmon: pmbus: use more devres helpers iio: adc: xilinx-xadc: use devm_krealloc() .../driver-api/driver-model/devres.rst | 1 + drivers/base/devres.c | 68 +++++++++++++++++++ drivers/hwmon/pmbus/pmbus_core.c | 28 +++----- drivers/iio/adc/xilinx-xadc-core.c | 16 ++--- include/linux/device.h | 2 + 5 files changed, 88 insertions(+), 27 deletions(-) -- 2.26.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71597C433E2 for ; Wed, 15 Jul 2020 09:26:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FCA9206E9 for ; Wed, 15 Jul 2020 09:26:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vVekPShi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="S/n86HB0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FCA9206E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=I85yIF/AkJ1RfMW8m3xuFlFfY2EzXLShIwKvbfXz47Y=; b=vVekPShiHu/a2DvrV8H9fSBgUI 9zHLKwvMrbNOvvZZufWmKRRDPfvvTvOIauPn150ymuaOf5hIL3HM1pNIm7kVvyllBmYVeUSr7f1RU dHI+6tdt6wrKTxIOdPK7j05W6eJywNoJCL+lIDnxY+Gcyb4iiJXM5rEEExZll875Z9Sg6rL4eQPym vBO81wKbvG1CstfVxcJUPDJ/n69cL/IsgLCwbHwV3mvCwe5HBICltn/9TWmu6Uc/hlG57FZLubkLm vyP9zBNukGQ13knycWWv6afse/QKH47YdLRJW/aMQ14c3BGYVrmjImZ44kOVIcmU194Hs5TfP9+25 s3FLCetA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvdfT-0001qo-Fr; Wed, 15 Jul 2020 09:25:35 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvdfQ-0001pI-LR for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 09:25:33 +0000 Received: by mail-wm1-x341.google.com with SMTP id l2so4874627wmf.0 for ; Wed, 15 Jul 2020 02:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BxEQuTmqko+pgzijDd2lGbDRaEjjMMNtGU3cvLEaE6E=; b=S/n86HB008axGB6WKz9m+NdU+bqcERxKeXWGb+MQoYnuj23/rvTNA/HzyJOsXElTUa kMBNN09IM8T7a410mbjPH9IrXuuq340M4y9PK7byTyrJZwHUOHbvhm7AcYY/eX7etFel PKOEE2Wvi3JJ4qp+02qOQoiegkfD09R+TPpAE6T9dQRDlJ4ur15/kQcEXisqt5SV0+FP g1INpsSjpPPU24d3RlzcCgeZRT2zHFjOo7M9e3gyMNpFQxGUEWqVc+AfDmhQCsXvGSb6 M1/x90AKy+XbFF5iozX5hX48gucEuA3aZypkMMHdbHnDxOnOPyH4JuSphmOgqZyH6kXn JOVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BxEQuTmqko+pgzijDd2lGbDRaEjjMMNtGU3cvLEaE6E=; b=Ab3Azu09hm3ptG/gdZ9w6KLUZULioe2/8cUDYVlagQn5Aw1DQtmdy52tIVg/e+KZN+ DNqpdrWgWgYMen8/7HPPgk41xnCH7ueXq/LtrCcNerLOkd/TJDkS16+kQWeoRgIsg1fL c6T4FPN+nQdsPrjw5zFR3tOgOn1Zrzzn8gdeA37RZi3HgGb/ngpbMLLrQOAxGM+KK2q3 BIhQfGj6tDnCRGikkC9JcwWUNNvZlJ7t4iBou0PHGOqgXtOtpDRCt+fWYtBbMtVXyoc+ aYP34vBX8z+4zIDEE1GhFFKKCl2dYJI2Woskjy10NlU5XKPrlNQGoWRHoAjlKtL0T7BD wJ+w== X-Gm-Message-State: AOAM530TtaO6K5knufoLV7T2A8el/LHhQWVDSri3l9WlczIMyudWXquF 9mWbmNF0tVHE5I6axkXyFUK3Vg== X-Google-Smtp-Source: ABdhPJyommb1Qc2v2rVIuSC6qsOykeoBwgjcpJYFj8Qs7T2/nah5bDGTDtY6INNmZRnI240Jm9Mvyw== X-Received: by 2002:a1c:2805:: with SMTP id o5mr7861943wmo.25.1594805130724; Wed, 15 Jul 2020 02:25:30 -0700 (PDT) Received: from debian-brgl.home (lfbn-nic-1-68-20.w2-15.abo.wanadoo.fr. [2.15.159.20]) by smtp.gmail.com with ESMTPSA id v11sm12083419wmb.3.2020.07.15.02.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 02:25:30 -0700 (PDT) From: Bartosz Golaszewski To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , Greg Kroah-Hartman , Guenter Roeck , Andy Shevchenko Subject: [PATCH v5 0/3] devres: provide and use devm_krealloc() Date: Wed, 15 Jul 2020 11:25:25 +0200 Message-Id: <20200715092528.8136-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_052532_862419_719176E3 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Regular krealloc() obviously can't work with managed memory. This series implements devm_krealloc() and adds the first users with hope that this helper will be adopted by other drivers currently using non-managed krealloc(). Some additional changes to the code modified by main patches are included. v1 -> v2: - remove leftover call to hwmon_device_unregister() from pmbus_core.c - add a patch extending devm_kmalloc() to handle zero size case - use WARN_ON() instead of WARN_ONCE() in devm_krealloc() when passed a pointer to non-managed memory - correctly handle the case when devm_krealloc() is passed a pointer to memory in .rodata (potentially returned by devm_kstrdup_const()) - correctly handle ZERO_SIZE_PTR passed as the ptr argument in devm_krealloc() v2 -> v3: - drop already applied patches - collect Acks - add an additional user in iio v3 -> v4: - add the kerneldoc for devm_krealloc() - WARN() outside of spinlock - rename local variable v4 -> v5: - tweak the kerneldoc Bartosz Golaszewski (3): devres: provide devm_krealloc() hwmon: pmbus: use more devres helpers iio: adc: xilinx-xadc: use devm_krealloc() .../driver-api/driver-model/devres.rst | 1 + drivers/base/devres.c | 68 +++++++++++++++++++ drivers/hwmon/pmbus/pmbus_core.c | 28 +++----- drivers/iio/adc/xilinx-xadc-core.c | 16 ++--- include/linux/device.h | 2 + 5 files changed, 88 insertions(+), 27 deletions(-) -- 2.26.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel