From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0B9C433DF for ; Wed, 15 Jul 2020 14:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 222A320658 for ; Wed, 15 Jul 2020 14:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbgGOOBU (ORCPT ); Wed, 15 Jul 2020 10:01:20 -0400 Received: from mga05.intel.com ([192.55.52.43]:50178 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727822AbgGOOBS (ORCPT ); Wed, 15 Jul 2020 10:01:18 -0400 IronPort-SDR: f8mIuQ3zlJsunFyVvSTYx1HNuRVAGFFOKN6JdPAb17X3j/Uxcyi5N+2zZjqhRb7z+mGvp4NhlK GA5HqIqoOV4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="234003443" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="234003443" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:01:17 -0700 IronPort-SDR: XTvig8Hd6pw0Bo7G119IyDJj+QXn1cnffd/pxIxXx+gbid/YfxmBBFzvlQpZmz86ETvvZgj+Z/ NhRyipSUFpYg== X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="390787625" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:01:12 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id E01242091F; Wed, 15 Jul 2020 17:01:10 +0300 (EEST) Date: Wed, 15 Jul 2020 17:01:10 +0300 From: Sakari Ailus To: Dongchun Zhu Cc: Tomasz Figa , Linus Walleij , Bartosz Golaszewski , Mauro Carvalho Chehab , Andy Shevchenko , Rob Herring , Mark Rutland , Nicolas Boichat , matrix.zhu@aliyun.com, Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= Subject: Re: [V7, 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20200715140110.GD16711@paasikivi.fi.intel.com> References: <20200505070451.GS9190@paasikivi.fi.intel.com> <1588688238.8804.150.camel@mhfsdcap03> <20200506112136.GV9190@paasikivi.fi.intel.com> <1588856325.8804.179.camel@mhfsdcap03> <20200507141147.GF9190@paasikivi.fi.intel.com> <1588920685.8804.230.camel@mhfsdcap03> <20200510223552.GA11272@paasikivi.fi.intel.com> <1589197265.8804.262.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589197265.8804.262.camel@mhfsdcap03> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org hi Dongchun, On Mon, May 11, 2020 at 07:41:05PM +0800, Dongchun Zhu wrote: > Hi Sakari, > > On Mon, 2020-05-11 at 01:35 +0300, Sakari Ailus wrote: > > Hi Dongchun, > > > > On Fri, May 08, 2020 at 02:51:25PM +0800, Dongchun Zhu wrote: > > > Hi Sakari, Tomasz, > > > > > > On Thu, 2020-05-07 at 16:25 +0200, Tomasz Figa wrote: > > > > On Thu, May 7, 2020 at 4:12 PM Sakari Ailus > > > > wrote: > > > > > > > > > > Hi Tomasz, Dongchun, > > > > > > > > > > On Thu, May 07, 2020 at 03:50:40PM +0200, Tomasz Figa wrote: > > > > > > Hi Sakari and Dongchun, > > > > > > > > > > > > On Thu, May 7, 2020 at 3:00 PM Dongchun Zhu wrote: > > > > > > > > > > > > > > Hi Sakari, > > > > > > > > > > > > > > Thanks for the review. > > > > > > > > > > > > > > On Wed, 2020-05-06 at 14:21 +0300, Sakari Ailus wrote: > > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > > > On Tue, May 05, 2020 at 10:17:18PM +0800, Dongchun Zhu wrote: > > > > > > > > > Hi Sakari, > > > > > > > > > > > > > > > > > > Thanks for the review. > > > > > > > > > > > > > > > > > > On Tue, 2020-05-05 at 10:04 +0300, Sakari Ailus wrote: > > > > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > > > > > > > On Thu, Apr 30, 2020 at 04:09:23PM +0800, Dongchun Zhu wrote: > > > > > > > > > > > Add DT bindings documentation for Omnivision OV02A10 image sensor. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > > > > > > > --- > > > > > > > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 148 +++++++++++++++++++++ > > > > > > > > > > > MAINTAINERS | 7 + > > > > > > > > > > > 2 files changed, 155 insertions(+) > > > > > > > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > new file mode 100644 > > > > > > > > > > > index 0000000..2be4bd2 > > > > > > > > > > > --- /dev/null > > > > > > > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > @@ -0,0 +1,148 @@ > > > > > > > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > > > > > > > +# Copyright (c) 2020 MediaTek Inc. > > > > > > > > > > > +%YAML 1.2 > > > > > > > > > > > +--- > > > > > > > > > > > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02a10.yaml# > > > > > > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > > > > > > + > > > > > > > > > > > +title: Omnivision OV02A10 CMOS Sensor Device Tree Bindings > > > > > > > > > > > + > > > > > > > > > > > +maintainers: > > > > > > > > > > > + - Dongchun Zhu > > > > > > > > > > > + > > > > > > > > > > > +description: |- > > > > > > > > > > > + The Omnivision OV02A10 is a low-cost, high performance, 1/5-inch, 2 megapixel > > > > > > > > > > > + image sensor, which is the latest production derived from Omnivision's CMOS > > > > > > > > > > > + image sensor technology. Ihis chip supports high frame rate speeds up to 30fps > > > > > > > > > > > + @ 1600x1200 (UXGA) resolution transferred over a 1-lane MIPI interface. The > > > > > > > > > > > + sensor output is available via CSI-2 serial data output. > > > > > > > > > > > + > > > > > > > > > > > +properties: > > > > > > > > > > > + compatible: > > > > > > > > > > > + const: ovti,ov02a10 > > > > > > > > > > > + > > > > > > > > > > > + reg: > > > > > > > > > > > + maxItems: 1 > > > > > > > > > > > + > > > > > > > > > > > + clocks: > > > > > > > > > > > + items: > > > > > > > > > > > + - description: top mux camtg clock > > > > > > > > > > > + - description: devider clock > > > > > > > > > > > + > > > > > > > > > > > + clock-names: > > > > > > > > > > > + items: > > > > > > > > > > > + - const: eclk > > > > > > > > > > > + - const: freq_mux > > > > > > > > > > > + > > > > > > > > > > > + clock-frequency: > > > > > > > > > > > + description: > > > > > > > > > > > + Frequency of the eclk clock in Hertz. > > > > > > > > > > > + > > > > > > > > > > > + dovdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as interface power supply. > > > > > > > > > > > + > > > > > > > > > > > + avdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as analog power supply. > > > > > > > > > > > + > > > > > > > > > > > + dvdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as digital power supply. > > > > > > > > > > > + > > > > > > > > > > > + powerdown-gpios: > > > > > > > > > > > + description: > > > > > > > > > > > + The phandle and specifier for the GPIO that controls sensor powerdown. > > > > > > > > > > > + > > > > > > > > > > > + reset-gpios: > > > > > > > > > > > + description: > > > > > > > > > > > + The phandle and specifier for the GPIO that controls sensor reset. > > > > > > > > > > > + > > > > > > > > > > > + rotation: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the sensor's placement, valid values are 0 and 180. > > > > > > > > > > > + allOf: > > > > > > > > > > > + - $ref: "/schemas/types.yaml#/definitions/uint32" > > > > > > > > > > > + - enum: > > > > > > > > > > > + - 0 # Sensor Mounted Upright > > > > > > > > > > > + - 180 # Sensor Mounted Upside Down > > > > > > > > > > > + > > > > > > > > > > > + ovti,mipi-tx-speed: > > > > > > > > > > > + description: > > > > > > > > > > > + Indication of MIPI transmission speed select. > > > > > > > > > > > > > > > > > > > > What exactly does this signify? And how do you come up with the number? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Apologies for not addressing this number clear. > > > > > > > > > > > > > > > > > > From the datasheet, P1:0xA1 register represents TX_SPEED_AREA_SEL with > > > > > > > > > the default val: 0x03. > > > > > > > > > The description of this RW register is as below: > > > > > > > > > Bit[2:0]: MIPI transmission speed select. > > > > > > > > > > > > > > > > > > Thus the enum should be definited as [ 0, 1, 2, 3, 4, 5, 6, 7 ]. > > > > > > > > > This would be fixed in next release. > > > > > > > > > > > > > > > > > > In the meantime, as the default val of P1:0xA1 is 0x03, we hope to keep > > > > > > > > > that value if there is no setting for this private property in DT. > > > > > > > > > The caller in driver would be updated like this in next release. > > > > > > > > > if (ov02a10->mipi_clock_tx_speed) > > > > > > > > > ret = i2c_smbus_write_byte_data(...,...); > > > > > > > > > > > > > > > > How did you pick the value in the example? And why do you believe it is > > > > > > > > specific to a platform, and not e.g. a sensor mode? > > > > > > > > > > > > > > > > > > > > > > We look into P1:0XA1, one register that defines MIPI transmission speed > > > > > > > select. > > > > > > > From the datasheet, we can get the possible values that could be set to > > > > > > > P1:0xA1. > > > > > > > > > > > > > > Actually this register is an independent of sensor mode, it is just > > > > > > > included in sensor mode's register setting table. > > > > > > > > > > > > > > In addition, this private DT Property is created to fix the MIPI test > > > > > > > failure. The register values are adjusted and verified from vendor to > > > > > > > make sensor signal meet MIPI specification. > > > > > > > > > > > > > > > > > > > In theory the value could depend on the mode, because different link > > > > > > rate could impose different requirements for the physical interface. > > > > > > In practice, we haven't seen any hardware that would require different > > > > > > values for different modes. > > > > > > > > > > The mode (possibly in conjunction with other information available to the > > > > > driver via V4L2 fwnode interface) precisely defines the parameters of the > > > > > CSI-2 bus --- apart from the possible exception of the bus timing related > > > > > parameters but this is not supported by the name of the parameter. > > > > > > > > > > Therefore I don't see how this parameter, which supposedly is used to > > > > > determine the CSI-2 transmissions speed, could be board specific and thus > > > > > belong to DT. > > > > > > > > According to the very imprecise information I have access to, it is > > > > not about the CSI-2 bus itself, but rather some internal parameter of > > > > the sensor's CSI interface. Unfortunately there isn't much information > > > > on what this value exactly controls... > > > > > > > > Best regards, > > > > Tomasz > > > > > > Just got some feedback from OV vendor about this parameter. > > > > > > P1:0xA1 is the register to control D-PHY timing setting based on bclk. > > > It is to adjust the MIPI clock voltage to improve the clock drive > > > capability, and has no affect on the transmission speed of MIPI data. > > > > > > From vendor's perspective, P1:0xA1 depends upon the length of FPC of > > > camera module that used on the board. Considering the physical > > > connections for MIPI signals to user-facing camera are very different > > > between our 2 projects, it can be very difficult to find universal SI > > > parameters for both projects. > > > > Are you using different values for this parameter on these two projects? > > > > Yes. We're actually assigning two different values to this property. > One is 0x03, the other is 0x04. > > > > > > > Thus here we create one new DT property to separate these tuning in > > > driver, to be more like project-specific. > > > > > > More details about the register is as below. > > > P1:0xA1 val: 0x03 default > > > Case: 0 20MHz-30MHz > > > 1 30MHz-50MHz > > > 2 50MHz-75MHz > > > 3 75MHz-100MHz (default, old DB setting use) > > > 4 100MHz-130MHz (suggested, new DB setting use) > > > 5 Manual > > > So the value in the example should be [ 0, 1, 2, 3, 4, 5 ]. > > > > > > Additionally, P1:0xA1 is recommended to be set as 0x04 in the newest DB > > > setting. We would adjust the register in next release. > > > > Thank you for digging into the issue. > > > > Based on the above description, the parameter would depend on both the link > > frequency and possibly also on wire length. I guess there's no harm from > > using too strong drive, apart from perhaps power consumption? As in > > principle this could be different for different sensor modes. Albeit I > > don't remember seeing a sensor where such a parameter would have been > > needed to be modified. > > > > This may be related to something about sensor fine tuning. > As OV vendor pointed out, the sensor chip provides such one property > that user could adjust based on their specific project. > Also, case 4 (0x04) setting is confirmed to have a little more power > consumption than case 3 (0x03). Apologies for bringing back an old topic --- the driver supports just a single mode, using a specific data rate. If another mode is added later on, will it continue to use the same value for this? Based on the documentation, it seems that this is primarily defined by the frequency of the bus, not by board design. Therefore putting this to DT (and thus ignoring the frequency) appears wrong. -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBDE4C433E1 for ; Wed, 15 Jul 2020 14:01:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70A9720658 for ; Wed, 15 Jul 2020 14:01:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lK3EL5TD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A9720658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aeeaD/5Rtz6OJXjbrts7mTzsKaXUNomJGZd5qoj27hk=; b=lK3EL5TDRidNPS4DflZOpWGDC WKozokySgctdjs3b5iux8bbFS7XLgcr7Avfa6FI50jvd/bBDbZXY0YANu7JQsTtK858G/FSOYcP7b xJ3y1GOKuS+l7U0k3C8rcKb+TYG4Ydq9djxVUIlT8kpVJPvqARJW1fHX94twNsxpYunDurKBTxbQu ZuV4f3jYUrm42bsXwYQveqaAQ5MGulcDLZQjXL40+IMO5+ScCF96i58yq0yBzDas8LU/jxJI3Skd4 7K9EzoOiJST+enHAmoTPzxsadZXjB9lgbFWG5EMhWbyVrXiGwYj4fZgEbL9dGX70DJGDT7+cRBTYh KzbrKpz6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvhyQ-0006vl-In; Wed, 15 Jul 2020 14:01:26 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvhyL-0006tV-E7; Wed, 15 Jul 2020 14:01:23 +0000 IronPort-SDR: Xyt7QWicYTValwqVxqQXzCYO8WZmVB0vQ9waaje5wVw/qZte44Kl4R6PN7og0yDiA7neRI+Dwa pn+x8+NIOtdg== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="137274872" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="137274872" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:01:17 -0700 IronPort-SDR: XTvig8Hd6pw0Bo7G119IyDJj+QXn1cnffd/pxIxXx+gbid/YfxmBBFzvlQpZmz86ETvvZgj+Z/ NhRyipSUFpYg== X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="390787625" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:01:12 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id E01242091F; Wed, 15 Jul 2020 17:01:10 +0300 (EEST) Date: Wed, 15 Jul 2020 17:01:10 +0300 From: Sakari Ailus To: Dongchun Zhu Subject: Re: [V7, 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20200715140110.GD16711@paasikivi.fi.intel.com> References: <20200505070451.GS9190@paasikivi.fi.intel.com> <1588688238.8804.150.camel@mhfsdcap03> <20200506112136.GV9190@paasikivi.fi.intel.com> <1588856325.8804.179.camel@mhfsdcap03> <20200507141147.GF9190@paasikivi.fi.intel.com> <1588920685.8804.230.camel@mhfsdcap03> <20200510223552.GA11272@paasikivi.fi.intel.com> <1589197265.8804.262.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1589197265.8804.262.camel@mhfsdcap03> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_100121_727116_85875E9D X-CRM114-Status: GOOD ( 57.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= , Tomasz Figa , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Louis Kuo , Matthias Brugger , Cao Bing Bu , matrix.zhu@aliyun.com, Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org hi Dongchun, On Mon, May 11, 2020 at 07:41:05PM +0800, Dongchun Zhu wrote: > Hi Sakari, > > On Mon, 2020-05-11 at 01:35 +0300, Sakari Ailus wrote: > > Hi Dongchun, > > > > On Fri, May 08, 2020 at 02:51:25PM +0800, Dongchun Zhu wrote: > > > Hi Sakari, Tomasz, > > > > > > On Thu, 2020-05-07 at 16:25 +0200, Tomasz Figa wrote: > > > > On Thu, May 7, 2020 at 4:12 PM Sakari Ailus > > > > wrote: > > > > > > > > > > Hi Tomasz, Dongchun, > > > > > > > > > > On Thu, May 07, 2020 at 03:50:40PM +0200, Tomasz Figa wrote: > > > > > > Hi Sakari and Dongchun, > > > > > > > > > > > > On Thu, May 7, 2020 at 3:00 PM Dongchun Zhu wrote: > > > > > > > > > > > > > > Hi Sakari, > > > > > > > > > > > > > > Thanks for the review. > > > > > > > > > > > > > > On Wed, 2020-05-06 at 14:21 +0300, Sakari Ailus wrote: > > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > > > On Tue, May 05, 2020 at 10:17:18PM +0800, Dongchun Zhu wrote: > > > > > > > > > Hi Sakari, > > > > > > > > > > > > > > > > > > Thanks for the review. > > > > > > > > > > > > > > > > > > On Tue, 2020-05-05 at 10:04 +0300, Sakari Ailus wrote: > > > > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > > > > > > > On Thu, Apr 30, 2020 at 04:09:23PM +0800, Dongchun Zhu wrote: > > > > > > > > > > > Add DT bindings documentation for Omnivision OV02A10 image sensor. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > > > > > > > --- > > > > > > > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 148 +++++++++++++++++++++ > > > > > > > > > > > MAINTAINERS | 7 + > > > > > > > > > > > 2 files changed, 155 insertions(+) > > > > > > > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > new file mode 100644 > > > > > > > > > > > index 0000000..2be4bd2 > > > > > > > > > > > --- /dev/null > > > > > > > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > @@ -0,0 +1,148 @@ > > > > > > > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > > > > > > > +# Copyright (c) 2020 MediaTek Inc. > > > > > > > > > > > +%YAML 1.2 > > > > > > > > > > > +--- > > > > > > > > > > > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02a10.yaml# > > > > > > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > > > > > > + > > > > > > > > > > > +title: Omnivision OV02A10 CMOS Sensor Device Tree Bindings > > > > > > > > > > > + > > > > > > > > > > > +maintainers: > > > > > > > > > > > + - Dongchun Zhu > > > > > > > > > > > + > > > > > > > > > > > +description: |- > > > > > > > > > > > + The Omnivision OV02A10 is a low-cost, high performance, 1/5-inch, 2 megapixel > > > > > > > > > > > + image sensor, which is the latest production derived from Omnivision's CMOS > > > > > > > > > > > + image sensor technology. Ihis chip supports high frame rate speeds up to 30fps > > > > > > > > > > > + @ 1600x1200 (UXGA) resolution transferred over a 1-lane MIPI interface. The > > > > > > > > > > > + sensor output is available via CSI-2 serial data output. > > > > > > > > > > > + > > > > > > > > > > > +properties: > > > > > > > > > > > + compatible: > > > > > > > > > > > + const: ovti,ov02a10 > > > > > > > > > > > + > > > > > > > > > > > + reg: > > > > > > > > > > > + maxItems: 1 > > > > > > > > > > > + > > > > > > > > > > > + clocks: > > > > > > > > > > > + items: > > > > > > > > > > > + - description: top mux camtg clock > > > > > > > > > > > + - description: devider clock > > > > > > > > > > > + > > > > > > > > > > > + clock-names: > > > > > > > > > > > + items: > > > > > > > > > > > + - const: eclk > > > > > > > > > > > + - const: freq_mux > > > > > > > > > > > + > > > > > > > > > > > + clock-frequency: > > > > > > > > > > > + description: > > > > > > > > > > > + Frequency of the eclk clock in Hertz. > > > > > > > > > > > + > > > > > > > > > > > + dovdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as interface power supply. > > > > > > > > > > > + > > > > > > > > > > > + avdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as analog power supply. > > > > > > > > > > > + > > > > > > > > > > > + dvdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as digital power supply. > > > > > > > > > > > + > > > > > > > > > > > + powerdown-gpios: > > > > > > > > > > > + description: > > > > > > > > > > > + The phandle and specifier for the GPIO that controls sensor powerdown. > > > > > > > > > > > + > > > > > > > > > > > + reset-gpios: > > > > > > > > > > > + description: > > > > > > > > > > > + The phandle and specifier for the GPIO that controls sensor reset. > > > > > > > > > > > + > > > > > > > > > > > + rotation: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the sensor's placement, valid values are 0 and 180. > > > > > > > > > > > + allOf: > > > > > > > > > > > + - $ref: "/schemas/types.yaml#/definitions/uint32" > > > > > > > > > > > + - enum: > > > > > > > > > > > + - 0 # Sensor Mounted Upright > > > > > > > > > > > + - 180 # Sensor Mounted Upside Down > > > > > > > > > > > + > > > > > > > > > > > + ovti,mipi-tx-speed: > > > > > > > > > > > + description: > > > > > > > > > > > + Indication of MIPI transmission speed select. > > > > > > > > > > > > > > > > > > > > What exactly does this signify? And how do you come up with the number? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Apologies for not addressing this number clear. > > > > > > > > > > > > > > > > > > From the datasheet, P1:0xA1 register represents TX_SPEED_AREA_SEL with > > > > > > > > > the default val: 0x03. > > > > > > > > > The description of this RW register is as below: > > > > > > > > > Bit[2:0]: MIPI transmission speed select. > > > > > > > > > > > > > > > > > > Thus the enum should be definited as [ 0, 1, 2, 3, 4, 5, 6, 7 ]. > > > > > > > > > This would be fixed in next release. > > > > > > > > > > > > > > > > > > In the meantime, as the default val of P1:0xA1 is 0x03, we hope to keep > > > > > > > > > that value if there is no setting for this private property in DT. > > > > > > > > > The caller in driver would be updated like this in next release. > > > > > > > > > if (ov02a10->mipi_clock_tx_speed) > > > > > > > > > ret = i2c_smbus_write_byte_data(...,...); > > > > > > > > > > > > > > > > How did you pick the value in the example? And why do you believe it is > > > > > > > > specific to a platform, and not e.g. a sensor mode? > > > > > > > > > > > > > > > > > > > > > > We look into P1:0XA1, one register that defines MIPI transmission speed > > > > > > > select. > > > > > > > From the datasheet, we can get the possible values that could be set to > > > > > > > P1:0xA1. > > > > > > > > > > > > > > Actually this register is an independent of sensor mode, it is just > > > > > > > included in sensor mode's register setting table. > > > > > > > > > > > > > > In addition, this private DT Property is created to fix the MIPI test > > > > > > > failure. The register values are adjusted and verified from vendor to > > > > > > > make sensor signal meet MIPI specification. > > > > > > > > > > > > > > > > > > > In theory the value could depend on the mode, because different link > > > > > > rate could impose different requirements for the physical interface. > > > > > > In practice, we haven't seen any hardware that would require different > > > > > > values for different modes. > > > > > > > > > > The mode (possibly in conjunction with other information available to the > > > > > driver via V4L2 fwnode interface) precisely defines the parameters of the > > > > > CSI-2 bus --- apart from the possible exception of the bus timing related > > > > > parameters but this is not supported by the name of the parameter. > > > > > > > > > > Therefore I don't see how this parameter, which supposedly is used to > > > > > determine the CSI-2 transmissions speed, could be board specific and thus > > > > > belong to DT. > > > > > > > > According to the very imprecise information I have access to, it is > > > > not about the CSI-2 bus itself, but rather some internal parameter of > > > > the sensor's CSI interface. Unfortunately there isn't much information > > > > on what this value exactly controls... > > > > > > > > Best regards, > > > > Tomasz > > > > > > Just got some feedback from OV vendor about this parameter. > > > > > > P1:0xA1 is the register to control D-PHY timing setting based on bclk. > > > It is to adjust the MIPI clock voltage to improve the clock drive > > > capability, and has no affect on the transmission speed of MIPI data. > > > > > > From vendor's perspective, P1:0xA1 depends upon the length of FPC of > > > camera module that used on the board. Considering the physical > > > connections for MIPI signals to user-facing camera are very different > > > between our 2 projects, it can be very difficult to find universal SI > > > parameters for both projects. > > > > Are you using different values for this parameter on these two projects? > > > > Yes. We're actually assigning two different values to this property. > One is 0x03, the other is 0x04. > > > > > > > Thus here we create one new DT property to separate these tuning in > > > driver, to be more like project-specific. > > > > > > More details about the register is as below. > > > P1:0xA1 val: 0x03 default > > > Case: 0 20MHz-30MHz > > > 1 30MHz-50MHz > > > 2 50MHz-75MHz > > > 3 75MHz-100MHz (default, old DB setting use) > > > 4 100MHz-130MHz (suggested, new DB setting use) > > > 5 Manual > > > So the value in the example should be [ 0, 1, 2, 3, 4, 5 ]. > > > > > > Additionally, P1:0xA1 is recommended to be set as 0x04 in the newest DB > > > setting. We would adjust the register in next release. > > > > Thank you for digging into the issue. > > > > Based on the above description, the parameter would depend on both the link > > frequency and possibly also on wire length. I guess there's no harm from > > using too strong drive, apart from perhaps power consumption? As in > > principle this could be different for different sensor modes. Albeit I > > don't remember seeing a sensor where such a parameter would have been > > needed to be modified. > > > > This may be related to something about sensor fine tuning. > As OV vendor pointed out, the sensor chip provides such one property > that user could adjust based on their specific project. > Also, case 4 (0x04) setting is confirmed to have a little more power > consumption than case 3 (0x03). Apologies for bringing back an old topic --- the driver supports just a single mode, using a specific data rate. If another mode is added later on, will it continue to use the same value for this? Based on the documentation, it seems that this is primarily defined by the frequency of the bus, not by board design. Therefore putting this to DT (and thus ignoring the frequency) appears wrong. -- Kind regards, Sakari Ailus _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C484C433E0 for ; Wed, 15 Jul 2020 14:02:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFD8A20658 for ; Wed, 15 Jul 2020 14:02:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vy7EPWvC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFD8A20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8+DpdKocX708XhM+2zImMOB0bS7ayxdNgx4zPt5MM64=; b=vy7EPWvCOt6HiyF4RAWAnzn/w xj+/H17fAsMqGoqNxwa7mmgcsDKOvK+Sh1sis0JL2wjdQjFvzS1V+SHF9IedTwik0gNSoDvFDYaja uow9f8dJgkeCqUsElPO6MPzMS/1fzYliBYM5Az2bUL3SunFaP50abVN5umrpu0t3ROh+/ICLmGtpM T1rX4drqHQGxvwFA64rkn9oFW1ZM2da2awu1SoiToW5OTXIrspbGI7L+HBu7pe8LD1+7Z9NTI+2aa gFU6Am5PAc4rfURWQVUV8PFaauR2s7OGZERSTHeR+bCrQDefBoajzkCWAlTIbxfF7g1nMZZYnd9NR foHY5U0rA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvhyO-0006vK-OJ; Wed, 15 Jul 2020 14:01:24 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvhyL-0006tV-E7; Wed, 15 Jul 2020 14:01:23 +0000 IronPort-SDR: Xyt7QWicYTValwqVxqQXzCYO8WZmVB0vQ9waaje5wVw/qZte44Kl4R6PN7og0yDiA7neRI+Dwa pn+x8+NIOtdg== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="137274872" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="137274872" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:01:17 -0700 IronPort-SDR: XTvig8Hd6pw0Bo7G119IyDJj+QXn1cnffd/pxIxXx+gbid/YfxmBBFzvlQpZmz86ETvvZgj+Z/ NhRyipSUFpYg== X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="390787625" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:01:12 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id E01242091F; Wed, 15 Jul 2020 17:01:10 +0300 (EEST) Date: Wed, 15 Jul 2020 17:01:10 +0300 From: Sakari Ailus To: Dongchun Zhu Subject: Re: [V7, 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20200715140110.GD16711@paasikivi.fi.intel.com> References: <20200505070451.GS9190@paasikivi.fi.intel.com> <1588688238.8804.150.camel@mhfsdcap03> <20200506112136.GV9190@paasikivi.fi.intel.com> <1588856325.8804.179.camel@mhfsdcap03> <20200507141147.GF9190@paasikivi.fi.intel.com> <1588920685.8804.230.camel@mhfsdcap03> <20200510223552.GA11272@paasikivi.fi.intel.com> <1589197265.8804.262.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1589197265.8804.262.camel@mhfsdcap03> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_100121_727116_85875E9D X-CRM114-Status: GOOD ( 57.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= , Tomasz Figa , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Louis Kuo , Matthias Brugger , Cao Bing Bu , matrix.zhu@aliyun.com, Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org hi Dongchun, On Mon, May 11, 2020 at 07:41:05PM +0800, Dongchun Zhu wrote: > Hi Sakari, > > On Mon, 2020-05-11 at 01:35 +0300, Sakari Ailus wrote: > > Hi Dongchun, > > > > On Fri, May 08, 2020 at 02:51:25PM +0800, Dongchun Zhu wrote: > > > Hi Sakari, Tomasz, > > > > > > On Thu, 2020-05-07 at 16:25 +0200, Tomasz Figa wrote: > > > > On Thu, May 7, 2020 at 4:12 PM Sakari Ailus > > > > wrote: > > > > > > > > > > Hi Tomasz, Dongchun, > > > > > > > > > > On Thu, May 07, 2020 at 03:50:40PM +0200, Tomasz Figa wrote: > > > > > > Hi Sakari and Dongchun, > > > > > > > > > > > > On Thu, May 7, 2020 at 3:00 PM Dongchun Zhu wrote: > > > > > > > > > > > > > > Hi Sakari, > > > > > > > > > > > > > > Thanks for the review. > > > > > > > > > > > > > > On Wed, 2020-05-06 at 14:21 +0300, Sakari Ailus wrote: > > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > > > On Tue, May 05, 2020 at 10:17:18PM +0800, Dongchun Zhu wrote: > > > > > > > > > Hi Sakari, > > > > > > > > > > > > > > > > > > Thanks for the review. > > > > > > > > > > > > > > > > > > On Tue, 2020-05-05 at 10:04 +0300, Sakari Ailus wrote: > > > > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > > > > > > > On Thu, Apr 30, 2020 at 04:09:23PM +0800, Dongchun Zhu wrote: > > > > > > > > > > > Add DT bindings documentation for Omnivision OV02A10 image sensor. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > > > > > > > --- > > > > > > > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 148 +++++++++++++++++++++ > > > > > > > > > > > MAINTAINERS | 7 + > > > > > > > > > > > 2 files changed, 155 insertions(+) > > > > > > > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > new file mode 100644 > > > > > > > > > > > index 0000000..2be4bd2 > > > > > > > > > > > --- /dev/null > > > > > > > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > @@ -0,0 +1,148 @@ > > > > > > > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > > > > > > > +# Copyright (c) 2020 MediaTek Inc. > > > > > > > > > > > +%YAML 1.2 > > > > > > > > > > > +--- > > > > > > > > > > > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02a10.yaml# > > > > > > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > > > > > > + > > > > > > > > > > > +title: Omnivision OV02A10 CMOS Sensor Device Tree Bindings > > > > > > > > > > > + > > > > > > > > > > > +maintainers: > > > > > > > > > > > + - Dongchun Zhu > > > > > > > > > > > + > > > > > > > > > > > +description: |- > > > > > > > > > > > + The Omnivision OV02A10 is a low-cost, high performance, 1/5-inch, 2 megapixel > > > > > > > > > > > + image sensor, which is the latest production derived from Omnivision's CMOS > > > > > > > > > > > + image sensor technology. Ihis chip supports high frame rate speeds up to 30fps > > > > > > > > > > > + @ 1600x1200 (UXGA) resolution transferred over a 1-lane MIPI interface. The > > > > > > > > > > > + sensor output is available via CSI-2 serial data output. > > > > > > > > > > > + > > > > > > > > > > > +properties: > > > > > > > > > > > + compatible: > > > > > > > > > > > + const: ovti,ov02a10 > > > > > > > > > > > + > > > > > > > > > > > + reg: > > > > > > > > > > > + maxItems: 1 > > > > > > > > > > > + > > > > > > > > > > > + clocks: > > > > > > > > > > > + items: > > > > > > > > > > > + - description: top mux camtg clock > > > > > > > > > > > + - description: devider clock > > > > > > > > > > > + > > > > > > > > > > > + clock-names: > > > > > > > > > > > + items: > > > > > > > > > > > + - const: eclk > > > > > > > > > > > + - const: freq_mux > > > > > > > > > > > + > > > > > > > > > > > + clock-frequency: > > > > > > > > > > > + description: > > > > > > > > > > > + Frequency of the eclk clock in Hertz. > > > > > > > > > > > + > > > > > > > > > > > + dovdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as interface power supply. > > > > > > > > > > > + > > > > > > > > > > > + avdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as analog power supply. > > > > > > > > > > > + > > > > > > > > > > > + dvdd-supply: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the regulator used as digital power supply. > > > > > > > > > > > + > > > > > > > > > > > + powerdown-gpios: > > > > > > > > > > > + description: > > > > > > > > > > > + The phandle and specifier for the GPIO that controls sensor powerdown. > > > > > > > > > > > + > > > > > > > > > > > + reset-gpios: > > > > > > > > > > > + description: > > > > > > > > > > > + The phandle and specifier for the GPIO that controls sensor reset. > > > > > > > > > > > + > > > > > > > > > > > + rotation: > > > > > > > > > > > + description: > > > > > > > > > > > + Definition of the sensor's placement, valid values are 0 and 180. > > > > > > > > > > > + allOf: > > > > > > > > > > > + - $ref: "/schemas/types.yaml#/definitions/uint32" > > > > > > > > > > > + - enum: > > > > > > > > > > > + - 0 # Sensor Mounted Upright > > > > > > > > > > > + - 180 # Sensor Mounted Upside Down > > > > > > > > > > > + > > > > > > > > > > > + ovti,mipi-tx-speed: > > > > > > > > > > > + description: > > > > > > > > > > > + Indication of MIPI transmission speed select. > > > > > > > > > > > > > > > > > > > > What exactly does this signify? And how do you come up with the number? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Apologies for not addressing this number clear. > > > > > > > > > > > > > > > > > > From the datasheet, P1:0xA1 register represents TX_SPEED_AREA_SEL with > > > > > > > > > the default val: 0x03. > > > > > > > > > The description of this RW register is as below: > > > > > > > > > Bit[2:0]: MIPI transmission speed select. > > > > > > > > > > > > > > > > > > Thus the enum should be definited as [ 0, 1, 2, 3, 4, 5, 6, 7 ]. > > > > > > > > > This would be fixed in next release. > > > > > > > > > > > > > > > > > > In the meantime, as the default val of P1:0xA1 is 0x03, we hope to keep > > > > > > > > > that value if there is no setting for this private property in DT. > > > > > > > > > The caller in driver would be updated like this in next release. > > > > > > > > > if (ov02a10->mipi_clock_tx_speed) > > > > > > > > > ret = i2c_smbus_write_byte_data(...,...); > > > > > > > > > > > > > > > > How did you pick the value in the example? And why do you believe it is > > > > > > > > specific to a platform, and not e.g. a sensor mode? > > > > > > > > > > > > > > > > > > > > > > We look into P1:0XA1, one register that defines MIPI transmission speed > > > > > > > select. > > > > > > > From the datasheet, we can get the possible values that could be set to > > > > > > > P1:0xA1. > > > > > > > > > > > > > > Actually this register is an independent of sensor mode, it is just > > > > > > > included in sensor mode's register setting table. > > > > > > > > > > > > > > In addition, this private DT Property is created to fix the MIPI test > > > > > > > failure. The register values are adjusted and verified from vendor to > > > > > > > make sensor signal meet MIPI specification. > > > > > > > > > > > > > > > > > > > In theory the value could depend on the mode, because different link > > > > > > rate could impose different requirements for the physical interface. > > > > > > In practice, we haven't seen any hardware that would require different > > > > > > values for different modes. > > > > > > > > > > The mode (possibly in conjunction with other information available to the > > > > > driver via V4L2 fwnode interface) precisely defines the parameters of the > > > > > CSI-2 bus --- apart from the possible exception of the bus timing related > > > > > parameters but this is not supported by the name of the parameter. > > > > > > > > > > Therefore I don't see how this parameter, which supposedly is used to > > > > > determine the CSI-2 transmissions speed, could be board specific and thus > > > > > belong to DT. > > > > > > > > According to the very imprecise information I have access to, it is > > > > not about the CSI-2 bus itself, but rather some internal parameter of > > > > the sensor's CSI interface. Unfortunately there isn't much information > > > > on what this value exactly controls... > > > > > > > > Best regards, > > > > Tomasz > > > > > > Just got some feedback from OV vendor about this parameter. > > > > > > P1:0xA1 is the register to control D-PHY timing setting based on bclk. > > > It is to adjust the MIPI clock voltage to improve the clock drive > > > capability, and has no affect on the transmission speed of MIPI data. > > > > > > From vendor's perspective, P1:0xA1 depends upon the length of FPC of > > > camera module that used on the board. Considering the physical > > > connections for MIPI signals to user-facing camera are very different > > > between our 2 projects, it can be very difficult to find universal SI > > > parameters for both projects. > > > > Are you using different values for this parameter on these two projects? > > > > Yes. We're actually assigning two different values to this property. > One is 0x03, the other is 0x04. > > > > > > > Thus here we create one new DT property to separate these tuning in > > > driver, to be more like project-specific. > > > > > > More details about the register is as below. > > > P1:0xA1 val: 0x03 default > > > Case: 0 20MHz-30MHz > > > 1 30MHz-50MHz > > > 2 50MHz-75MHz > > > 3 75MHz-100MHz (default, old DB setting use) > > > 4 100MHz-130MHz (suggested, new DB setting use) > > > 5 Manual > > > So the value in the example should be [ 0, 1, 2, 3, 4, 5 ]. > > > > > > Additionally, P1:0xA1 is recommended to be set as 0x04 in the newest DB > > > setting. We would adjust the register in next release. > > > > Thank you for digging into the issue. > > > > Based on the above description, the parameter would depend on both the link > > frequency and possibly also on wire length. I guess there's no harm from > > using too strong drive, apart from perhaps power consumption? As in > > principle this could be different for different sensor modes. Albeit I > > don't remember seeing a sensor where such a parameter would have been > > needed to be modified. > > > > This may be related to something about sensor fine tuning. > As OV vendor pointed out, the sensor chip provides such one property > that user could adjust based on their specific project. > Also, case 4 (0x04) setting is confirmed to have a little more power > consumption than case 3 (0x03). Apologies for bringing back an old topic --- the driver supports just a single mode, using a specific data rate. If another mode is added later on, will it continue to use the same value for this? Based on the documentation, it seems that this is primarily defined by the frequency of the bus, not by board design. Therefore putting this to DT (and thus ignoring the frequency) appears wrong. -- Kind regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel