All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Marius Zachmann <mail@mariuszachmann.de>
Cc: jaap aarts <jaap.aarts1@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] hwmon: add fan/pwm driver for corsair h100i platinum
Date: Wed, 15 Jul 2020 07:20:19 -0700	[thread overview]
Message-ID: <20200715142019.GA201840@roeck-us.net> (raw)
In-Reply-To: <2845728.4EH8KBbfVN@marius>

On Wed, Jul 15, 2020 at 02:17:37PM +0200, Marius Zachmann wrote:
> On 15.07.20 at 05:07:40 CEST, Guenter Roeck wrote
> > On Tue, Jul 14, 2020 at 12:03:38PM +0200, jaap aarts wrote:
> > > Adds fan/pwm support for H1000i platinum.
> > > Custom temp/fan curves are not supported, however
> > > the presets found in the proprietary drivers are avaiable.
> > > 
> > > Signed-off-by: Jaap Aarts <jaap.aarts1@gmail.com>
> > 
> > +Marius Zachmann for input.
> > 
> > Questions:
> > - Does this really have to be a different driver or can it be merged into
> >   the corsair-cpro driver ?
> >
> 
> From what I can see the protocol has quite a few differences.
> A merged driver would need to implement functions like e.g. set_pwm for
> each device seperately. Also error handling and buffer sizes would be
> seperate for each device.
> If there were more usb/hid drivers in hwmon it maybe could make sense
> to have an additional abstraction layer, but for now I do not see
> anything which could be gained by this.
> 
Ok.

Thanks,
Guenter

  reply	other threads:[~2020-07-15 14:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 10:03 [PATCH] hwmon: add fan/pwm driver for corsair h100i platinum jaap aarts
2020-07-14 23:01 ` kernel test robot
2020-07-14 23:01   ` kernel test robot
2020-07-15  3:07 ` Guenter Roeck
2020-07-15  8:34   ` Greg KH
2020-07-15 11:18   ` jaap aarts
2020-07-15 14:47     ` Guenter Roeck
2020-07-15 15:03       ` jaap aarts
2020-07-15 15:10         ` Guenter Roeck
2020-07-15 12:17   ` Marius Zachmann
2020-07-15 14:20     ` Guenter Roeck [this message]
2020-07-15  5:09 ` kernel test robot
2020-07-15  5:09   ` kernel test robot
2020-07-17 12:20 ` jaap aarts
2020-07-23  9:17 jaap aarts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200715142019.GA201840@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jaap.aarts1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@mariuszachmann.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.