From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE968C433E1 for ; Wed, 15 Jul 2020 18:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2DA020656 for ; Wed, 15 Jul 2020 18:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbgGOSvG (ORCPT ); Wed, 15 Jul 2020 14:51:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37398 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbgGOSvG (ORCPT ); Wed, 15 Jul 2020 14:51:06 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jvmUf-005HWy-Dr; Wed, 15 Jul 2020 20:51:01 +0200 Date: Wed, 15 Jul 2020 20:51:01 +0200 From: Andrew Lunn To: Helmut Grohne Cc: David Miller , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "kuba@kernel.org" , "netdev@vger.kernel.org" , "woojung.huh@microchip.com" , "UNGLinuxDriver@microchip.com" , "vivien.didelot@gmail.com" Subject: Re: [PATCH] net: phy: phy_remove_link_mode should not advertise new modes Message-ID: <20200715185101.GB1256692@lunn.ch> References: <20200714082540.GA31028@laureti-dev> <20200714.140710.213288407914809619.davem@davemloft.net> <20200715070345.GA3452@laureti-dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715070345.GA3452@laureti-dev> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > It also is not true that the current code ensures your assertion. > Specifically, phy_advertise_supported copies the pause bits from the old > advertised to the new one regardless of whether they're set in > supported. This is an oddity of Pause. The PHY should not sets Pause in supported, because the PHY is not the device which implements Pause. The MAC needs to indicate to PHYLIB it implements Pause, and then the PHY will advertise Pause. I will address the other points in a separate email. Andrew