From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDF04C433E8 for ; Wed, 15 Jul 2020 19:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C14882065D for ; Wed, 15 Jul 2020 19:23:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kiYOUCLw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726935AbgGOTXs (ORCPT ); Wed, 15 Jul 2020 15:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726932AbgGOTXo (ORCPT ); Wed, 15 Jul 2020 15:23:44 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E43EEC08C5DB for ; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id k4so2773577pld.12 for ; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OJ/YWMib2y0Oi9xcE3B9cmLij4uK6K7vyJCnBwYrt/0=; b=kiYOUCLw+1YMW5C/hDrCQnyOlnRtGrFPezJA04+b0b4IIM5w8VNidZnsPMPHfZ31KS LxhyDUqGX0RwzJAlBRqOfe2ODGCTv2LKEk/50WpTfn28Dp+ZBxdVxNZXkt6vym0qxK/Q rx82Fv0Ijv3kJKlDTbYSXiKFjVaIlmJguN6+3aaiaOjcY7ZTRMaa5SON4MfuTw8M/HSU v8ruKKdEd2o//mAyXMOkE3cXxzduzOyubtoH4T/VezrAKzRSY9zqMZ+YPOlllJ7ocF+k UdiLFpdNVsXZC/MUNV+4eR0KRB3FESXVCeMno3tw/kkcCifALuCf49tFeBBbwBN9AyNI Cing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OJ/YWMib2y0Oi9xcE3B9cmLij4uK6K7vyJCnBwYrt/0=; b=TkCeBRJvw169Fg2pywGL41avP9pt133+7u56wIYUIK8CfdBEsUZR3xxecXrexQUnpl 3cAeqjToXdc0FSl884T8nsTfFg6gl+KkJbpQMmKqeYe2N3r9agVW2UQFFbz28K9FxlAZ hCDiugFqgqsNex0w0uMtDdwUD9OEV99RY+TVZhhECJR9/ahuttMSx1b/A7JZS1rOPze7 nt/45dT8edm5zmHC8/21Z3kIAnrqcZNKc3pTti5CMmx+zyLp1YoT+MQwB95W4CWF33fa Zc/T+zaUx+pD1HDIq5iV13bBR4mBTT6zaYfORP8dYUweqSC2qVkIjajuaP5hr80F3t2n I6NA== X-Gm-Message-State: AOAM531NLck56OqeOwnvZKJrLLtQ1CTCYXuN6E/yIxjXWYHhX1S6G7Up 4PGzGINameg6mUHmmYC20Yypqw== X-Google-Smtp-Source: ABdhPJxxiugzYbbF1aUsgwFCaTWYsI5jJtHeJsIIOQXJcVFYwSl1wCBetM40QxEzTt5KKymF9BCfSw== X-Received: by 2002:a17:90a:ed87:: with SMTP id k7mr1208692pjy.31.1594841023280; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g6sm2829878pfr.129.2020.07.15.12.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 12:23:42 -0700 (PDT) Date: Wed, 15 Jul 2020 12:21:38 -0700 From: Bjorn Andersson To: Lee Jones Cc: ohad@wizery.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Message-ID: <20200715192138.GA2922385@builder.lan> References: <20200715123551.4011154-1-lee.jones@linaro.org> <20200715123551.4011154-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715123551.4011154-2-lee.jones@linaro.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote: > Looks as though 'name' has now been moved into 'struct sysmod_event' > which is passed in instead. However, the parameter descriptions were > not updated at the same time. Let's do that now. > > Fixes the following W=1 kernel build warning(s): > > drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event' > drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event' > drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event' > drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event' > > Cc: Andy Gross > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones Thanks Lee, both patches applied. Regards, Bjorn > --- > drivers/remoteproc/qcom_sysmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c > index 8d8996d714f07..9eb2f6bccea63 100644 > --- a/drivers/remoteproc/qcom_sysmon.c > +++ b/drivers/remoteproc/qcom_sysmon.c > @@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list); > /** > * sysmon_send_event() - send notification of other remote's SSR event > * @sysmon: sysmon context > - * @name: other remote's name > + * @event: sysmon event context > */ > static void sysmon_send_event(struct qcom_sysmon *sysmon, > const struct sysmon_event *event) > @@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon) > /** > * ssctl_send_event() - send notification of other remote's SSR event > * @sysmon: sysmon context > - * @name: other remote's name > + * @event: sysmon event context > */ > static void ssctl_send_event(struct qcom_sysmon *sysmon, > const struct sysmon_event *event) > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B37C433E5 for ; Wed, 15 Jul 2020 19:25:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79DA92065D for ; Wed, 15 Jul 2020 19:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J4UrTtv3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kiYOUCLw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79DA92065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DZZ3d/AEZp4YOYIvJh78rNA5nWeYPH3krHkOlUPFF3w=; b=J4UrTtv3zWy4Sia5TA32vU+E9 paPDCR57YLGJ4O1hBR0MP0R0Nj/0G9Z21jEDcSdN+mub8j+qvuawQpeqnxWClkTLObmpujEpiGfW1 id8pPBqc2QMHBb5JUOj8tnyH+xYJnVRcUE63qU18GsN8sgEe132i3OIbPwgBlQ25PrRzZYLflizbn HTJJ/czaIVT5ZxZqULJkybrM+XGXxTnJfkQh5B6Ad/xVD9SLHT5yxYOuyJGbgNPgwuynQzhpOm1cO BgXjiTRxk6D24vec+4fo4efSxR31Oa+fxAzu7PQrzsgWsiYcoLMXleNFBDCJnSv8bReNeNlZU7PO2 1N9/bxShg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvn0V-0002Cw-Jx; Wed, 15 Jul 2020 19:23:55 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvn0O-0002AW-7K for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 19:23:50 +0000 Received: by mail-pj1-x1043.google.com with SMTP id ls15so3558385pjb.1 for ; Wed, 15 Jul 2020 12:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OJ/YWMib2y0Oi9xcE3B9cmLij4uK6K7vyJCnBwYrt/0=; b=kiYOUCLw+1YMW5C/hDrCQnyOlnRtGrFPezJA04+b0b4IIM5w8VNidZnsPMPHfZ31KS LxhyDUqGX0RwzJAlBRqOfe2ODGCTv2LKEk/50WpTfn28Dp+ZBxdVxNZXkt6vym0qxK/Q rx82Fv0Ijv3kJKlDTbYSXiKFjVaIlmJguN6+3aaiaOjcY7ZTRMaa5SON4MfuTw8M/HSU v8ruKKdEd2o//mAyXMOkE3cXxzduzOyubtoH4T/VezrAKzRSY9zqMZ+YPOlllJ7ocF+k UdiLFpdNVsXZC/MUNV+4eR0KRB3FESXVCeMno3tw/kkcCifALuCf49tFeBBbwBN9AyNI Cing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OJ/YWMib2y0Oi9xcE3B9cmLij4uK6K7vyJCnBwYrt/0=; b=trr9CRPKbmWZTJXPU63lFWEwXOXojiEtjLbTAN6iy5j5xLmhftU10b1OiLxo2kIsGo GuzcdZ+jJ2oLQtdclW9XbW3rfB6zLwBvTpRReFEB86N+4gQalHebqgGGpXJrmepaF95r 1KL/6iRkTCk3V7BmfAqOhTPy7XmqnIUGNK0PFBhwRtlQY2rtf6FrrPOvTBvBxomcQKKq SAYQ0yLo3tmIh5aGeRDg2Utki17wOAOfca40QpbAsvf4XhleX0znFqhebjZSKAWhsDjY ygzbVZQu94QSVgrrHLDewypxsYy6Z8qmfn5qQy4FkQoJOyJ2Bx8HyWx2ZrSMwNfePbjr 1W0Q== X-Gm-Message-State: AOAM532FA8BI+/0JYbY1DeHcpBF05gnKvXHyMuBr0nvlQgS1YnuqkaRN 4l76+TXZIIKffahdZuBz8c+skQ== X-Google-Smtp-Source: ABdhPJxxiugzYbbF1aUsgwFCaTWYsI5jJtHeJsIIOQXJcVFYwSl1wCBetM40QxEzTt5KKymF9BCfSw== X-Received: by 2002:a17:90a:ed87:: with SMTP id k7mr1208692pjy.31.1594841023280; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g6sm2829878pfr.129.2020.07.15.12.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 12:23:42 -0700 (PDT) Date: Wed, 15 Jul 2020 12:21:38 -0700 From: Bjorn Andersson To: Lee Jones Subject: Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Message-ID: <20200715192138.GA2922385@builder.lan> References: <20200715123551.4011154-1-lee.jones@linaro.org> <20200715123551.4011154-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200715123551.4011154-2-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_152348_551554_61F14263 X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote: > Looks as though 'name' has now been moved into 'struct sysmod_event' > which is passed in instead. However, the parameter descriptions were > not updated at the same time. Let's do that now. > > Fixes the following W=1 kernel build warning(s): > > drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event' > drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event' > drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event' > drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event' > > Cc: Andy Gross > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones Thanks Lee, both patches applied. Regards, Bjorn > --- > drivers/remoteproc/qcom_sysmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c > index 8d8996d714f07..9eb2f6bccea63 100644 > --- a/drivers/remoteproc/qcom_sysmon.c > +++ b/drivers/remoteproc/qcom_sysmon.c > @@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list); > /** > * sysmon_send_event() - send notification of other remote's SSR event > * @sysmon: sysmon context > - * @name: other remote's name > + * @event: sysmon event context > */ > static void sysmon_send_event(struct qcom_sysmon *sysmon, > const struct sysmon_event *event) > @@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon) > /** > * ssctl_send_event() - send notification of other remote's SSR event > * @sysmon: sysmon context > - * @name: other remote's name > + * @event: sysmon event context > */ > static void ssctl_send_event(struct qcom_sysmon *sysmon, > const struct sysmon_event *event) > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel