From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [v2] test: Have test_fs work with non-functional guestmount tools
Date: Wed, 15 Jul 2020 15:51:21 -0400 [thread overview]
Message-ID: <20200715195121.GW6227@bill-the-cat> (raw)
In-Reply-To: <20200709134225.10412-1-trini@konsulko.com>
On Thu, Jul 09, 2020 at 09:42:25AM -0400, Tom Rini wrote:
> Since 2011 Ubuntu has intentionally broken support for guestmount[1] by
> default and requires sysadmin intervention to re-enable support. This
> in turn exposed that in our tests if guestmount is available but fails
> we do not fall back to trying to use sudo. Restructure our code to try
> sudo if guestmount fails rather than only when it is not in our path.
> Further, only note that we are using fuse on success of the call.
>
> [1]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725
>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
So, I'm rejecting this patch. While it fixes the tests running under
GitLab, when the runner is configured correctly:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/124997
It causes Travis to fail the tests now:
https://travis-ci.org/github/trini/u-boot/jobs/708328027
whereas the usually are run and pass:
https://travis-ci.org/github/trini/u-boot/jobs/708035304
And in neither case are these all run on Azure:
https://dev.azure.com/u-boot/u-boot/_build/results?buildId=909&view=logs&j=50449d1b-398e-53ae-48fa-6bf338edeb51&t=97605dd2-f5a5-5dd7-2118-315ffdc8bcd6
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200715/a40dd75b/attachment.sig>
prev parent reply other threads:[~2020-07-15 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 13:42 [v2] test: Have test_fs work with non-functional guestmount tools Tom Rini
2020-07-09 17:07 ` Stephen Warren
2020-07-09 18:02 ` Simon Glass
2020-07-15 19:51 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715195121.GW6227@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.