From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8AEBC433E2 for ; Wed, 15 Jul 2020 21:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C06E32065D for ; Wed, 15 Jul 2020 21:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgGOVp6 (ORCPT ); Wed, 15 Jul 2020 17:45:58 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36715 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbgGOVpz (ORCPT ); Wed, 15 Jul 2020 17:45:55 -0400 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8DDB860002; Wed, 15 Jul 2020 21:45:51 +0000 (UTC) Date: Wed, 15 Jul 2020 23:45:51 +0200 From: Alexandre Belloni To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , Ludovic Desroches , Nicolas Ferre , Songjun Wu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH RESEND 2/3] usb: gadget: udc: atmel: fix uninitialized read in debug printk Message-ID: <20200715214551.GF23553@piout.net> References: <248e7089f7fbb3727e83a1dfb43820d96a69e8c2.1594231056.git.mirq-linux@rere.qmqm.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <248e7089f7fbb3727e83a1dfb43820d96a69e8c2.1594231056.git.mirq-linux@rere.qmqm.pl> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2020 20:04:09+0200, Michał Mirosław wrote: > Fixed commit moved the assignment of 'req', but did not update a > reference in the DBG() call. Use the argument as it was renamed. > > Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module") > Signed-off-by: Michał Mirosław Acked-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 9153e220848d..9342a3d24963 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > u32 status; > > DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n", > - ep->ep.name, req); > + ep->ep.name, _req); > > spin_lock_irqsave(&udc->lock, flags); > > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F0EC433E3 for ; Wed, 15 Jul 2020 21:47:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26B572065D for ; Wed, 15 Jul 2020 21:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SOCixi/I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26B572065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K7iQ4DAI1BSpVCiA+IgXsF4yx5fcl+WKLQtlNfCsG7Y=; b=SOCixi/IMyB3YQ/ZJRXUCuRi8 v5cpegNfLWHAS1l3+ZsC8lldIRbaMPva55IQlfoGv0p20i01cJi/nvxXxmU1eq/4hp9WeEI8m1cDm Et+kVgas38Yu6/16MhdfiKCvjCKaXVSd/KRhwYh8NaayuE3akLwiJCUA9c5ep6FQsbBckYluZrQ+Y rhGq5/xwqjF1HogHUnWBhxV1X84EuA5WjXW85isv1ICg3zxIFxHwppiDHjINPPctaqmuaxXstGM5i +E9Gw5JO255i5F85I3ovGyGcX8k7ri42ui64yo/2jd23XRYspkmFr0UgY+DvnpikDIojZb/iShgQt Qi2rd4etg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvpDy-00082E-Gz; Wed, 15 Jul 2020 21:45:58 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvpDw-000814-7E for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 21:45:57 +0000 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8DDB860002; Wed, 15 Jul 2020 21:45:51 +0000 (UTC) Date: Wed, 15 Jul 2020 23:45:51 +0200 From: Alexandre Belloni To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Subject: Re: [PATCH RESEND 2/3] usb: gadget: udc: atmel: fix uninitialized read in debug printk Message-ID: <20200715214551.GF23553@piout.net> References: <248e7089f7fbb3727e83a1dfb43820d96a69e8c2.1594231056.git.mirq-linux@rere.qmqm.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <248e7089f7fbb3727e83a1dfb43820d96a69e8c2.1594231056.git.mirq-linux@rere.qmqm.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_174556_432703_F5A6AF24 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org, Songjun Wu , Cristian Birsan Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDgvMDcvMjAyMCAyMDowNDowOSswMjAwLCBNaWNoYcWCIE1pcm9zxYJhdyB3cm90ZToKPiBG aXhlZCBjb21taXQgbW92ZWQgdGhlIGFzc2lnbm1lbnQgb2YgJ3JlcScsIGJ1dCBkaWQgbm90IHVw ZGF0ZSBhCj4gcmVmZXJlbmNlIGluIHRoZSBEQkcoKSBjYWxsLiBVc2UgdGhlIGFyZ3VtZW50IGFz IGl0IHdhcyByZW5hbWVkLgo+IAo+IEZpeGVzOiA1ZmI2OTRmOTZlN2MgKCJ1c2I6IGdhZGdldDog dWRjOiBhdG1lbDogZml4IHBvc3NpYmxlIG9vcHMgd2hlbiB1bmxvYWRpbmcgbW9kdWxlIikKPiBT aWduZWQtb2ZmLWJ5OiBNaWNoYcWCIE1pcm9zxYJhdyA8bWlycS1saW51eEByZXJlLnFtcW0ucGw+ CkFja2VkLWJ5OiBBbGV4YW5kcmUgQmVsbG9uaSA8YWxleGFuZHJlLmJlbGxvbmlAYm9vdGxpbi5j b20+Cgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFfdWRjLmMgfCAy ICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFfdWRjLmMgYi9k cml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFfdWRjLmMKPiBpbmRleCA5MTUzZTIyMDg0 OGQuLjkzNDJhM2QyNDk2MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0 bWVsX3VzYmFfdWRjLmMKPiArKysgYi9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFf dWRjLmMKPiBAQCAtODY1LDcgKzg2NSw3IEBAIHN0YXRpYyBpbnQgdXNiYV9lcF9kZXF1ZXVlKHN0 cnVjdCB1c2JfZXAgKl9lcCwgc3RydWN0IHVzYl9yZXF1ZXN0ICpfcmVxKQo+ICAJdTMyIHN0YXR1 czsKPiAgCj4gIAlEQkcoREJHX0dBREdFVCB8IERCR19RVUVVRSwgImVwX2RlcXVldWU6ICVzLCBy ZXEgJXBcbiIsCj4gLQkJCWVwLT5lcC5uYW1lLCByZXEpOwo+ICsJCQllcC0+ZXAubmFtZSwgX3Jl cSk7Cj4gIAo+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJnVkYy0+bG9jaywgZmxhZ3MpOwo+ICAKPiAt LSAKPiAyLjIwLjEKPiAKCi0tIApBbGV4YW5kcmUgQmVsbG9uaSwgQm9vdGxpbgpFbWJlZGRlZCBM aW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK