From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Tejas Upadhyay <tejasu@xilinx.com>,
Satish Kumar Nagireddy <SATISHNA@xilinx.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH v6 5/6] dmaengine: xilinx: dpdma: Add debugfs support
Date: Thu, 16 Jul 2020 03:42:33 +0300 [thread overview]
Message-ID: <20200716004233.GO6144@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200715110130.GJ34333@vkoul-mobl>
Hi Vinod,
On Wed, Jul 15, 2020 at 04:31:30PM +0530, Vinod Koul wrote:
> On 08-07-20, 23:19, Laurent Pinchart wrote:
> > +static int xilinx_dpdma_debugfs_init(struct device *dev)
> > +{
> > + int err;
> > + struct dentry *xilinx_dpdma_debugfs_dir, *xilinx_dpdma_debugfs_file;
> > +
> > + dpdma_debugfs.testcase = DPDMA_TC_NONE;
> > +
> > + xilinx_dpdma_debugfs_dir = debugfs_create_dir("dpdma", NULL);
>
> can you please use the dma_dev->dbg_dev_root, we are already creating
> /sys/kernel/debug/dmaengine/<device>/
Good point, I'll fix that.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-16 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 20:19 [PATCH v6 0/6] dma: Add Xilinx ZynqMP DPDMA driver Laurent Pinchart
2020-07-08 20:19 ` [PATCH v6 1/6] dt: bindings: dma: xilinx: dpdma: DT bindings for Xilinx DPDMA Laurent Pinchart
2020-07-08 20:19 ` [PATCH v6 2/6] dmaengine: virt-dma: Use lockdep to check locking requirements Laurent Pinchart
2020-07-09 13:07 ` Peter Ujfalusi
2020-07-11 19:53 ` Laurent Pinchart
2020-07-08 20:19 ` [PATCH v6 3/6] dmaengine: Add support for repeating transactions Laurent Pinchart
2020-07-09 13:25 ` Peter Ujfalusi
2020-07-08 20:19 ` [PATCH v6 4/6] dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver Laurent Pinchart
2020-07-09 13:21 ` Peter Ujfalusi
2020-07-11 22:16 ` Laurent Pinchart
2020-07-15 6:54 ` Vinod Koul
2020-07-15 10:59 ` Vinod Koul
2020-07-16 0:41 ` Laurent Pinchart
2020-07-16 5:21 ` Vinod Koul
2020-07-16 13:46 ` Laurent Pinchart
2020-07-17 5:59 ` Vinod Koul
2020-07-08 20:19 ` [PATCH v6 5/6] dmaengine: xilinx: dpdma: Add debugfs support Laurent Pinchart
2020-07-15 11:01 ` Vinod Koul
2020-07-16 0:42 ` Laurent Pinchart [this message]
2020-07-08 20:19 ` [PATCH v6 6/6] arm64: dts: zynqmp: Add DPDMA node Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716004233.GO6144@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=SATISHNA@xilinx.com \
--cc=dmaengine@vger.kernel.org \
--cc=hyun.kwon@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=peter.ujfalusi@ti.com \
--cc=tejasu@xilinx.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.