From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AADC433E0 for ; Thu, 16 Jul 2020 07:28:33 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1F6E206F5 for ; Thu, 16 Jul 2020 07:28:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ci71ZpD5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1F6E206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9EDFC88D5C; Thu, 16 Jul 2020 07:28:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6BK4C40ep_5s; Thu, 16 Jul 2020 07:28:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 036C688D33; Thu, 16 Jul 2020 07:28:31 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 038B21BF3BF for ; Thu, 16 Jul 2020 07:28:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id F3D6C8A1FA for ; Thu, 16 Jul 2020 07:28:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RZsxJYIn-WOO for ; Thu, 16 Jul 2020 07:28:29 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 58F29863B7 for ; Thu, 16 Jul 2020 07:28:29 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B91CC206C1; Thu, 16 Jul 2020 07:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594884509; bh=SYcdFaf5HdYrp6/CLmW/0Fkwx9KixuSorUJatgNzvIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ci71ZpD5S3+QhU/29ZLHmt6sx6CHBBFOvDFGEc8Idi+NVP4ztq8BTut8v79F9OD0a UNWgcmqvc5YkyJIBSmdbiNaQ0EhtbhDfD/Du94wgViUkTHqT2jJuQZITVXgcpgrtnT 5bChNpquKrkCX06aKWC/AAixLbvSh2ng4sGsm3aI= Date: Thu, 16 Jul 2020 09:28:23 +0200 From: Greg Kroah-Hartman To: Kees Cook Subject: Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global Message-ID: <20200716072823.GA971895@kroah.com> References: <20200716030847.1564131-1-keescook@chromium.org> <20200716030847.1564131-2-keescook@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200716030847.1564131-2-keescook@chromium.org> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kuppuswamy Sathyanarayanan , Douglas Anderson , Oscar Carter , Mitchell Blank Jr , kernel-hardening@lists.openwall.com, Peter Zijlstra , kgdb-bugreport@lists.sourceforge.net, Sebastian Andrzej Siewior , alsa-devel@alsa-project.org, Takashi Iwai , Christian Gromm , Kevin Curtis , Will Deacon , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Daniel Thompson , Jonathan Corbet , Masahiro Yamada , "Rafael J. Wysocki" , Julian Wiedmann , "Matthew Wilcox \(Oracle\)" , Christian Borntraeger , Nishka Dasgupta , Jiri Slaby , Jakub Kicinski , Guenter Roeck , Wambui Karuga , Vasily Gorbik , Heiko Carstens , linux-input@vger.kernel.org, Ursula Braun , Stephen Boyd , Chris Packham , Harald Freudenberger , Thomas Gleixner , Jaroslav Kysela , Felipe Balbi , Kyungtae Kim , netdev@vger.kernel.org, Dmitry Torokhov , Allen Pais , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Jason Wessel , Karsten Graul , Romain Perier , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Jul 15, 2020 at 08:08:45PM -0700, Kees Cook wrote: > There's no reason for the tasklet callback to set an argument since it > always uses a global. Instead, use the global directly, in preparation > for converting the tasklet subsystem to modern callback conventions. > > Signed-off-by: Kees Cook > --- > drivers/usb/gadget/udc/snps_udc_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/snps_udc_core.c b/drivers/usb/gadget/udc/snps_udc_core.c > index 3fcded31405a..afdd28f332ce 100644 > --- a/drivers/usb/gadget/udc/snps_udc_core.c > +++ b/drivers/usb/gadget/udc/snps_udc_core.c > @@ -96,9 +96,7 @@ static int stop_pollstall_timer; > static DECLARE_COMPLETION(on_pollstall_exit); > > /* tasklet for usb disconnect */ > -static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, > - (unsigned long) &udc); > - > +static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, 0); > > /* endpoint names used for print */ > static const char ep0_string[] = "ep0in"; > @@ -1661,7 +1659,7 @@ static void usb_disconnect(struct udc *dev) > /* Tasklet for disconnect to be outside of interrupt context */ > static void udc_tasklet_disconnect(unsigned long par) > { > - struct udc *dev = (struct udc *)(*((struct udc **) par)); > + struct udc *dev = udc; > u32 tmp; > > DBG(dev, "Tasklet disconnect\n"); Feel free to just take this in your tree, no need to wait for the USB stuff to land. Reviewed-by: Greg Kroah-Hartman _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA5ADC433E3 for ; Thu, 16 Jul 2020 15:41:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 318442076D for ; Thu, 16 Jul 2020 15:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="elTQ96GJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ci71ZpD5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 318442076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A1AAD84A; Thu, 16 Jul 2020 17:40:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A1AAD84A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594914069; bh=SYcdFaf5HdYrp6/CLmW/0Fkwx9KixuSorUJatgNzvIA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=elTQ96GJ0ouWcV1f0+oAefEPw+Jb4IIdfXV4A3dYu81PGRKRQlYbxA7kFHlvvct0R QKt23QLh/gH0WrK4jUdnMVS+s//9Pzp0/xtxM26fTfH39/gBw+p1HhSh5nGRfx3cDW u3c00KrYxdyXOGCTDFwxtvpaOLVFB1nJBxW4UWc8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 30EA4F8014E; Thu, 16 Jul 2020 17:40:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6876CF801EC; Thu, 16 Jul 2020 09:28:38 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9B1EFF8014C for ; Thu, 16 Jul 2020 09:28:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9B1EFF8014C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ci71ZpD5" Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B91CC206C1; Thu, 16 Jul 2020 07:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594884509; bh=SYcdFaf5HdYrp6/CLmW/0Fkwx9KixuSorUJatgNzvIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ci71ZpD5S3+QhU/29ZLHmt6sx6CHBBFOvDFGEc8Idi+NVP4ztq8BTut8v79F9OD0a UNWgcmqvc5YkyJIBSmdbiNaQ0EhtbhDfD/Du94wgViUkTHqT2jJuQZITVXgcpgrtnT 5bChNpquKrkCX06aKWC/AAixLbvSh2ng4sGsm3aI= Date: Thu, 16 Jul 2020 09:28:23 +0200 From: Greg Kroah-Hartman To: Kees Cook Subject: Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global Message-ID: <20200716072823.GA971895@kroah.com> References: <20200716030847.1564131-1-keescook@chromium.org> <20200716030847.1564131-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716030847.1564131-2-keescook@chromium.org> X-Mailman-Approved-At: Thu, 16 Jul 2020 17:40:14 +0200 Cc: Kuppuswamy Sathyanarayanan , Douglas Anderson , Oscar Carter , Mitchell Blank Jr , kernel-hardening@lists.openwall.com, Peter Zijlstra , kgdb-bugreport@lists.sourceforge.net, Sebastian Andrzej Siewior , alsa-devel@alsa-project.org, Takashi Iwai , Christian Gromm , Kevin Curtis , Will Deacon , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Daniel Thompson , Jonathan Corbet , Masahiro Yamada , "Rafael J. Wysocki" , Julian Wiedmann , "Matthew Wilcox \(Oracle\)" , Christian Borntraeger , Nishka Dasgupta , Jiri Slaby , Jakub Kicinski , Guenter Roeck , Wambui Karuga , Vasily Gorbik , Heiko Carstens , linux-input@vger.kernel.org, Ursula Braun , Stephen Boyd , Chris Packham , Harald Freudenberger , Thomas Gleixner , Felipe Balbi , Kyungtae Kim , netdev@vger.kernel.org, Dmitry Torokhov , Allen Pais , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Jason Wessel , Karsten Graul , Romain Perier , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Jul 15, 2020 at 08:08:45PM -0700, Kees Cook wrote: > There's no reason for the tasklet callback to set an argument since it > always uses a global. Instead, use the global directly, in preparation > for converting the tasklet subsystem to modern callback conventions. > > Signed-off-by: Kees Cook > --- > drivers/usb/gadget/udc/snps_udc_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/snps_udc_core.c b/drivers/usb/gadget/udc/snps_udc_core.c > index 3fcded31405a..afdd28f332ce 100644 > --- a/drivers/usb/gadget/udc/snps_udc_core.c > +++ b/drivers/usb/gadget/udc/snps_udc_core.c > @@ -96,9 +96,7 @@ static int stop_pollstall_timer; > static DECLARE_COMPLETION(on_pollstall_exit); > > /* tasklet for usb disconnect */ > -static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, > - (unsigned long) &udc); > - > +static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, 0); > > /* endpoint names used for print */ > static const char ep0_string[] = "ep0in"; > @@ -1661,7 +1659,7 @@ static void usb_disconnect(struct udc *dev) > /* Tasklet for disconnect to be outside of interrupt context */ > static void udc_tasklet_disconnect(unsigned long par) > { > - struct udc *dev = (struct udc *)(*((struct udc **) par)); > + struct udc *dev = udc; > u32 tmp; > > DBG(dev, "Tasklet disconnect\n"); Feel free to just take this in your tree, no need to wait for the USB stuff to land. Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7950FC433E4 for ; Thu, 16 Jul 2020 07:28:51 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id C4A782071B for ; Thu, 16 Jul 2020 07:28:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ci71ZpD5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4A782071B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-19339-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 5748 invoked by uid 550); 16 Jul 2020 07:28:42 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 5715 invoked from network); 16 Jul 2020 07:28:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594884509; bh=SYcdFaf5HdYrp6/CLmW/0Fkwx9KixuSorUJatgNzvIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ci71ZpD5S3+QhU/29ZLHmt6sx6CHBBFOvDFGEc8Idi+NVP4ztq8BTut8v79F9OD0a UNWgcmqvc5YkyJIBSmdbiNaQ0EhtbhDfD/Du94wgViUkTHqT2jJuQZITVXgcpgrtnT 5bChNpquKrkCX06aKWC/AAixLbvSh2ng4sGsm3aI= Date: Thu, 16 Jul 2020 09:28:23 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: Kuppuswamy Sathyanarayanan , "Rafael J. Wysocki" , Oscar Carter , Mitchell Blank Jr , kernel-hardening@lists.openwall.com, Peter Zijlstra , kgdb-bugreport@lists.sourceforge.net, Sebastian Andrzej Siewior , alsa-devel@alsa-project.org, Allen Pais , Christian Gromm , Will Deacon , devel@driverdev.osuosl.org, Jonathan Corbet , Daniel Thompson , "David S. Miller" , Masahiro Yamada , Takashi Iwai , Julian Wiedmann , "Matthew Wilcox (Oracle)" , Christian Borntraeger , Nishka Dasgupta , Jiri Slaby , Jakub Kicinski , Guenter Roeck , Wambui Karuga , Vasily Gorbik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Carstens , linux-input@vger.kernel.org, Ursula Braun , Stephen Boyd , Chris Packham , Harald Freudenberger , Thomas Gleixner , Jaroslav Kysela , Felipe Balbi , Kyungtae Kim , netdev@vger.kernel.org, Dmitry Torokhov , Douglas Anderson , Kevin Curtis , linux-usb@vger.kernel.org, Jason Wessel , Romain Perier , Karsten Graul Subject: Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global Message-ID: <20200716072823.GA971895@kroah.com> References: <20200716030847.1564131-1-keescook@chromium.org> <20200716030847.1564131-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716030847.1564131-2-keescook@chromium.org> On Wed, Jul 15, 2020 at 08:08:45PM -0700, Kees Cook wrote: > There's no reason for the tasklet callback to set an argument since it > always uses a global. Instead, use the global directly, in preparation > for converting the tasklet subsystem to modern callback conventions. > > Signed-off-by: Kees Cook > --- > drivers/usb/gadget/udc/snps_udc_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/snps_udc_core.c b/drivers/usb/gadget/udc/snps_udc_core.c > index 3fcded31405a..afdd28f332ce 100644 > --- a/drivers/usb/gadget/udc/snps_udc_core.c > +++ b/drivers/usb/gadget/udc/snps_udc_core.c > @@ -96,9 +96,7 @@ static int stop_pollstall_timer; > static DECLARE_COMPLETION(on_pollstall_exit); > > /* tasklet for usb disconnect */ > -static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, > - (unsigned long) &udc); > - > +static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect, 0); > > /* endpoint names used for print */ > static const char ep0_string[] = "ep0in"; > @@ -1661,7 +1659,7 @@ static void usb_disconnect(struct udc *dev) > /* Tasklet for disconnect to be outside of interrupt context */ > static void udc_tasklet_disconnect(unsigned long par) > { > - struct udc *dev = (struct udc *)(*((struct udc **) par)); > + struct udc *dev = udc; > u32 tmp; > > DBG(dev, "Tasklet disconnect\n"); Feel free to just take this in your tree, no need to wait for the USB stuff to land. Reviewed-by: Greg Kroah-Hartman