From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CDEAC433E5 for ; Thu, 16 Jul 2020 08:37:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1810920771 for ; Thu, 16 Jul 2020 08:37:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dGhcIgdt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1810920771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvzOq-0003hA-3Q for qemu-devel@archiver.kernel.org; Thu, 16 Jul 2020 04:37:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvzOE-0003IC-TS for qemu-devel@nongnu.org; Thu, 16 Jul 2020 04:37:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35640 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jvzOC-00046i-Ew for qemu-devel@nongnu.org; Thu, 16 Jul 2020 04:37:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594888630; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Uki2QNtkKmkXoSg4722lww0ZdNZfoDll1kzhCh+7He0=; b=dGhcIgdt/JhbaR4TOscVnVEVjGAIV+PDUxE5qWLKDU4/Cz5VnlPUJqrh+hr440rBYXtHp3 G1uaS+wl66GkKdlchZNeAe+uDI1jUkJkG5jds7qmnH2rVckOmu2SFLcNDqV/GbJHib+pcJ lrXAkZWefSviPalQUJLsWc+Dm310g84= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-ZqLZZI_GPACrmnTinwYExQ-1; Thu, 16 Jul 2020 04:37:06 -0400 X-MC-Unique: ZqLZZI_GPACrmnTinwYExQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73C85100AA21; Thu, 16 Jul 2020 08:37:05 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3454379500; Thu, 16 Jul 2020 08:36:57 +0000 (UTC) Date: Thu, 16 Jul 2020 09:36:54 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Cornelia Huck Subject: Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field Message-ID: <20200716083654.GA227735@redhat.com> References: <20200714083631.888605-1-ppandit@redhat.com> <20200714083631.888605-2-ppandit@redhat.com> <20200714095233.GC25187@redhat.com> <20200714060916-mutt-send-email-mst@kernel.org> <20200714064921-mutt-send-email-mst@kernel.org> <20200716085543.7082f047.cohuck@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200716085543.7082f047.cohuck@redhat.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 04:25:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Peter Maydell , Stefano Stabellini , "Michael S. Tsirkin" , QEMU Developers , Christian Schoenebeck , Michael Roth , P J P , Greg Kurz , Stefan Hajnoczi , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 16, 2020 at 08:55:43AM +0200, Cornelia Huck wrote: > On Tue, 14 Jul 2020 18:40:11 +0530 (IST) > P J P wrote: > > > > > * QEMU would abort(3), if a user attempts to start QEMU with insecure options > > like say -virtfs OR -fda fat:floopy OR -netdev user OR -device tulip ? > > > > * One way could be to abort(3) at options parsing stage, if 'security' flag > > is set to high(1) and continue further if it is low(0). > > Failing to start (with a message that explains why) if one of the > command line options is not covered by a specified security policy is > not unreasonable (after all, we fail to start for other cases of > incompatible command line options as well.) However, we also need to > cover dynamically-added devices. Aborting seems very bad there, just > failing to add the device seems like what we'd want. Yep, aborting is simply not an option for the inner code. It all has to propagate to a proper Error **errp object. The ultimate entry-point at the CLI vs QMP then decides whether to turn the error into an abort or feed back to the client app. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|