From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CEFCC433E7 for ; Thu, 16 Jul 2020 11:41:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FEF520657 for ; Thu, 16 Jul 2020 11:41:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="A3gWZCDn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727030AbgGPLlS (ORCPT ); Thu, 16 Jul 2020 07:41:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgGPLlS (ORCPT ); Thu, 16 Jul 2020 07:41:18 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1100C061755 for ; Thu, 16 Jul 2020 04:41:17 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id 80so5145130qko.7 for ; Thu, 16 Jul 2020 04:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7z07yaF5tVOtRN5BzxzuEbkDvPPTHik1E7Q8FSZDafQ=; b=A3gWZCDnd/DTGFO6B4D0Av5VHiGMw413nE1oMj+9b157kKyMmyeXgeI8vAipS5zvs3 79yQpO8IpmWejPdEMuw1Et10mJO5KcuivxKr7Dqk0oYu73gc1pblBBT1B0xDf5UxsFgR r/zSTtcRV2+D9qFjIt55xfr0agZ+ojcnKhwFCTyLCqdXEvXv29TYd7C+lZIhDnyXSa4b KCcqSllzAiE1pntUXpmnU5sKJZVmXSzFasR1EBI/wYqhIBuBnPdv2UIICpiJCsUZylA6 A8kj8pfyGGwuei9l4i9Z3l3iRFBQ04nD9Ux12QzmaBFWaMno4kIKi/omoKiOLFRqdhpo Ptkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7z07yaF5tVOtRN5BzxzuEbkDvPPTHik1E7Q8FSZDafQ=; b=fcTaTWSNfOXb4q6/6t+RIAE5jcc9Wq8dCRaA8ucTU5XlliZsG3tnL+MkivJg4x9jD9 HBPn4qOWWHGRK9T8a4QyDE7hLho2NzhJ04X7F+D6Odd+B9IvSvkEp8/DZm+PbDfmcIFq 2CJDhO6cmj1XvwUGJ6O9jyyjWbo8QWjTTfTaoo1iO01NO7VVeZEJ1fuHrQIumInrU+6o uzKyV73emEf4vunZ6PQzWlROqefmnkNVBY+Xa8XseHjSoD93c7LXYl1oVGH7XDybBs1l LeZhFmb+AqywpCC1oSo/19oOShij6Rj7GbnU8OwJYaTEVKL8XkWKcylmqS+iauPRdLFV R7Cw== X-Gm-Message-State: AOAM530Bqp9BJ4ssMSkLbtqUMUoEIPy3XfbuImDx9Gg6sPhdrNlGCMTa 8lSDpxsshexvPxzwg31BJ8qyg8suxec= X-Google-Smtp-Source: ABdhPJwxbsomUMjj5IVbv36leKjOiRWmuZ3xBnM71VZIk2cGmmAo/FokSX/NR60eWO4QlJqy5qasow== X-Received: by 2002:a37:954:: with SMTP id 81mr3420229qkj.336.1594899677092; Thu, 16 Jul 2020 04:41:17 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id 188sm6560780qkf.50.2020.07.16.04.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 04:41:16 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.93) (envelope-from ) id 1jw2GJ-00Aveg-32; Thu, 16 Jul 2020 08:41:15 -0300 Date: Thu, 16 Jul 2020 08:41:15 -0300 From: Jason Gunthorpe To: Zhu Yanjun Cc: Mikhail Malygin , "linux-rdma@vger.kernel.org" , Sergey Kojushev , "linux@yadro.com" Subject: Re: [PATCH] rdma_rxe: Prevent access to wr->next ptr afrer wr is posted to send queue Message-ID: <20200716114115.GF25301@ziepe.ca> References: <20200715113743.GC2021234@nvidia.com> <6370C3FE-966D-4C6E-AAA1-179F39D382BB@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Jul 16, 2020 at 11:17:09AM +0800, Zhu Yanjun wrote: > On Wed, Jul 15, 2020 at 8:39 PM Mikhail Malygin wrote: > > > > Thanks, I’ll post an updated version. > > > > Mikhail > > > > > On 15 Jul 2020, at 14:37, Jason Gunthorpe wrote: > > > > > > The spinock in post_one_send() guarantees no reordering across > > How about spin_lock_irqsave? The unlock of any lock prevents store reordering by definition Jason