All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, dev.kurt@vandijck-laurijssen.be
Subject: Re: [PATCH v41 3/3] can: mcp25xxfd: initial commit
Date: Thu, 16 Jul 2020 18:58:00 +0530	[thread overview]
Message-ID: <20200716132800.GH3271@Mani-XPS-13-9360> (raw)
In-Reply-To: <fdb6e441-fed5-435e-553c-1fc0a6bfb8f7@pengutronix.de>

On Fri, Jun 26, 2020 at 04:41:53PM +0200, Marc Kleine-Budde wrote:
> On 6/26/20 3:32 PM, Manivannan Sadhasivam wrote:
> > On Mon, Jun 22, 2020 at 01:46:03PM +0200, Marc Kleine-Budde wrote:
> >> This patch add support for the Microchip MCP25xxFD SPI CAN controller family.
> >>
> >> Pending-Tested-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> >> Pending-Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > 
> > Could you please split this patch into multiple ones? Having ~4k lines for a
> > patch makes it difficult to review. I know that some parts are difficult to
> > split (happened with my series as well) but anything below 1k should be fine.
> 
> For now I split the regmap and crc16 into one patch, the core file into a
> separate patch.
> 
> See:
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=mcp25xxfd-45
> 
> If you want to have it in smaller pieces I'll need more time to figure out a
> sensible way to split the driver.
> 

Can you please post the split version here so that I can do a formal review?

Thanks,
Mani

> regards,
> Marc
> 
> -- 
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2020-07-16 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 11:46 [PATCH v41 0/3] can: add mcp25xxfd support Marc Kleine-Budde
2020-06-22 11:46 ` [PATCH v41 1/3] can: rx-offload: can_rx_offload_add_manual(): add new initialization function Marc Kleine-Budde
2020-06-22 11:46 ` [PATCH v41 2/3] dt-binding: can: mcp25xxfd: document device tree bindings Marc Kleine-Budde
2020-06-22 16:53   ` Manivannan Sadhasivam
2020-06-22 18:12     ` Marc Kleine-Budde
2020-06-23  3:26       ` Manivannan Sadhasivam
2020-06-23  6:02         ` Oleksij Rempel
2020-06-23  6:12           ` Manivannan Sadhasivam
2020-06-23  7:27         ` Marc Kleine-Budde
2020-06-23 12:46 ` [PATCH v41 0/3] can: add mcp25xxfd support Manivannan Sadhasivam
2020-06-23 12:49   ` Marc Kleine-Budde
     [not found] ` <20200622114603.965371-4-mkl@pengutronix.de>
     [not found]   ` <20200626133243.GA8333@Mani-XPS-13-9360>
2020-06-26 14:41     ` [PATCH v41 3/3] can: mcp25xxfd: initial commit Marc Kleine-Budde
2020-07-16 13:28       ` Manivannan Sadhasivam [this message]
2020-08-17 15:51         ` Manivannan Sadhasivam
2020-06-27 19:56     ` Kurt Van Dijck
2020-06-28  6:48       ` Manivannan Sadhasivam
2020-08-31 10:10 ` [PATCH v41 0/3] can: add mcp25xxfd support Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716132800.GH3271@Mani-XPS-13-9360 \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=dev.kurt@vandijck-laurijssen.be \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.