All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/i915_pm_lpsp: Add igt_wait to test lpsp
Date: Thu, 16 Jul 2020 19:45:57 +0530	[thread overview]
Message-ID: <20200716141557.15909-1-anshuman.gupta@intel.com> (raw)

Sometimes LPSP test may fail due to HOTPLUG events,
which initiates AUX transaction in order to detect a Connector
status, these ongoing AUX transaction may fail the LPSP igt test.
Adding a igt_wait will avoid such failures.
Some eDP panel may have power_cycle_delay of 600ms,
therefore 1sec delay is safer.

Cc: Animesh Manna <animesh.manna@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_lpsp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
index 12670f22..e9a59307 100644
--- a/tests/i915/i915_pm_lpsp.c
+++ b/tests/i915/i915_pm_lpsp.c
@@ -163,7 +163,8 @@ static void test_lpsp(data_t *data)
 		    data->mode->vdisplay <= 2160);
 
 	setup_lpsp_output(data);
-	igt_assert_f(lpsp_is_enabled(data), "%s: lpsp is not enabled\n%s:\n%s\n",
+	igt_assert_f(igt_wait(lpsp_is_enabled(data), 1000, 100),
+		     "%s: lpsp is not enabled\n%s:\n%s\n",
 		     data->output->name, PWR_DOMAIN_INFO, data->pwr_dmn_info =
 		     igt_sysfs_get(data->debugfs_fd, PWR_DOMAIN_INFO));
 }
-- 
2.26.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-07-16 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 14:15 Anshuman Gupta [this message]
2020-07-16 15:14 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915_pm_lpsp: Add igt_wait to test lpsp Patchwork
2020-07-16 18:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-17  5:54 ` [igt-dev] [PATCH i-g-t] " Manna, Animesh
2020-07-22  5:58   ` Sharma, Swati2
2020-07-21  0:58 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716141557.15909-1-anshuman.gupta@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.