From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: stanimir.varbanov@linaro.org, robh+dt@kernel.org,
agross@kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, mka@chromium.org
Subject: Re: [PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting
Date: Thu, 16 Jul 2020 16:43:10 -0700 [thread overview]
Message-ID: <20200716234310.GH1218486@builder.lan> (raw)
In-Reply-To: <1594878139-3402-2-git-send-email-rnayak@codeaurora.org>
On Wed 15 Jul 22:42 PDT 2020, Rajendra Nayak wrote:
> Add an optional power domain which when specified can be used for
> setting the performance state of Venus.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> This is a resend of https://lore.kernel.org/patchwork/patch/1241077/
>
> Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> index 55f2d67..1e8675b 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> @@ -25,12 +25,16 @@ properties:
> maxItems: 1
>
> power-domains:
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
>
> power-domain-names:
> + minItems: 2
> + maxItems: 3
> items:
> - const: venus
> - const: vcodec0
> + - const: opp-pd
In line with Rob's question, the "opp power-domain" seems like a
software construct, wouldn't this be better named e.g. "cx"?
Regards,
Bjorn
>
> clocks:
> maxItems: 5
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> index 157dff8..437286d 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> @@ -25,13 +25,17 @@ properties:
> maxItems: 1
>
> power-domains:
> - maxItems: 3
> + minItems: 3
> + maxItems: 4
>
> power-domain-names:
> + minItems: 3
> + maxItems: 4
> items:
> - const: venus
> - const: vcodec0
> - const: vcodec1
> + - const: opp-pd
>
> clocks:
> maxItems: 7
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2020-07-16 23:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 5:42 [PATCH v2 0/4] DVFS support for Venus Rajendra Nayak
2020-07-16 5:42 ` [PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting Rajendra Nayak
2020-07-16 19:59 ` Rob Herring
2020-07-17 5:52 ` Rajendra Nayak
2020-07-17 18:56 ` Rob Herring
2020-07-20 4:29 ` Rajendra Nayak
2020-07-16 23:43 ` Bjorn Andersson [this message]
2020-07-17 5:13 ` Rajendra Nayak
2020-07-16 5:42 ` [PATCH v2 2/4] media: venus: core: Add support for opp tables/perf voting Rajendra Nayak
2020-07-16 5:42 ` [PATCH v2 3/4] arm64: dts: sdm845: Add OPP tables and power-domains for venus Rajendra Nayak
2020-07-16 5:42 ` [PATCH v2 4/4] arm64: dts: sc7180: " Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716234310.GH1218486@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.