From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AAE2C433E3 for ; Fri, 17 Jul 2020 04:38:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFF102070A for ; Fri, 17 Jul 2020 04:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbgGQEiI (ORCPT ); Fri, 17 Jul 2020 00:38:08 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:32859 "EHLO mx.tkos.co.il" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1725300AbgGQEiI (ORCPT ); Fri, 17 Jul 2020 00:38:08 -0400 Received: from tarshish (unknown [10.0.8.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 3EE76440A64; Fri, 17 Jul 2020 07:38:04 +0300 (IDT) Date: Fri, 17 Jul 2020 07:38:02 +0300 From: Baruch Siach To: "Gustavo A. R. Silva" Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword Message-ID: <20200717043802.uvorspihdh6cvby3@tarshish> References: <20200716220055.GA19603@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716220055.GA19603@embeddedor> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through This URL is likely to break at some point as documentation contest changes. Just refer to in kernel Documentation/process/deprecated.rst file. Other than that: Acked-by: Baruch Siach Thanks, baruch > Signed-off-by: Gustavo A. R. Silva > --- > drivers/i2c/busses/i2c-digicolor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c > index 332f00437479..f67639dc74b7 100644 > --- a/drivers/i2c/busses/i2c-digicolor.c > +++ b/drivers/i2c/busses/i2c-digicolor.c > @@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id) > break; > } > i2c->state = STATE_WRITE; > - /* fall through */ > + fallthrough; > case STATE_WRITE: > if (i2c->msgbuf_ptr < i2c->msg->len) > dc_i2c_write_buf(i2c); -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C54EC433DF for ; Fri, 17 Jul 2020 04:39:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44C63206BE for ; Fri, 17 Jul 2020 04:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DYMuR6it" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44C63206BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bE7Vm9KGqcI+dH6cMmVVaK9d4wN3ux1c1s+Iv/AVfWY=; b=DYMuR6itTruuEMlrpNoTGJiPz d/urrD6ReHMiqlQRlNv9Ftox9pfBClQPTGG0qwH4WNdIYQ01rs4IzQCAynFozmXW5E3PcYwJKo4WS /BEGtTUWgtE3UVQ9adnTiEq8ssZ8mujYgGt3fsyiJTqhHbcu58Gv50NhQie9jymyYn+v0PA0Cc8/3 KfVyoVJpzIjFv1sLBZOuppiaDnRns0mhIzRz/Bz/vQ0sPuozWQ0rw/Ip4bWgIxXUbVAqYD8oUwcOz Z+n0h1rJptCPxDCV3EegZtpmAWBWZg6fklwQ0a/oeKHTVNEIWLWLqaww1+P4QolXwTsi1q5I1LCBk 3G+7uHlaw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwI8S-0001lL-2h; Fri, 17 Jul 2020 04:38:12 +0000 Received: from [192.115.133.116] (helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwI8P-0001kh-Rx for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 04:38:11 +0000 Received: from tarshish (unknown [10.0.8.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 3EE76440A64; Fri, 17 Jul 2020 07:38:04 +0300 (IDT) Date: Fri, 17 Jul 2020 07:38:02 +0300 From: Baruch Siach To: "Gustavo A. R. Silva" Subject: Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword Message-ID: <20200717043802.uvorspihdh6cvby3@tarshish> References: <20200716220055.GA19603@embeddedor> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200716220055.GA19603@embeddedor> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_003810_088745_D9A391DE X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Gustavo, On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through This URL is likely to break at some point as documentation contest changes. Just refer to in kernel Documentation/process/deprecated.rst file. Other than that: Acked-by: Baruch Siach Thanks, baruch > Signed-off-by: Gustavo A. R. Silva > --- > drivers/i2c/busses/i2c-digicolor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c > index 332f00437479..f67639dc74b7 100644 > --- a/drivers/i2c/busses/i2c-digicolor.c > +++ b/drivers/i2c/busses/i2c-digicolor.c > @@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id) > break; > } > i2c->state = STATE_WRITE; > - /* fall through */ > + fallthrough; > case STATE_WRITE: > if (i2c->msgbuf_ptr < i2c->msg->len) > dc_i2c_write_buf(i2c); -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel