All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Petr Machata <petrm@mellanox.com>
Cc: netdev@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	David Ahern <dsahern@gmail.com>, Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH iproute2-next v3 1/2] tc: Look for blocks in qevents
Date: Fri, 17 Jul 2020 08:16:16 +0200	[thread overview]
Message-ID: <20200717061616.GE23663@nanopsycho.orion> (raw)
In-Reply-To: <212fc3e148879b60c08f6afceae77d78489914aa.1594917961.git.petrm@mellanox.com>

Thu, Jul 16, 2020 at 06:47:07PM CEST, petrm@mellanox.com wrote:
>When a list of filters at a given block is requested, tc first validates
>that the block exists before doing the filter query. Currently the
>validation routine checks ingress and egress blocks. But now that blocks
>can be bound to qevents as well, qevent blocks should be looked for as
>well.
>
>In order to support that, extend struct qdisc_util with a new callback,
>has_block. That should report whether, give the attributes in TCA_OPTIONS,
>a blocks with a given number is bound to a qevent. In
>tc_qdisc_block_exists_cb(), invoke that callback when set.
>
>Add a helper to the tc_qevent module that walks the list of qevents and
>looks for a given block. This is meant to be used by the individual qdiscs.
>
>Signed-off-by: Petr Machata <petrm@mellanox.com>

Reviewed-by: Jiri Pirko <jiri@mellanox.com>

  reply	other threads:[~2020-07-17  6:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 16:47 [PATCH iproute2-next v3 0/2] Support showing a block bound by qevent Petr Machata
2020-07-16 16:47 ` [PATCH iproute2-next v3 1/2] tc: Look for blocks in qevents Petr Machata
2020-07-17  6:16   ` Jiri Pirko [this message]
2020-07-16 16:47 ` [PATCH iproute2-next v3 2/2] tc: q_red: Implement has_block for RED Petr Machata
2020-07-20 16:37 ` [PATCH iproute2-next v3 0/2] Support showing a block bound by qevent David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717061616.GE23663@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=dsahern@gmail.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@mellanox.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.