Re: [PATCH bpf-next] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

From: Hangbin Liu <liuhangbin@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	ast@kernel.org
Subject: Re: [PATCH bpf-next] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL
Date: Fri, 17 Jul 2020 17:11:11 +0800	[thread overview]
Message-ID: <20200717091111.GJ2531@dhcp-12-153.nay.redhat.com> (raw)
In-Reply-To: <67a68a77-f287-1bb1-3221-24e8b3351958@iogearbox.net>

On Thu, Jul 16, 2020 at 12:28:16AM +0200, Daniel Borkmann wrote:
> > diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> > index c67c88ad35f8..9d4dbef3c943 100644
> > --- a/include/linux/bpf.h
> > +++ b/include/linux/bpf.h
> > @@ -253,6 +253,7 @@ enum bpf_arg_type {
> >   	ARG_PTR_TO_ALLOC_MEM,	/* pointer to dynamically allocated memory */
> >   	ARG_PTR_TO_ALLOC_MEM_OR_NULL,	/* pointer to dynamically allocated memory or NULL */
> >   	ARG_CONST_ALLOC_SIZE_OR_ZERO,	/* number of allocated bytes requested */
> > +	ARG_CONST_MAP_PTR_OR_NULL,	/* const argument used as pointer to bpf_map or NULL */
> >   };
> In combination with the set, this also needs test_verifier selftests in order to
> exercise BPF insn snippets for the good & [expected] bad case.

Hi Daniel,

I just come up with a question, how should I test it without no bpf
helper using it? Should I wait until the XDP multicast patch set merged?

Thanks
Hangbin