From: Thomas Huth <thuth@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 4/6] configure: Fix for running with --enable-werror on macOS
Date: Fri, 17 Jul 2020 11:56:03 +0200 [thread overview]
Message-ID: <20200717095605.27589-5-thuth@redhat.com> (raw)
In-Reply-To: <20200717095605.27589-1-thuth@redhat.com>
The configure script currently refuses to succeed when run on macOS
with --enable-werror:
ERROR: configure test passed without -Werror but failed with -Werror.
The information in config.log indicates:
config-temp/qemu-conf.c:3:55: error: control reaches end of non-void
function [-Werror,-Wreturn-type]
static void *f(void *p) { pthread_setname_np("QEMU"); }
^
And indeed, the return statement is missing here.
Fixes: 479a57475e ("util: Implement debug-threads for macOS")
Message-Id: <20200716055655.24507-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b751c853f5..e93836aaae 100755
--- a/configure
+++ b/configure
@@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
cat > $TMPC << EOF
#include <pthread.h>
-static void *f(void *p) { pthread_setname_np("QEMU"); }
+static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
int main(void)
{
pthread_t thread;
--
2.18.1
next prev parent reply other threads:[~2020-07-17 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 9:55 [PULL 0/6] Leak fixes for qtests + fuzzer CI Thomas Huth
2020-07-17 9:56 ` [PULL 1/6] qtest: bios-tables-test: fix a memory leak Thomas Huth
2020-07-17 9:56 ` [PULL 2/6] tests: qmp-cmd-test: fix " Thomas Huth
2020-07-17 9:56 ` [PULL 3/6] fuzz: Expect the cmdline in a freeable GString Thomas Huth
2020-07-17 9:56 ` Thomas Huth [this message]
2020-07-17 9:56 ` [PULL 5/6] qom: Plug memory leak in "info qom-tree" Thomas Huth
2020-07-17 9:56 ` [PULL 6/6] gitlab-ci.yml: Add fuzzer tests Thomas Huth
2020-07-17 13:58 ` [PULL 0/6] Leak fixes for qtests + fuzzer CI Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717095605.27589-5-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.