From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8810FC433E0 for ; Fri, 17 Jul 2020 14:02:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65C3F207EA for ; Fri, 17 Jul 2020 14:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbgGQOCV (ORCPT ); Fri, 17 Jul 2020 10:02:21 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50907 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbgGQOCV (ORCPT ); Fri, 17 Jul 2020 10:02:21 -0400 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C50FF1BF20D; Fri, 17 Jul 2020 14:02:18 +0000 (UTC) Date: Fri, 17 Jul 2020 16:02:18 +0200 From: Alexandre Belloni To: Lee Jones Cc: broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Radu Pirea , Nicolas Ferre , Ludovic Desroches Subject: Re: [PATCH v2 12/14] spi: spi-at91-usart: Remove unused OF table 'struct of_device_id' Message-ID: <20200717140218.GR3428@piout.net> References: <20200717135424.2442271-1-lee.jones@linaro.org> <20200717135424.2442271-13-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200717135424.2442271-13-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/07/2020 14:54:22+0100, Lee Jones wrote: > The only way this driver can be probed by MFD via its parent device. > > No other reference to 'microchip,at91sam9g45-usart-spi' exists in the kernel. > > Fixes the following W=1 kernel build warning(s): > > drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] > 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { > | ^~~~~~~~~~~~~~~~~~~~~ > > Cc: Radu Pirea > Cc: Nicolas Ferre > Cc: Ludovic Desroches > Suggested-by: Alexandre Belloni > Signed-off-by: Lee Jones Acked-by: Alexandre Belloni > --- > drivers/spi/spi-at91-usart.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c > index 88033422a42ae..8c8352625d232 100644 > --- a/drivers/spi/spi-at91-usart.c > +++ b/drivers/spi/spi-at91-usart.c > @@ -681,13 +681,6 @@ static const struct dev_pm_ops at91_usart_spi_pm_ops = { > at91_usart_spi_runtime_resume, NULL) > }; > > -static const struct of_device_id at91_usart_spi_dt_ids[] = { > - { .compatible = "microchip,at91sam9g45-usart-spi"}, > - { /* sentinel */} > -}; > - > -MODULE_DEVICE_TABLE(of, at91_usart_spi_dt_ids); > - > static struct platform_driver at91_usart_spi_driver = { > .driver = { > .name = "at91_usart_spi", > -- > 2.25.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA356C433E1 for ; Fri, 17 Jul 2020 14:03:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7ACA207EA for ; Fri, 17 Jul 2020 14:03:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MXymXa9v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7ACA207EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JmFrzV//8+y/pjvAAhsH9Qa6dga/Lf1MPYUfqUZiUyA=; b=MXymXa9v49UMAlk8GzOJUZVB8 ymdlE68kzoNdjgp10+qkCa4ls01mEROuQbxAte2t9PkonnkEmBY3PTp9zh0nPnpgTg0aHIvT4ydGh yp+wzVe+lWwebmKgkahtAAMqr2FEnoSU1/8lFrJHoHQ+VQ1tw1M3AgAQZqHsyMYYkFockjfl497fZ 0uSMYbyNCAh+W0IINIHDdbiff1foMzPaOLZPgkm1b9nCejHXMDAL9qpkhdgrkTdrRWQ/AdUTy1qCB mKCvSKLqueuNMqM/FXVWEeY2AStVFFnFGhHgLH+QZ+eqASOmJClR7MhO2mZoXJQFYebGFmiZN2Ayl uPzaOE8kQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQwU-000702-L0; Fri, 17 Jul 2020 14:02:26 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQwQ-0006xX-5q for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 14:02:24 +0000 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C50FF1BF20D; Fri, 17 Jul 2020 14:02:18 +0000 (UTC) Date: Fri, 17 Jul 2020 16:02:18 +0200 From: Alexandre Belloni To: Lee Jones Subject: Re: [PATCH v2 12/14] spi: spi-at91-usart: Remove unused OF table 'struct of_device_id' Message-ID: <20200717140218.GR3428@piout.net> References: <20200717135424.2442271-1-lee.jones@linaro.org> <20200717135424.2442271-13-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200717135424.2442271-13-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_100222_383145_B35201F9 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Radu Pirea , linux-kernel@vger.kernel.org, Ludovic Desroches , broonie@kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTcvMDcvMjAyMCAxNDo1NDoyMiswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gVGhlIG9ubHkg d2F5IHRoaXMgZHJpdmVyIGNhbiBiZSBwcm9iZWQgYnkgTUZEIHZpYSBpdHMgcGFyZW50IGRldmlj ZS4KPiAKPiBObyBvdGhlciByZWZlcmVuY2UgdG8gJ21pY3JvY2hpcCxhdDkxc2FtOWc0NS11c2Fy dC1zcGknIGV4aXN0cyBpbiB0aGUga2VybmVsLgo+IAo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0x IGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+IAo+ICBkcml2ZXJzL3NwaS9zcGktYXQ5MS11c2Fy dC5jOjY4NDozNDogd2FybmluZzog4oCYYXQ5MV91c2FydF9zcGlfZHRfaWRz4oCZIGRlZmluZWQg YnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJpYWJsZT1dCj4gIDY4NCB8IHN0YXRpYyBj b25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGF0OTFfdXNhcnRfc3BpX2R0X2lkc1tdID0gewo+ICB8 IF5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+IAo+IENjOiBSYWR1IFBpcmVhIDxyYWR1X25pY29sYWUu cGlyZWFAdXBiLnJvPgo+IENjOiBOaWNvbGFzIEZlcnJlIDxuaWNvbGFzLmZlcnJlQG1pY3JvY2hp cC5jb20+Cj4gQ2M6IEx1ZG92aWMgRGVzcm9jaGVzIDxsdWRvdmljLmRlc3JvY2hlc0BtaWNyb2No aXAuY29tPgo+IFN1Z2dlc3RlZC1ieTogQWxleGFuZHJlIEJlbGxvbmkgPGFsZXhhbmRyZS5iZWxs b25pQGJvb3RsaW4uY29tPgo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxp bmFyby5vcmc+CkFja2VkLWJ5OiBBbGV4YW5kcmUgQmVsbG9uaSA8YWxleGFuZHJlLmJlbGxvbmlA Ym9vdGxpbi5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL3NwaS9zcGktYXQ5MS11c2FydC5jIHwgNyAt LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3NwaS9zcGktYXQ5MS11c2FydC5jIGIvZHJpdmVycy9zcGkvc3BpLWF0OTEtdXNh cnQuYwo+IGluZGV4IDg4MDMzNDIyYTQyYWUuLjhjODM1MjYyNWQyMzIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9zcGkvc3BpLWF0OTEtdXNhcnQuYwo+ICsrKyBiL2RyaXZlcnMvc3BpL3NwaS1hdDkx LXVzYXJ0LmMKPiBAQCAtNjgxLDEzICs2ODEsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRldl9w bV9vcHMgYXQ5MV91c2FydF9zcGlfcG1fb3BzID0gewo+ICAJCQkgICBhdDkxX3VzYXJ0X3NwaV9y dW50aW1lX3Jlc3VtZSwgTlVMTCkKPiAgfTsKPiAgCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2Zf ZGV2aWNlX2lkIGF0OTFfdXNhcnRfc3BpX2R0X2lkc1tdID0gewo+IC0JeyAuY29tcGF0aWJsZSA9 ICJtaWNyb2NoaXAsYXQ5MXNhbTlnNDUtdXNhcnQtc3BpIn0sCj4gLQl7IC8qIHNlbnRpbmVsICov fQo+IC19Owo+IC0KPiAtTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgYXQ5MV91c2FydF9zcGlfZHRf aWRzKTsKPiAtCj4gIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGF0OTFfdXNhcnRfc3Bp X2RyaXZlciA9IHsKPiAgCS5kcml2ZXIgPSB7Cj4gIAkJLm5hbWUgPSAiYXQ5MV91c2FydF9zcGki LAo+IC0tIAo+IDIuMjUuMQo+IAoKLS0gCkFsZXhhbmRyZSBCZWxsb25pLCBCb290bGluCkVtYmVk ZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=