On Fri, Jul 17, 2020 at 09:32:21AM +0800, miaoqinglang wrote: > > 在 2020/7/16 21:34, Thierry Reding 写道: > > On Thu, Jul 16, 2020 at 05:03:23PM +0800, Qinglang Miao wrote: > > > From: Yongqiang Liu > > > > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > > > > > Signed-off-by: Yongqiang Liu > > > --- > > > drivers/gpu/host1x/debug.c | 28 ++++------------------------ > > > 1 file changed, 4 insertions(+), 24 deletions(-) > > This doesn't apply. Can you please resend, based on something like > > linux-next? > > > > Thanks, > > Thierry > Hi, Thierry > >   Sorry I didn't mention it in commit log, but this patch is based on > linux-next where commit <4d4901c6d7> has switched over direct  seq_read > method calls to seq_read_iter, this is why there's conflict in  your apply. > >   Do you think I should send a new patch based on 5.8rc? No need to. I'm about to send out the pull request for v5.9-rc1, so I'll just defer this to v5.10 since it doesn't look like it's anything urgent. Thierry