From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AADC433E1 for ; Fri, 17 Jul 2020 20:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A61420775 for ; Fri, 17 Jul 2020 20:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZzQEnJsN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbgGQUR3 (ORCPT ); Fri, 17 Jul 2020 16:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726771AbgGQUR2 (ORCPT ); Fri, 17 Jul 2020 16:17:28 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F0A3C0619D3 for ; Fri, 17 Jul 2020 13:17:28 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id u185so5931253pfu.1 for ; Fri, 17 Jul 2020 13:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iywrvyPBUDOgHRTdq53ACuS34hQViRNteLGcc1mvGYA=; b=ZzQEnJsNJiKD1+yaEqf4xcmZtSkJVW4gUh/WVumhUke25claBLvOg39F57AjX/yF+t IvyVWmqsEW1BG1/7ICm+lb5tIZHbhj6w4nT+BPSJ6CibQrPdK+8W8oAm9ZV7+CSh3o1L 9SBC3nq8OLCaa+A3fSH2QIaFY3KBeCMeHL73w5dOYvvE1PpkBGOCFRx8y6ZlQ31K2kAi ZxpJ9UEIW9v0vrZQNDYA2jBFcqpLUTC5ham8evExg5OaVhsyNcwqAZTR3fjV6lHUUC3g enqTg+ha9FChfUqjoDjg6uCiikxsYcZBbiKoKMsgyjIjrKE6ubdCgM7ABH06BNxm421j xWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iywrvyPBUDOgHRTdq53ACuS34hQViRNteLGcc1mvGYA=; b=lUQVO2u4VzBRZa1FIM6r9gkeZhKrxPNdgZwIxT5QDbTN7wfAvqxVepIvG+cq9uIj+K 9DEqDo92ZlmnPi0lBI/aI4ls9ojLfXGpoBZ+IR2D/D99xsViN9WTm5HAnhsTqWe+CrwM RIqrz2CzYOxkley/emd20sObjdt9/2xdG5ktOAbkhtVl3K0N4EyfqUyyjKyLMK6BCpo7 HQLWNgR5S4wiHV1CREkFIdWlSMB60JOx+VS4CA52KhyKAzv7cTS29E7Ty2bLdSLYUG7J iXKL466Wip+dFNfd4SrGZzTW4rKIw4Xvpotnj6RCpv8Y2ngb1PZBhZJEwX1ERZsGHPkA m5JA== X-Gm-Message-State: AOAM533IKBaEE35fy88jhJXYVXLdImyAzpVdNPN0imk6UteAWmJU2LBJ yVx+qCL2iPMNBwD1MC2hyitPFQ== X-Google-Smtp-Source: ABdhPJz7Sa8W0Soyk0M+slHFD6+b0FyIRfrfoarpP+teJuhSDo13gE34xXY80gmRSxgao04OxKIvOg== X-Received: by 2002:a63:c150:: with SMTP id p16mr10228264pgi.141.1595017047679; Fri, 17 Jul 2020 13:17:27 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id w12sm3084248pjb.18.2020.07.17.13.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 13:17:26 -0700 (PDT) Date: Fri, 17 Jul 2020 13:15:25 -0700 From: Bjorn Andersson To: Lee Jones Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Andy Gross , Linus Walleij , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Message-ID: <20200717201525.GK388985@builder.lan> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-27-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717165538.3275050-27-lee.jones@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 17 Jul 09:55 PDT 2020, Lee Jones wrote: > Kerneldoc is only suitable for documenting functions and struct/enums. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Linus Walleij > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson > --- > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > index c599ffa45a04c..cd5fa30e77df4 100644 > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > @@ -120,7 +120,7 @@ > #define ADC_ARB_USRP_DATA0 0x19D > #define ADC_ARB_USRP_DATA1 0x19C > > -/** > +/* > * Physical channels which MUST exist on all PM variants in order to provide > * proper reference points for calibration. > * > @@ -388,6 +388,7 @@ struct pm8xxx_chan_info { > * struct pm8xxx_xoadc - state container for the XOADC > * @dev: pointer to device > * @map: regmap to access registers > + * @variant: XOADC variant characteristics > * @vref: reference voltage regulator > * characteristics of the channels, and sensible default settings > * @nchans: number of channels, configured by the device tree > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2878CC433E6 for ; Fri, 17 Jul 2020 20:18:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9B3320704 for ; Fri, 17 Jul 2020 20:18:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PiZew5da"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZzQEnJsN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9B3320704 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JGrkv2xtDwb8Gn3OwtNhzK7j7A9x340HtE240o43LgU=; b=PiZew5da+on5f4/IMYsjoEur8 GHdBcRKAu5trgeVwRW85CVsnZCXsjOM3tMNXR9YtjSokZo7G7VtgSEv7ytw9NY3RV+bLrfDVEN9cf orS5nYRf1+Ckk1xYsF07+jguYx0w75m2jtLh/5SAFOUz8YLo+ex56CfDJr+LqSpetUR8mrY4RtDNi 085rgH2a8cDPNf+s44CKZkZ3GRvH1XuKza4NtwjY0FGS1wEMFY5MnneY2Oq3LX2G67J7/ZoSL0E5K xTQ8Ec2NAo9AhGOdVxCB0zi2Fja4onZ36paDRCEoApS9b+GWpvZ9U0ZLDxvMFG8eX2QUyrnBMmKd4 iwtnJiw4w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwWnU-0006rD-I4; Fri, 17 Jul 2020 20:17:32 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwWnR-0006qS-Rz for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 20:17:31 +0000 Received: by mail-pg1-x542.google.com with SMTP id z5so7201237pgb.6 for ; Fri, 17 Jul 2020 13:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iywrvyPBUDOgHRTdq53ACuS34hQViRNteLGcc1mvGYA=; b=ZzQEnJsNJiKD1+yaEqf4xcmZtSkJVW4gUh/WVumhUke25claBLvOg39F57AjX/yF+t IvyVWmqsEW1BG1/7ICm+lb5tIZHbhj6w4nT+BPSJ6CibQrPdK+8W8oAm9ZV7+CSh3o1L 9SBC3nq8OLCaa+A3fSH2QIaFY3KBeCMeHL73w5dOYvvE1PpkBGOCFRx8y6ZlQ31K2kAi ZxpJ9UEIW9v0vrZQNDYA2jBFcqpLUTC5ham8evExg5OaVhsyNcwqAZTR3fjV6lHUUC3g enqTg+ha9FChfUqjoDjg6uCiikxsYcZBbiKoKMsgyjIjrKE6ubdCgM7ABH06BNxm421j xWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iywrvyPBUDOgHRTdq53ACuS34hQViRNteLGcc1mvGYA=; b=NeBcmfsWC4TmsiMJH/7ad0Rt0OQrzd+HN5OrMHFEZiPQSw4lCL/PTelvb5XlUb0nCZ fZPLx/mt3mT+qO4fBOCbrgScJrnrlLWBG1ZtnyAMM4NdP99gg8y+3WxWCF6ps+GU3alQ Hvr2bX0ZhgnadIQKzmhGqUnYxXNPdZ78+VCjpLowEF/tvBB5fO+BmeJij4UiJ67KbGpr L+dBitvatKt35CFBJdCZqPPyhfEHP2pd+NFodzzltZQ8IRUKdgkfO7nwHE2REzk77gPF w+BeGIeHszmm3cUVzFPq0dWCXK6BWk12NSw5/s6IkmfGlv/nGhWtC3yiYlAvuETp7fti svlw== X-Gm-Message-State: AOAM530x4Z+JzZGvtzqD1JvHQTlnjnI3LAvJEZswze0KNYvO783m6eoV 8WzdoIUPnGzwmY0HsIMyyj314w== X-Google-Smtp-Source: ABdhPJz7Sa8W0Soyk0M+slHFD6+b0FyIRfrfoarpP+teJuhSDo13gE34xXY80gmRSxgao04OxKIvOg== X-Received: by 2002:a63:c150:: with SMTP id p16mr10228264pgi.141.1595017047679; Fri, 17 Jul 2020 13:17:27 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id w12sm3084248pjb.18.2020.07.17.13.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 13:17:26 -0700 (PDT) Date: Fri, 17 Jul 2020 13:15:25 -0700 From: Bjorn Andersson To: Lee Jones Subject: Re: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Message-ID: <20200717201525.GK388985@builder.lan> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-27-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200717165538.3275050-27-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_161730_243953_F79B12BF X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, Andy Gross , jic23@kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 17 Jul 09:55 PDT 2020, Lee Jones wrote: > Kerneldoc is only suitable for documenting functions and struct/enums. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL' > drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Linus Walleij > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson > --- > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > index c599ffa45a04c..cd5fa30e77df4 100644 > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > @@ -120,7 +120,7 @@ > #define ADC_ARB_USRP_DATA0 0x19D > #define ADC_ARB_USRP_DATA1 0x19C > > -/** > +/* > * Physical channels which MUST exist on all PM variants in order to provide > * proper reference points for calibration. > * > @@ -388,6 +388,7 @@ struct pm8xxx_chan_info { > * struct pm8xxx_xoadc - state container for the XOADC > * @dev: pointer to device > * @map: regmap to access registers > + * @variant: XOADC variant characteristics > * @vref: reference voltage regulator > * characteristics of the channels, and sensible default settings > * @nchans: number of channels, configured by the device tree > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel