From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1C8C433DF for ; Fri, 17 Jul 2020 14:06:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFABE22CAF for ; Fri, 17 Jul 2020 14:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594994793; bh=idhd2mun2o3KTZfXKc7yxApyqOFeBVXhlYMrKvNie5U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=omqZqlSpKI8SWaIZtvbzlspaIqjXixGrVYTTGvTK28uXWc6V7+3P7P9T5SzUmGsWu hsmEnKdRUwR/T0CNpoK7Af5WgOvzlL754QeLVb2nYVH8zkpOWrXZzfhuXeVFasWcrH EIC8k+kGoCDfwrwg3hBjRsaInlaViq1ij5TnoZkU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgGQOGc (ORCPT ); Fri, 17 Jul 2020 10:06:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:54612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgGQOGa (ORCPT ); Fri, 17 Jul 2020 10:06:30 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22AFE2067D; Fri, 17 Jul 2020 14:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594994790; bh=idhd2mun2o3KTZfXKc7yxApyqOFeBVXhlYMrKvNie5U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KaQrFt+YhFkTXtEgafkFEb1WYvRfdZ4Kw0ki3VoubVwnrLGVDz8sU/1yskahu7eCy 7gQmmSH6lOqgTLjYUK+DloD0v5HMyHQie7V+qLc+Edn8y8RmecTmQSPolQQwRh4bK3 IUvtlU6lhpCZpunU3IsRYhQnTKqj0S8gGlEmwpSY= Date: Fri, 17 Jul 2020 23:06:22 +0900 From: Masami Hiramatsu To: Joerg Roedel Cc: x86@kernel.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 10/75] x86/insn: Add insn_has_rep_prefix() helper Message-Id: <20200717230622.5be651b71711368acbfe6bb0@kernel.org> In-Reply-To: <20200714120917.11253-11-joro@8bytes.org> References: <20200714120917.11253-1-joro@8bytes.org> <20200714120917.11253-11-joro@8bytes.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jul 2020 14:08:12 +0200 Joerg Roedel wrote: > From: Joerg Roedel > > Add a function to check whether an instruction has a REP prefix. This looks good to me. Reviewed-by: Masami Hiramatsu Thank you, > > Signed-off-by: Joerg Roedel > --- > arch/x86/include/asm/insn-eval.h | 1 + > arch/x86/lib/insn-eval.c | 24 ++++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/arch/x86/include/asm/insn-eval.h b/arch/x86/include/asm/insn-eval.h > index f748f57f1491..a0f839aa144d 100644 > --- a/arch/x86/include/asm/insn-eval.h > +++ b/arch/x86/include/asm/insn-eval.h > @@ -15,6 +15,7 @@ > #define INSN_CODE_SEG_OPND_SZ(params) (params & 0xf) > #define INSN_CODE_SEG_PARAMS(oper_sz, addr_sz) (oper_sz | (addr_sz << 4)) > > +bool insn_has_rep_prefix(struct insn *insn); > void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs); > int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs); > int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs); > diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c > index a8ac5c5e94f0..8ed9d645259c 100644 > --- a/arch/x86/lib/insn-eval.c > +++ b/arch/x86/lib/insn-eval.c > @@ -53,6 +53,30 @@ static bool is_string_insn(struct insn *insn) > } > } > > +/** > + * insn_has_rep_prefix() - Determine if instruction has a REP prefix > + * @insn: Instruction containing the prefix to inspect > + * > + * Returns: > + * > + * true if the instruction has a REP prefix, false if not. > + */ > +bool insn_has_rep_prefix(struct insn *insn) > +{ > + int i; > + > + insn_get_prefixes(insn); > + > + for (i = 0; i < insn->prefixes.nbytes; i++) { > + insn_byte_t p = insn->prefixes.bytes[i]; > + > + if (p == 0xf2 || p == 0xf3) > + return true; > + } > + > + return false; > +} > + > /** > * get_seg_reg_override_idx() - obtain segment register override index > * @insn: Valid instruction with segment override prefixes > -- > 2.27.0 > -- Masami Hiramatsu