From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 06/15] scsi: esas2r: use generic power management
Date: Sat, 18 Jul 2020 04:01:56 +0800 [thread overview]
Message-ID: <202007180316.TH4wEywu%lkp@intel.com> (raw)
In-Reply-To: <20200717063438.175022-7-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6484 bytes --]
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.8-rc5]
[cannot apply to scsi/for-next mkp-scsi/for-next next-20200717]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/scsi-use-generic-power-management/20200717-144215
base: 11ba468877bb23f28956a35e896356252d63c983
config: arm64-randconfig-r004-20200716 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/esas2r/esas2r_init.c:696:6: warning: variable 'rez' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (test_bit(AF2_IRQ_CLAIMED, &a->flags2)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/esas2r/esas2r_init.c:712:10: note: uninitialized use occurs here
rez);
^~~
drivers/scsi/esas2r/esas2r_init.c:696:2: note: remove the 'if' if its condition is always false
if (test_bit(AF2_IRQ_CLAIMED, &a->flags2)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/esas2r/esas2r_init.c:661:9: note: initialize the variable 'rez' to silence this warning
int rez;
^
= 0
1 warning generated.
vim +696 drivers/scsi/esas2r/esas2r_init.c
26780d9e12edf4 Bradley Grove 2013-08-23 656
d045ddf3e97346 Vaibhav Gupta 2020-07-17 657 static int __maybe_unused esas2r_resume(struct device *dev)
26780d9e12edf4 Bradley Grove 2013-08-23 658 {
d045ddf3e97346 Vaibhav Gupta 2020-07-17 659 struct Scsi_Host *host = dev_get_drvdata(dev);
26780d9e12edf4 Bradley Grove 2013-08-23 660 struct esas2r_adapter *a = (struct esas2r_adapter *)host->hostdata;
26780d9e12edf4 Bradley Grove 2013-08-23 661 int rez;
26780d9e12edf4 Bradley Grove 2013-08-23 662
d045ddf3e97346 Vaibhav Gupta 2020-07-17 663 esas2r_log_dev(ESAS2R_LOG_INFO, dev, "resuming adapter()");
d045ddf3e97346 Vaibhav Gupta 2020-07-17 664 esas2r_log_dev(ESAS2R_LOG_INFO, dev,
d045ddf3e97346 Vaibhav Gupta 2020-07-17 665 "device_wakeup_disable() "
26780d9e12edf4 Bradley Grove 2013-08-23 666 "called");
d045ddf3e97346 Vaibhav Gupta 2020-07-17 667 device_wakeup_disable(dev);
26780d9e12edf4 Bradley Grove 2013-08-23 668
26780d9e12edf4 Bradley Grove 2013-08-23 669 if (!a) {
26780d9e12edf4 Bradley Grove 2013-08-23 670 rez = -ENODEV;
26780d9e12edf4 Bradley Grove 2013-08-23 671 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 672 }
26780d9e12edf4 Bradley Grove 2013-08-23 673
26780d9e12edf4 Bradley Grove 2013-08-23 674 if (esas2r_map_regions(a) != 0) {
26780d9e12edf4 Bradley Grove 2013-08-23 675 esas2r_log(ESAS2R_LOG_CRIT, "could not re-map PCI regions!");
26780d9e12edf4 Bradley Grove 2013-08-23 676 rez = -ENOMEM;
26780d9e12edf4 Bradley Grove 2013-08-23 677 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 678 }
26780d9e12edf4 Bradley Grove 2013-08-23 679
26780d9e12edf4 Bradley Grove 2013-08-23 680 /* Set up interupt mode */
26780d9e12edf4 Bradley Grove 2013-08-23 681 esas2r_setup_interrupts(a, a->intr_mode);
26780d9e12edf4 Bradley Grove 2013-08-23 682
26780d9e12edf4 Bradley Grove 2013-08-23 683 /*
26780d9e12edf4 Bradley Grove 2013-08-23 684 * Disable chip interrupts to prevent spurious interrupts until we
26780d9e12edf4 Bradley Grove 2013-08-23 685 * claim the IRQ.
26780d9e12edf4 Bradley Grove 2013-08-23 686 */
26780d9e12edf4 Bradley Grove 2013-08-23 687 esas2r_disable_chip_interrupts(a);
26780d9e12edf4 Bradley Grove 2013-08-23 688 if (!esas2r_power_up(a, true)) {
26780d9e12edf4 Bradley Grove 2013-08-23 689 esas2r_debug("yikes, esas2r_power_up failed");
26780d9e12edf4 Bradley Grove 2013-08-23 690 rez = -ENOMEM;
26780d9e12edf4 Bradley Grove 2013-08-23 691 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 692 }
26780d9e12edf4 Bradley Grove 2013-08-23 693
26780d9e12edf4 Bradley Grove 2013-08-23 694 esas2r_claim_interrupts(a);
26780d9e12edf4 Bradley Grove 2013-08-23 695
9588d24e36003b Bradley Grove 2013-10-01 @696 if (test_bit(AF2_IRQ_CLAIMED, &a->flags2)) {
26780d9e12edf4 Bradley Grove 2013-08-23 697 /*
26780d9e12edf4 Bradley Grove 2013-08-23 698 * Now that system interrupt(s) are claimed, we can enable
26780d9e12edf4 Bradley Grove 2013-08-23 699 * chip interrupts.
26780d9e12edf4 Bradley Grove 2013-08-23 700 */
26780d9e12edf4 Bradley Grove 2013-08-23 701 esas2r_enable_chip_interrupts(a);
26780d9e12edf4 Bradley Grove 2013-08-23 702 esas2r_kickoff_timer(a);
26780d9e12edf4 Bradley Grove 2013-08-23 703 } else {
26780d9e12edf4 Bradley Grove 2013-08-23 704 esas2r_debug("yikes, unable to claim IRQ");
26780d9e12edf4 Bradley Grove 2013-08-23 705 esas2r_log(ESAS2R_LOG_CRIT, "could not re-claim IRQ!");
26780d9e12edf4 Bradley Grove 2013-08-23 706 rez = -ENOMEM;
26780d9e12edf4 Bradley Grove 2013-08-23 707 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 708 }
26780d9e12edf4 Bradley Grove 2013-08-23 709
26780d9e12edf4 Bradley Grove 2013-08-23 710 error_exit:
d045ddf3e97346 Vaibhav Gupta 2020-07-17 711 esas2r_log_dev(ESAS2R_LOG_CRIT, dev, "esas2r_resume(): %d",
26780d9e12edf4 Bradley Grove 2013-08-23 712 rez);
26780d9e12edf4 Bradley Grove 2013-08-23 713 return rez;
26780d9e12edf4 Bradley Grove 2013-08-23 714 }
26780d9e12edf4 Bradley Grove 2013-08-23 715
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38707 bytes --]
next prev parent reply other threads:[~2020-07-17 20:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:34 [PATCH v1 00/15] scsi: use generic power management Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 01/15] scsi: megaraid_sas: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 02/15] scsi: aacraid: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 03/15] scsi: aic7xxx: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 04/15] scsi: aic79xx: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 05/15] scsi: arcmsr: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 06/15] scsi: esas2r: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 20:01 ` kernel test robot [this message]
2020-07-17 6:34 ` [PATCH v1 07/15] scsi: hisi_sas_v3_hw: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 6:16 ` chenxiang (M)
2020-07-20 6:16 ` [Linux-kernel-mentees] " chenxiang (M)
2020-07-20 6:32 ` Vaibhav Gupta
2020-07-20 6:32 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 08/15] scsi: mpt3sas_scsih: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 09/15] scsi: lpfc: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 10/15] scsi: pm_8001: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 11/15] scsi: hpsa: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 12/15] scsi: 3w-9xxx: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 13/15] scsi: 3w-sas: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 14/15] scsi: mvumi: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 6:34 ` [PATCH v1 15/15] scsi: pmcraid: " Vaibhav Gupta
2020-07-17 6:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-18 7:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007180316.TH4wEywu%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.