From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79773C433E1 for ; Sat, 18 Jul 2020 14:30:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C7B42076A for ; Sat, 18 Jul 2020 14:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595082627; bh=hSj5ozE6nlmBDB2UvoDj+PMby8N54ruWX+quUPUBqqY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=SIfoDm0BeZH/+ky6smakcrx8QQHqDNz0bJQSE+/jJgBZcjgmxqpzvykqrEOV+53Kf wOlEffnopd/WiC42qOci0TOjBVNA+39QB8Y5oA1oFTFoeb3IfRtpJ+d6XHJVXV35iB PAsGZGzOD/c/W25q9aD11k5T1nChhLyqhHy3V09k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbgGROa0 (ORCPT ); Sat, 18 Jul 2020 10:30:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:58056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbgGROaZ (ORCPT ); Sat, 18 Jul 2020 10:30:25 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D052E2064B; Sat, 18 Jul 2020 14:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595082625; bh=hSj5ozE6nlmBDB2UvoDj+PMby8N54ruWX+quUPUBqqY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bvU9gLcHyzfQcWQlJ0h008mfH1DpUBduRBPdjsbl5AKlCNPKDgX+EW8m80mfdVpZu A3eycEbsJxzIUhb/gEHGMTEDkX7h36ZBAAwyRzLjCh5MVAqSD+EqhOkq6jKL4Gfpl/ nbd0IUxK2NuyMGkubuxdZKYue+BuU/psGHhgKPl8= Date: Sat, 18 Jul 2020 15:30:20 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich Subject: Re: [PATCH 04/30] iio: adc: ad7298: Demote obvious misuse of kerneldoc to standard comment blocks Message-ID: <20200718153020.643f55c6@archlinux> In-Reply-To: <20200716135928.1456727-5-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-5-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:02 +0100 Lee Jones wrote: > No attempt has been made to document either of the demoted functions here. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/ad7298.c:106: warning: Function parameter or member 'indio_dev' not described in 'ad7298_update_scan_mode' > drivers/iio/adc/ad7298.c:106: warning: Function parameter or member 'active_scan_mask' not described in 'ad7298_update_scan_mode' > drivers/iio/adc/ad7298.c:154: warning: Function parameter or member 'irq' not described in 'ad7298_trigger_handler' > drivers/iio/adc/ad7298.c:154: warning: Function parameter or member 'p' not described in 'ad7298_trigger_handler' > > Cc: Michael Hennerich > Signed-off-by: Lee Jones As both are static, no particular reason they should have kernel-doc comments so agreed we are better fixing this one by demoting rather than adding the missing stuff. Applied. > --- > drivers/iio/adc/ad7298.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c > index dc8d8c5f6ad36..006b6f63cf4e8 100644 > --- a/drivers/iio/adc/ad7298.c > +++ b/drivers/iio/adc/ad7298.c > @@ -98,9 +98,9 @@ static const struct iio_chan_spec ad7298_channels[] = { > IIO_CHAN_SOFT_TIMESTAMP(8), > }; > > -/** > +/* > * ad7298_update_scan_mode() setup the spi transfer buffer for the new scan mask > - **/ > + */ > static int ad7298_update_scan_mode(struct iio_dev *indio_dev, > const unsigned long *active_scan_mask) > { > @@ -144,12 +144,12 @@ static int ad7298_update_scan_mode(struct iio_dev *indio_dev, > return 0; > } > > -/** > +/* > * ad7298_trigger_handler() bh of trigger launched polling to ring buffer > * > * Currently there is no option in this driver to disable the saving of > * timestamps within the ring. > - **/ > + */ > static irqreturn_t ad7298_trigger_handler(int irq, void *p) > { > struct iio_poll_func *pf = p; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85074C433E1 for ; Sat, 18 Jul 2020 14:31:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 502132064B for ; Sat, 18 Jul 2020 14:31:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LrEUDACs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bvU9gLcH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 502132064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8vL8cKYkORD3/XtZVndKtZOmbvSoy2Eg5SlUIyWbXbE=; b=LrEUDACs6FnUHKg1XWriV5O1Z pWc4ZA77sgA/4gXfdx0mJ//X8jOejEzTtXc3kKblPQi4LfCObiNjNHbKJ1Kk6ogCvyd/LrvOZm6+j 4DMWeWX+LuX43rdA6rFdxJNrx0cZ+6eyTvHw21osyagtdKSMVlPW+iBF0LA8fvz8uwNOm2sjrV1Ny EYwf6pPVb7555M0Rz7yeteb8fE0DmvFgo1fGmcFsoHKZHl/OAZi8AZIt8oEY/PKETuGZ+fjD94JSI z3JJaDOEoOFSKtAXMeL6Hwhw09WQ6JmZ0FPyPPOBgkaILkHP8sHKQ7elEhmViBw6VtWW3clJkmLDb dmRHOQOBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwnrB-00026q-2S; Sat, 18 Jul 2020 14:30:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwnr8-00025q-11 for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 14:30:26 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D052E2064B; Sat, 18 Jul 2020 14:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595082625; bh=hSj5ozE6nlmBDB2UvoDj+PMby8N54ruWX+quUPUBqqY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bvU9gLcHyzfQcWQlJ0h008mfH1DpUBduRBPdjsbl5AKlCNPKDgX+EW8m80mfdVpZu A3eycEbsJxzIUhb/gEHGMTEDkX7h36ZBAAwyRzLjCh5MVAqSD+EqhOkq6jKL4Gfpl/ nbd0IUxK2NuyMGkubuxdZKYue+BuU/psGHhgKPl8= Date: Sat, 18 Jul 2020 15:30:20 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 04/30] iio: adc: ad7298: Demote obvious misuse of kerneldoc to standard comment blocks Message-ID: <20200718153020.643f55c6@archlinux> In-Reply-To: <20200716135928.1456727-5-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-5-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_103026_189203_DE9CA696 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:02 +0100 Lee Jones wrote: > No attempt has been made to document either of the demoted functions here. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/ad7298.c:106: warning: Function parameter or member 'indio_dev' not described in 'ad7298_update_scan_mode' > drivers/iio/adc/ad7298.c:106: warning: Function parameter or member 'active_scan_mask' not described in 'ad7298_update_scan_mode' > drivers/iio/adc/ad7298.c:154: warning: Function parameter or member 'irq' not described in 'ad7298_trigger_handler' > drivers/iio/adc/ad7298.c:154: warning: Function parameter or member 'p' not described in 'ad7298_trigger_handler' > > Cc: Michael Hennerich > Signed-off-by: Lee Jones As both are static, no particular reason they should have kernel-doc comments so agreed we are better fixing this one by demoting rather than adding the missing stuff. Applied. > --- > drivers/iio/adc/ad7298.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c > index dc8d8c5f6ad36..006b6f63cf4e8 100644 > --- a/drivers/iio/adc/ad7298.c > +++ b/drivers/iio/adc/ad7298.c > @@ -98,9 +98,9 @@ static const struct iio_chan_spec ad7298_channels[] = { > IIO_CHAN_SOFT_TIMESTAMP(8), > }; > > -/** > +/* > * ad7298_update_scan_mode() setup the spi transfer buffer for the new scan mask > - **/ > + */ > static int ad7298_update_scan_mode(struct iio_dev *indio_dev, > const unsigned long *active_scan_mask) > { > @@ -144,12 +144,12 @@ static int ad7298_update_scan_mode(struct iio_dev *indio_dev, > return 0; > } > > -/** > +/* > * ad7298_trigger_handler() bh of trigger launched polling to ring buffer > * > * Currently there is no option in this driver to disable the saving of > * timestamps within the ring. > - **/ > + */ > static irqreturn_t ad7298_trigger_handler(int irq, void *p) > { > struct iio_poll_func *pf = p; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel