From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3F7C433E4 for ; Sat, 18 Jul 2020 14:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76E272076A for ; Sat, 18 Jul 2020 14:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595083331; bh=XBulFzLGPXfZn/iFjNwycrLQNdoeQbsMF6p0DhRyzB4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2Pi7WrTe+W+4lauLBzMbMbqZXZ8nyH2UeJFis5WkZRej97P1+MzorU9pQEypU+TPe yKl4CIdxCUNf+KwIOfSorSFkQdQ+0dbRNkpAKuwVGsyyw5y1nvThj+K8De/Un2F0MX oj3bP99ZZh1+CxOW22QL+Awtp+CwvYYV/2ILtsa4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbgGROmK (ORCPT ); Sat, 18 Jul 2020 10:42:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:60890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbgGROmJ (ORCPT ); Sat, 18 Jul 2020 10:42:09 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C2D22064B; Sat, 18 Jul 2020 14:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595083328; bh=XBulFzLGPXfZn/iFjNwycrLQNdoeQbsMF6p0DhRyzB4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e2S1JMVG2nQgwAIsMY2pN5uSL2c1YL0L29xSaNiqlsXGxFguOGEvAEUZqLIewKfXN sdECk/OMdmTCggnhXnJShrT5XusLlq8inAhWEIOpiwYrE1C2CtLYOOYw2QPZy2fUY8 3S541EB0k/dqD2MGFEs8SFe9OT3SZ+5haRHViFvw= Date: Sat, 18 Jul 2020 15:42:04 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 00/30] First batch of W=1 fixes for IIO Message-ID: <20200718154204.280fcb83@archlinux> In-Reply-To: <20200716135928.1456727-1-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:58:58 +0100 Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Thanks for these. One general comment is I'd have appreciated a spot of grouping to bring a particular group of identical problems together in the series. Example being the @lock(:) ones in this set. It doesn't matter that much though. I'm just being fussy :) Jonathan > > Lee Jones (30): > iio: adc: ad_sigma_delta: Remove unused variable 'ret' > iio: accel: bma220_spi: Do not define 'struct acpi_device_id' when > !CONFIG_ACPI > iio: common: ms_sensors: ms_sensors_i2c: Fix misspelling of parameter > 'client' > iio: adc: ad7298: Demote obvious misuse of kerneldoc to standard > comment blocks > iio: chemical: sgp30: Add description for sgp_read_cmd()'s > 'duration_us' > iio: adc: ad7923: Demote obvious misuse of kerneldoc to standard > comment blocks > iio: dac: ad5360: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5380: Fix kerneldoc attribute formatting for 'lock' > iio: dummy: iio_simple_dummy: Demote unworthy kerneldocs and correct > misspelling > iio: dummy: iio_simple_dummy: Add newline after function-end > iio: dac: ad5421: Fix kerneldoc attribute formatting for 'lock' > iio: gyro: adis16080: Fix formatting issue and compiler attribute > ordering > iio: dummy: iio_simple_dummy_events: Demote file header and supply > descriptions for val2 params > iio: dac: ad5064: Value returned by ad5064_vref_name may not be 'const > * const' > iio: dummy: iio_dummy_evgen: Demote file header and supply description > for 'irq_sim_domain' > iio: adc: ad7887: Demote seemingly unintentional kerneldoc header > iio: adc: ad7949: Fix misspelling issue and compiler attribute > ordering > iio: dummy: iio_simple_dummy_buffer: Demote file header and correct > misspelling > iio: dac: ad5064: Fix a few kerneldoc misdemeanours > iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote > unworthy kerneldocs > iio: dac: ad5449: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5755: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5758: Move and fix-up kerneldoc header and demote unworthy > kerneldoc > iio: dac: ad5761: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5764: Fix misdocumenting and formatting error > iio: dac: ad5791: Complete 'struct ad5791_chip_info' documentation > iio: light: cm32181: Fix formatting and docrot issues in > cm32181_acpi_get_cpm() > iio: magnetometer: mmc35240: Fix function header formatting > iio: imu: kmx61: Fix formatting in kerneldoc function headers > iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder > compiler attribute > > drivers/iio/accel/bma220_spi.c | 2 ++ > drivers/iio/adc/ad7298.c | 8 ++++---- > drivers/iio/adc/ad7887.c | 2 +- > drivers/iio/adc/ad7923.c | 8 ++++---- > drivers/iio/adc/ad7949.c | 4 ++-- > drivers/iio/adc/ad_sigma_delta.c | 7 ++----- > drivers/iio/chemical/sgp30.c | 1 + > drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +- > drivers/iio/dac/ad5064.c | 10 +++++----- > drivers/iio/dac/ad5360.c | 2 +- > drivers/iio/dac/ad5380.c | 2 +- > drivers/iio/dac/ad5421.c | 2 +- > drivers/iio/dac/ad5446.c | 11 +++++++---- > drivers/iio/dac/ad5449.c | 2 +- > drivers/iio/dac/ad5755.c | 2 +- > drivers/iio/dac/ad5758.c | 18 +++++++++--------- > drivers/iio/dac/ad5761.c | 2 +- > drivers/iio/dac/ad5764.c | 5 ++--- > drivers/iio/dac/ad5791.c | 10 ++++------ > drivers/iio/dac/ad7303.c | 5 ++++- > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > drivers/iio/dummy/iio_simple_dummy.c | 7 ++++--- > drivers/iio/dummy/iio_simple_dummy_buffer.c | 4 ++-- > drivers/iio/dummy/iio_simple_dummy_events.c | 4 +++- > drivers/iio/gyro/adis16080.c | 4 ++-- > drivers/iio/imu/kmx61.c | 14 +++++++------- > drivers/iio/light/cm32181.c | 8 ++++---- > drivers/iio/magnetometer/mmc35240.c | 4 ++-- > 28 files changed, 81 insertions(+), 73 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED492C433E1 for ; Sat, 18 Jul 2020 14:43:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC4092064B for ; Sat, 18 Jul 2020 14:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2BNDh393"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e2S1JMVG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC4092064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e8pPwn3Gu13VDNPAc6foULxRhsDB1qByWA/HudVcqmk=; b=2BNDh3933YY6cM944hvfoepFF YZDayGzXt/Y5/OsWC4CLwnWbiJ22b1c8QYLXDD1JBeMawpcfhFbUhL/kM1wThhwbGopHPzvuAY8HT zzqL9fcQ20BmsIYxDj2PO+M93esTG8GMJn7zOe0vrEb9oNJmJKxM7Ru2raB5amkG/82rH0zYjNeIP M4BikNhdXdTmjfHe8aKKwBEW7hE8i7RzJyMSRjwOuikZklfkde/vsf1zIOPZ2reIgWNSrq+5y1yJ0 PNseYwTvas81iuGUIVb+Sl8QiUMCBoh7rMNlGN8OvAmomaTGISTDLy1Fvo+zEgBaYL4Y6Vki6xJFn c4fjQnSfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwo2W-0004Fw-0Q; Sat, 18 Jul 2020 14:42:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwo2T-0004FF-4u for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 14:42:10 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C2D22064B; Sat, 18 Jul 2020 14:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595083328; bh=XBulFzLGPXfZn/iFjNwycrLQNdoeQbsMF6p0DhRyzB4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e2S1JMVG2nQgwAIsMY2pN5uSL2c1YL0L29xSaNiqlsXGxFguOGEvAEUZqLIewKfXN sdECk/OMdmTCggnhXnJShrT5XusLlq8inAhWEIOpiwYrE1C2CtLYOOYw2QPZy2fUY8 3S541EB0k/dqD2MGFEs8SFe9OT3SZ+5haRHViFvw= Date: Sat, 18 Jul 2020 15:42:04 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 00/30] First batch of W=1 fixes for IIO Message-ID: <20200718154204.280fcb83@archlinux> In-Reply-To: <20200716135928.1456727-1-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_104209_397382_CCC79243 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:58:58 +0100 Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Thanks for these. One general comment is I'd have appreciated a spot of grouping to bring a particular group of identical problems together in the series. Example being the @lock(:) ones in this set. It doesn't matter that much though. I'm just being fussy :) Jonathan > > Lee Jones (30): > iio: adc: ad_sigma_delta: Remove unused variable 'ret' > iio: accel: bma220_spi: Do not define 'struct acpi_device_id' when > !CONFIG_ACPI > iio: common: ms_sensors: ms_sensors_i2c: Fix misspelling of parameter > 'client' > iio: adc: ad7298: Demote obvious misuse of kerneldoc to standard > comment blocks > iio: chemical: sgp30: Add description for sgp_read_cmd()'s > 'duration_us' > iio: adc: ad7923: Demote obvious misuse of kerneldoc to standard > comment blocks > iio: dac: ad5360: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5380: Fix kerneldoc attribute formatting for 'lock' > iio: dummy: iio_simple_dummy: Demote unworthy kerneldocs and correct > misspelling > iio: dummy: iio_simple_dummy: Add newline after function-end > iio: dac: ad5421: Fix kerneldoc attribute formatting for 'lock' > iio: gyro: adis16080: Fix formatting issue and compiler attribute > ordering > iio: dummy: iio_simple_dummy_events: Demote file header and supply > descriptions for val2 params > iio: dac: ad5064: Value returned by ad5064_vref_name may not be 'const > * const' > iio: dummy: iio_dummy_evgen: Demote file header and supply description > for 'irq_sim_domain' > iio: adc: ad7887: Demote seemingly unintentional kerneldoc header > iio: adc: ad7949: Fix misspelling issue and compiler attribute > ordering > iio: dummy: iio_simple_dummy_buffer: Demote file header and correct > misspelling > iio: dac: ad5064: Fix a few kerneldoc misdemeanours > iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote > unworthy kerneldocs > iio: dac: ad5449: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5755: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5758: Move and fix-up kerneldoc header and demote unworthy > kerneldoc > iio: dac: ad5761: Fix kerneldoc attribute formatting for 'lock' > iio: dac: ad5764: Fix misdocumenting and formatting error > iio: dac: ad5791: Complete 'struct ad5791_chip_info' documentation > iio: light: cm32181: Fix formatting and docrot issues in > cm32181_acpi_get_cpm() > iio: magnetometer: mmc35240: Fix function header formatting > iio: imu: kmx61: Fix formatting in kerneldoc function headers > iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder > compiler attribute > > drivers/iio/accel/bma220_spi.c | 2 ++ > drivers/iio/adc/ad7298.c | 8 ++++---- > drivers/iio/adc/ad7887.c | 2 +- > drivers/iio/adc/ad7923.c | 8 ++++---- > drivers/iio/adc/ad7949.c | 4 ++-- > drivers/iio/adc/ad_sigma_delta.c | 7 ++----- > drivers/iio/chemical/sgp30.c | 1 + > drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +- > drivers/iio/dac/ad5064.c | 10 +++++----- > drivers/iio/dac/ad5360.c | 2 +- > drivers/iio/dac/ad5380.c | 2 +- > drivers/iio/dac/ad5421.c | 2 +- > drivers/iio/dac/ad5446.c | 11 +++++++---- > drivers/iio/dac/ad5449.c | 2 +- > drivers/iio/dac/ad5755.c | 2 +- > drivers/iio/dac/ad5758.c | 18 +++++++++--------- > drivers/iio/dac/ad5761.c | 2 +- > drivers/iio/dac/ad5764.c | 5 ++--- > drivers/iio/dac/ad5791.c | 10 ++++------ > drivers/iio/dac/ad7303.c | 5 ++++- > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > drivers/iio/dummy/iio_simple_dummy.c | 7 ++++--- > drivers/iio/dummy/iio_simple_dummy_buffer.c | 4 ++-- > drivers/iio/dummy/iio_simple_dummy_events.c | 4 +++- > drivers/iio/gyro/adis16080.c | 4 ++-- > drivers/iio/imu/kmx61.c | 14 +++++++------- > drivers/iio/light/cm32181.c | 8 ++++---- > drivers/iio/magnetometer/mmc35240.c | 4 ++-- > 28 files changed, 81 insertions(+), 73 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel