From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E25CC433E4 for ; Sat, 18 Jul 2020 14:54:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E2102076A for ; Sat, 18 Jul 2020 14:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084090; bh=Po5XWHPqjkgfnMSwLRt8/aD4yr9TfBMsgOcT8X0cu28=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ihz5y9HasjuMIgGNNocxCD7D67CHy7mBa8aHXj3KDicH1b+FrN8zbq/2VcfhPcBun 2KJyIv4OMYV1km0XslC/2uhKqGRKRaC3j8fKGhpBKEDu2CwY7xhnbnm6D+cyp89K8l rqyQAji6st8+Y1bzBQ766bmfsExtJEs/HAv/Kh8g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgGROyt (ORCPT ); Sat, 18 Jul 2020 10:54:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726627AbgGROyr (ORCPT ); Sat, 18 Jul 2020 10:54:47 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64E3D20717; Sat, 18 Jul 2020 14:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084087; bh=Po5XWHPqjkgfnMSwLRt8/aD4yr9TfBMsgOcT8X0cu28=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2bxVIdif2CrdyL2yaR3EnEJkleZKiaUI7OKBywd27l+1TDctGB3eJbJGhgK4O2d6N 4AFD1evlt58gk9emBsq59ooEKgNfKUooUmdTxF5Ma9K3yKbzqZDxd+ap+YsBUbCfCP YVUbDrONm9OKDlKChbEyWgUiFrx3lJtq+QzdpaQs= Date: Sat, 18 Jul 2020 15:54:42 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Barry Song <21cnbao@gmail.com>, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH 12/30] iio: gyro: adis16080: Fix formatting issue and compiler attribute ordering Message-ID: <20200718155442.14c420db@archlinux> In-Reply-To: <20200716135928.1456727-13-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-13-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:10 +0100 Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > gets confused if the variable does not follow the type/attribute > definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member 'lock' not described in 'adis16080_state' > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'adis16080_state' > > Cc: Michael Hennerich > Cc: Barry Song <21cnbao@gmail.com> > Signed-off-by: Lee Jones Hmm. You are going to have an awful lot of those ____cacheline_aligned ones. Might be worth thinking about whether we fix kernel-doc to cope with those. A quick grep suggests the vast majority of users of this have it after the element name. @Jon Corbet : What do you think? Looks like there is special handling already for ____cacheline_aligned_in_smp. Should we extend that to this case? Jonathan > --- > drivers/iio/gyro/adis16080.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/gyro/adis16080.c b/drivers/iio/gyro/adis16080.c > index 1b84b8e112fe1..f38f9abcccbb5 100644 > --- a/drivers/iio/gyro/adis16080.c > +++ b/drivers/iio/gyro/adis16080.c > @@ -38,14 +38,14 @@ struct adis16080_chip_info { > * @us: actual spi_device to write data > * @info: chip specific parameters > * @buf: transmit or receive buffer > - * @lock lock to protect buffer during reads > + * @lock: lock to protect buffer during reads > **/ > struct adis16080_state { > struct spi_device *us; > const struct adis16080_chip_info *info; > struct mutex lock; > > - __be16 buf ____cacheline_aligned; > + __be16 ____cacheline_aligned buf; > }; > > static int adis16080_read_sample(struct iio_dev *indio_dev, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35608C433E4 for ; Sat, 18 Jul 2020 14:56:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 012412076A for ; Sat, 18 Jul 2020 14:56:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ld9vlHBP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2bxVIdif" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 012412076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7KKntK+srxXyi5+l0xaigynoUMFpBsNsiUJGYVqH/zQ=; b=Ld9vlHBPSWTlLoRmmgv44c21l 6HZkvVSwCcCuJNtIft1/74uGEvGno+fqBzrk07AotSkDr+qbtJr+VS1kLekb6jdIuNtJ9bnNVsPOK ZjsVVJx8Eq6tttAH+b/NeK06q6iVlY+8HurXN2zqM+oVyQapF7hiwGfhosGxYc8NxpARaVBYq+VEg Doh9hHJ6TV1+wwPD+VZCiAO1TTclAclPzrAPOj+UpDpKJL/Fws1ZS447NnTgjfjpU9uYNOtGD7zdf QeUfg25AS+WkDia7khucxxvncAtcm6/2RmwLdHG2OWzxoWBIJe1w8mDhRkeVaH+FtwzhFCWlKDkzR ILpVexyQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoEl-0005nA-3Y; Sat, 18 Jul 2020 14:54:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoEi-0005mI-68 for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 14:54:49 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64E3D20717; Sat, 18 Jul 2020 14:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084087; bh=Po5XWHPqjkgfnMSwLRt8/aD4yr9TfBMsgOcT8X0cu28=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2bxVIdif2CrdyL2yaR3EnEJkleZKiaUI7OKBywd27l+1TDctGB3eJbJGhgK4O2d6N 4AFD1evlt58gk9emBsq59ooEKgNfKUooUmdTxF5Ma9K3yKbzqZDxd+ap+YsBUbCfCP YVUbDrONm9OKDlKChbEyWgUiFrx3lJtq+QzdpaQs= Date: Sat, 18 Jul 2020 15:54:42 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 12/30] iio: gyro: adis16080: Fix formatting issue and compiler attribute ordering Message-ID: <20200718155442.14c420db@archlinux> In-Reply-To: <20200716135928.1456727-13-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-13-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_105448_388528_37052A44 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , Jonathan Corbet , linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:10 +0100 Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > gets confused if the variable does not follow the type/attribute > definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member 'lock' not described in 'adis16080_state' > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'adis16080_state' > > Cc: Michael Hennerich > Cc: Barry Song <21cnbao@gmail.com> > Signed-off-by: Lee Jones Hmm. You are going to have an awful lot of those ____cacheline_aligned ones. Might be worth thinking about whether we fix kernel-doc to cope with those. A quick grep suggests the vast majority of users of this have it after the element name. @Jon Corbet : What do you think? Looks like there is special handling already for ____cacheline_aligned_in_smp. Should we extend that to this case? Jonathan > --- > drivers/iio/gyro/adis16080.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/gyro/adis16080.c b/drivers/iio/gyro/adis16080.c > index 1b84b8e112fe1..f38f9abcccbb5 100644 > --- a/drivers/iio/gyro/adis16080.c > +++ b/drivers/iio/gyro/adis16080.c > @@ -38,14 +38,14 @@ struct adis16080_chip_info { > * @us: actual spi_device to write data > * @info: chip specific parameters > * @buf: transmit or receive buffer > - * @lock lock to protect buffer during reads > + * @lock: lock to protect buffer during reads > **/ > struct adis16080_state { > struct spi_device *us; > const struct adis16080_chip_info *info; > struct mutex lock; > > - __be16 buf ____cacheline_aligned; > + __be16 ____cacheline_aligned buf; > }; > > static int adis16080_read_sample(struct iio_dev *indio_dev, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel