From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47480C433E0 for ; Sat, 18 Jul 2020 15:00:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2722C20775 for ; Sat, 18 Jul 2020 15:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084453; bh=26CBZjL7uvp6pS4YJG28uV1EtS6Ger0+vvpXKdu430E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=gaG+t63Yic0ublr2r+JW9msJBqHRYusCNVJTeGxjHXin7lCZdIeh/U7XQ/buW1H1g MapqC2EMROLP1KTDt30XWvP50vHfk/UZmr00fbJ9AMNuStgzO06S2pFJF5AYXw5Uls igEnLAWnXe4a/QQ8KMTOnRwvjLSG8VTstAfaelz0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbgGRPAw (ORCPT ); Sat, 18 Jul 2020 11:00:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:35318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbgGRPAv (ORCPT ); Sat, 18 Jul 2020 11:00:51 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EC172065D; Sat, 18 Jul 2020 15:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084451; bh=26CBZjL7uvp6pS4YJG28uV1EtS6Ger0+vvpXKdu430E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c6y2Jzwsq9GEB8orElY1PDFiEzojam1SOGInKYWRa3q0d78aF8VaE0+yxfyQ4NAGP forLr72tGJa/59KF+SPTU9j0rdR2+04BJeUxAyI0phuq85OrMH1QK3kh7vhsJ3bjhc OzgYJ56E9U3yCpBOYGfwJfIpsvxlZMQBkap/jH28= Date: Sat, 18 Jul 2020 16:00:46 +0100 From: Jonathan Cameron To: Bartosz Golaszewski Cc: Lee Jones , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , arm-soc , LKML , linux-iio , Marc Zyngier Subject: Re: [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' Message-ID: <20200718160046.5d1c8abb@archlinux> In-Reply-To: References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-16-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Jul 2020 11:24:40 +0200 Bartosz Golaszewski wrote: > On Thu, Jul 16, 2020 at 3:59 PM Lee Jones wrote: > > > > File headers are not good candidates for kerneldoc. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/dummy/iio_dummy_evgen.c:30: warning: Cannot understand * @regs: irq regs we are faking > > on line 30 - I thought it was a doc line > > drivers/iio/dummy/iio_dummy_evgen.c:42: warning: Function parameter or member 'irq_sim_domain' not described in 'iio_dummy_eventgen' > > > > Cc: Marc Zyngier > > Cc: Bartosz Golaszewski > > Signed-off-by: Lee Jones > > --- > > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c > > index ee85d596e5284..1febbbff0ded6 100644 > > --- a/drivers/iio/dummy/iio_dummy_evgen.c > > +++ b/drivers/iio/dummy/iio_dummy_evgen.c > > @@ -1,5 +1,5 @@ > > // SPDX-License-Identifier: GPL-2.0-only > > -/** > > +/* > > * Copyright (c) 2011 Jonathan Cameron > > * > > * Companion module to the iio simple dummy example driver. > > @@ -27,11 +27,13 @@ > > #define IIO_EVENTGEN_NO 10 > > > > /** > > + * struct iio_dummy_eventgen Good to say what this structure is. Perhaps "event generator specific state" > > * @regs: irq regs we are faking > > * @lock: protect the evgen state > > * @inuse: mask of which irqs are connected > > * @irq_sim: interrupt simulator > > * @base: base of irq range > > + * @irq_sim_domain: irq domain > > To be even more clear: this could say: "interrupt simulator domain". > > Bartosz > > > */ > > struct iio_dummy_eventgen { > > struct iio_dummy_regs regs[IIO_EVENTGEN_NO]; > > -- > > 2.25.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4745FC433E0 for ; Sat, 18 Jul 2020 15:02:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 142F12065D for ; Sat, 18 Jul 2020 15:02:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g2LhTnmw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="c6y2Jzws" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 142F12065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bQ6d8s57OMaX9VSEDxDVohQdjR2Wn3Y78daCB/EF7s0=; b=g2LhTnmwuTKLZgs5JtXdcNypN xK8o7b44dYEkLvb48JpynKl682QyQVlt46UQnX60bMLEFwsIOORbEpr3j7JKfNMIZewrVKcinzbNj V8nablOm3LesVCnn0ZgwmAIupE7BR+1Nn8s0i940j9K2MUasbhTAfyZ4WIkqP4TIDYdOSs+EIlSie 0r59yvqnaJ3OVBA06r3MpsxEDXLNu0+wRWzHhQpnSsD149TmVrl1cDiqU4GKFTEzCr/CZHPiY9tm6 a9hcTEIvVOBbhBjRWICf9MAE9JExIiNAIpR9+Ng3AjyLYWlUSxa9K9ldIiLKUTfWyXgK64413R30J dBdbeK2ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoKc-0006tX-HA; Sat, 18 Jul 2020 15:00:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoKa-0006sc-4F for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:00:52 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EC172065D; Sat, 18 Jul 2020 15:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084451; bh=26CBZjL7uvp6pS4YJG28uV1EtS6Ger0+vvpXKdu430E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c6y2Jzwsq9GEB8orElY1PDFiEzojam1SOGInKYWRa3q0d78aF8VaE0+yxfyQ4NAGP forLr72tGJa/59KF+SPTU9j0rdR2+04BJeUxAyI0phuq85OrMH1QK3kh7vhsJ3bjhc OzgYJ56E9U3yCpBOYGfwJfIpsvxlZMQBkap/jH28= Date: Sat, 18 Jul 2020 16:00:46 +0100 From: Jonathan Cameron To: Bartosz Golaszewski Subject: Re: [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' Message-ID: <20200718160046.5d1c8abb@archlinux> In-Reply-To: References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-16-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_110052_241126_BAD74B4A X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio , Marc Zyngier , LKML , Peter Meerwald-Stadler , Hartmut Knaack , Lee Jones , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 18 Jul 2020 11:24:40 +0200 Bartosz Golaszewski wrote: > On Thu, Jul 16, 2020 at 3:59 PM Lee Jones wrote: > > > > File headers are not good candidates for kerneldoc. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/dummy/iio_dummy_evgen.c:30: warning: Cannot understand * @regs: irq regs we are faking > > on line 30 - I thought it was a doc line > > drivers/iio/dummy/iio_dummy_evgen.c:42: warning: Function parameter or member 'irq_sim_domain' not described in 'iio_dummy_eventgen' > > > > Cc: Marc Zyngier > > Cc: Bartosz Golaszewski > > Signed-off-by: Lee Jones > > --- > > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c > > index ee85d596e5284..1febbbff0ded6 100644 > > --- a/drivers/iio/dummy/iio_dummy_evgen.c > > +++ b/drivers/iio/dummy/iio_dummy_evgen.c > > @@ -1,5 +1,5 @@ > > // SPDX-License-Identifier: GPL-2.0-only > > -/** > > +/* > > * Copyright (c) 2011 Jonathan Cameron > > * > > * Companion module to the iio simple dummy example driver. > > @@ -27,11 +27,13 @@ > > #define IIO_EVENTGEN_NO 10 > > > > /** > > + * struct iio_dummy_eventgen Good to say what this structure is. Perhaps "event generator specific state" > > * @regs: irq regs we are faking > > * @lock: protect the evgen state > > * @inuse: mask of which irqs are connected > > * @irq_sim: interrupt simulator > > * @base: base of irq range > > + * @irq_sim_domain: irq domain > > To be even more clear: this could say: "interrupt simulator domain". > > Bartosz > > > */ > > struct iio_dummy_eventgen { > > struct iio_dummy_regs regs[IIO_EVENTGEN_NO]; > > -- > > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel