From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553F2C433DF for ; Sat, 18 Jul 2020 15:02:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28D422076A for ; Sat, 18 Jul 2020 15:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084551; bh=uPmy615wj1O+XHgWbWdN70//remefX009xQEmoQDO7c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Xn/xNA5k6Gb/g4U/xtspmq0C4GDGR6jViPJlX9jpmkYKmA/U1ELSYIVBhReUcUSgz XDTQemngfdrESyHStN9E+AhLw42lptUB5qOQ2xLN2snki4SCu24lC4E1VLIWRglc7u /OM4kMU0FyZ5230RkWhMGcj2058nL+egoCSvMTs4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbgGRPCa (ORCPT ); Sat, 18 Jul 2020 11:02:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:35580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbgGRPC3 (ORCPT ); Sat, 18 Jul 2020 11:02:29 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 988B12065D; Sat, 18 Jul 2020 15:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084549; bh=uPmy615wj1O+XHgWbWdN70//remefX009xQEmoQDO7c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FywgDekd004YOLH9XanyY34r4zLpYpezSZ4ajm2euqNB3jnzLRlf+b5YFdeM+1bQ/ D0DBiTasduqKRPnrTsyE1PRMQ+Sr4OKEB4AM5pILa1MmDZ+wSvISCAUNPAG8znDFD5 ewZtEh11VZZXUI5z0OAPPmqiTfiScro2IKCDuxD8= Date: Sat, 18 Jul 2020 16:02:24 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 18/30] iio: dummy: iio_simple_dummy_buffer: Demote file header and correct misspelling Message-ID: <20200718160224.3c28bc2c@archlinux> In-Reply-To: <20200716135928.1456727-19-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-19-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:16 +0100 Lee Jones wrote: > File headers are not good candidates for kerneldoc. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dummy/iio_simple_dummy_buffer.c:27: warning: cannot understand function prototype: 'const s16 fakedata[] = ' > drivers/iio/dummy/iio_simple_dummy_buffer.c:185: warning: Function parameter or member 'indio_dev' not described in 'iio_simple_dummy_unconfigure_buffer' > drivers/iio/dummy/iio_simple_dummy_buffer.c:185: warning: Excess function parameter 'indo_dev' description in 'iio_simple_dummy_unconfigure_buffer' > > Signed-off-by: Lee Jones Applied. Jonathan > --- > drivers/iio/dummy/iio_simple_dummy_buffer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dummy/iio_simple_dummy_buffer.c b/drivers/iio/dummy/iio_simple_dummy_buffer.c > index 17606eca42b43..40d30c0a60ce5 100644 > --- a/drivers/iio/dummy/iio_simple_dummy_buffer.c > +++ b/drivers/iio/dummy/iio_simple_dummy_buffer.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > -/** > +/* > * Copyright (c) 2011 Jonathan Cameron > * > * Buffer handling elements of industrial I/O reference driver. > @@ -179,7 +179,7 @@ int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev) > > /** > * iio_simple_dummy_unconfigure_buffer() - release buffer resources > - * @indo_dev: device instance state > + * @indio_dev: device instance state > */ > void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev) > { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA496C433E0 for ; Sat, 18 Jul 2020 15:03:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 975AF2065D for ; Sat, 18 Jul 2020 15:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2d9yunqt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FywgDekd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 975AF2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pMkrPaimF92ytsqmJPu5s52CJKF5Y9tJVF8hf9EgjD4=; b=2d9yunqtqiVIHkgbG/SryAs95 2iaEWfxQ/yLe6uxo4poY0SiwSf/APvQNV7cQP4N9kYOiI4FWHUxN4vP05TKb9EE9ekjsWjL/UDJ71 cnHZVrLSie9DyiIZNJZgURo2gE6tLmkln0ONumQcjgWLcYiZz8fzHFZ/JIo9p1XJrp2eGOMiaGE3j wZG0Ecy8ol2mnCyOqPcWsswR4oE9+z3ktMAtavJvzI2vNQhSeodsbjeBeIQF1sucA7yyMSdCQHlc6 nVbaYywdqdn2lbPfpQ5BT2GWloI19RfWsYN4dnLUoBBy0y7ille5QfDmj7eQHMj4PH43GzvvIfeg8 4qvDpZY5g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoMC-0007Cm-Mg; Sat, 18 Jul 2020 15:02:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoM9-0007Bi-Kn for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:02:30 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 988B12065D; Sat, 18 Jul 2020 15:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084549; bh=uPmy615wj1O+XHgWbWdN70//remefX009xQEmoQDO7c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FywgDekd004YOLH9XanyY34r4zLpYpezSZ4ajm2euqNB3jnzLRlf+b5YFdeM+1bQ/ D0DBiTasduqKRPnrTsyE1PRMQ+Sr4OKEB4AM5pILa1MmDZ+wSvISCAUNPAG8znDFD5 ewZtEh11VZZXUI5z0OAPPmqiTfiScro2IKCDuxD8= Date: Sat, 18 Jul 2020 16:02:24 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 18/30] iio: dummy: iio_simple_dummy_buffer: Demote file header and correct misspelling Message-ID: <20200718160224.3c28bc2c@archlinux> In-Reply-To: <20200716135928.1456727-19-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-19-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_110229_807984_1BA5A800 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:16 +0100 Lee Jones wrote: > File headers are not good candidates for kerneldoc. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dummy/iio_simple_dummy_buffer.c:27: warning: cannot understand function prototype: 'const s16 fakedata[] = ' > drivers/iio/dummy/iio_simple_dummy_buffer.c:185: warning: Function parameter or member 'indio_dev' not described in 'iio_simple_dummy_unconfigure_buffer' > drivers/iio/dummy/iio_simple_dummy_buffer.c:185: warning: Excess function parameter 'indo_dev' description in 'iio_simple_dummy_unconfigure_buffer' > > Signed-off-by: Lee Jones Applied. Jonathan > --- > drivers/iio/dummy/iio_simple_dummy_buffer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dummy/iio_simple_dummy_buffer.c b/drivers/iio/dummy/iio_simple_dummy_buffer.c > index 17606eca42b43..40d30c0a60ce5 100644 > --- a/drivers/iio/dummy/iio_simple_dummy_buffer.c > +++ b/drivers/iio/dummy/iio_simple_dummy_buffer.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > -/** > +/* > * Copyright (c) 2011 Jonathan Cameron > * > * Buffer handling elements of industrial I/O reference driver. > @@ -179,7 +179,7 @@ int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev) > > /** > * iio_simple_dummy_unconfigure_buffer() - release buffer resources > - * @indo_dev: device instance state > + * @indio_dev: device instance state > */ > void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev) > { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel